From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
Ben Segall <bsegall@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Will Deacon <will@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Naveen N Rao <naveen@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 5/9] powerpc: Use preempt_model_str().
Date: Mon, 3 Feb 2025 17:01:03 +0100 [thread overview]
Message-ID: <20250203160103.9DikC9FJ@linutronix.de> (raw)
In-Reply-To: <65c6f60d-bb52-48bd-a02c-87ffd2a915d4@csgroup.eu>
On 2025-02-03 16:19:06 [+0100], Christophe Leroy wrote:
>
>
> Le 03/02/2025 à 15:16, Sebastian Andrzej Siewior a écrit :
> > Use preempt_model_str() instead of manually conducting the preemption
> > model. Use pr_emerg() instead of printk() to pass a loglevel.
>
> Why use pr_emerg() for that line and not all other ones ?
checkpatch complained for the current printk() line and this looks like
an emergency coming from die().
> The purpose of using printk() is to get it at the level defined by
> CONFIG_MESSAGE_LOGLEVEL_DEFAULT and I think it is important to have the full
> Oops block at the same level.
Okay. So "printk(KERN_DEFAULT " then.
Sebastian
next prev parent reply other threads:[~2025-02-03 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250203141632.440554-1-bigeasy@linutronix.de>
2025-02-03 14:16 ` [PATCH v2 5/9] powerpc: Use preempt_model_str() Sebastian Andrzej Siewior
2025-02-03 15:19 ` Christophe Leroy
2025-02-03 16:01 ` Sebastian Andrzej Siewior [this message]
2025-02-03 16:37 ` Christophe Leroy
2025-02-04 8:22 ` [PATCH v3 " Sebastian Andrzej Siewior
2025-02-05 6:48 ` Christophe Leroy
2025-02-08 7:35 ` Shrikanth Hegde
2025-02-08 12:55 ` Christophe Leroy
2025-02-08 13:42 ` Shrikanth Hegde
2025-02-08 17:55 ` Christophe Leroy
2025-02-09 14:38 ` Shrikanth Hegde
2025-02-09 18:42 ` Christophe Leroy
2025-02-10 10:59 ` Sebastian Andrzej Siewior
2025-02-10 14:23 ` Sebastian Andrzej Siewior
2025-02-10 17:32 ` Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203160103.9DikC9FJ@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sshegde@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).