* [RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show_config()
@ 2025-02-09 8:17 Thorsten Blum
2025-02-09 9:16 ` Christophe Leroy
0 siblings, 1 reply; 3+ messages in thread
From: Thorsten Blum @ 2025-02-09 8:17 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Naveen N Rao, Hari Bathini, Sourabh Jain,
Ritesh Harjani (IBM), Aneesh Kumar K.V (IBM), Bjorn Helgaas
Cc: Thorsten Blum, Baoquan He, linuxppc-dev, linux-kernel
Remove hard-coded strings by using the str_yes_no() helper function.
Reviewed-by: Sourabh Jain <sourabhjain@linux.ibm.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/powerpc/kernel/fadump.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
index 4b371c738213..8c531533dd3e 100644
--- a/arch/powerpc/kernel/fadump.c
+++ b/arch/powerpc/kernel/fadump.c
@@ -289,10 +289,8 @@ static void __init fadump_show_config(void)
if (!fw_dump.fadump_supported)
return;
- pr_debug("Fadump enabled : %s\n",
- (fw_dump.fadump_enabled ? "yes" : "no"));
- pr_debug("Dump Active : %s\n",
- (fw_dump.dump_active ? "yes" : "no"));
+ pr_debug("Fadump enabled : %s\n", str_yes_no(fw_dump.fadump_enabled));
+ pr_debug("Dump Active : %s\n", str_yes_no(fw_dump.dump_active));
pr_debug("Dump section sizes:\n");
pr_debug(" CPU state data size: %lx\n", fw_dump.cpu_state_data_size);
pr_debug(" HPTE region size : %lx\n", fw_dump.hpte_region_size);
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show_config()
2025-02-09 8:17 [RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show_config() Thorsten Blum
@ 2025-02-09 9:16 ` Christophe Leroy
2025-02-09 10:01 ` Thorsten Blum
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy @ 2025-02-09 9:16 UTC (permalink / raw)
To: Thorsten Blum, Madhavan Srinivasan, Michael Ellerman,
Nicholas Piggin, Naveen N Rao, Hari Bathini, Sourabh Jain,
Ritesh Harjani (IBM), Aneesh Kumar K.V (IBM), Bjorn Helgaas
Cc: Baoquan He, linuxppc-dev, linux-kernel
Hi,
Le 09/02/2025 à 09:17, Thorsten Blum a écrit :
> Remove hard-coded strings by using the str_yes_no() helper function.
>
> Reviewed-by: Sourabh Jain <sourabhjain@linux.ibm.com>
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Any reason for resending ? Your patch is not lost, see
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=89400
If there is a reason that you don't want to put in the commit message,
just put it here below under the ---
> ---
> arch/powerpc/kernel/fadump.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
> index 4b371c738213..8c531533dd3e 100644
> --- a/arch/powerpc/kernel/fadump.c
> +++ b/arch/powerpc/kernel/fadump.c
> @@ -289,10 +289,8 @@ static void __init fadump_show_config(void)
> if (!fw_dump.fadump_supported)
> return;
>
> - pr_debug("Fadump enabled : %s\n",
> - (fw_dump.fadump_enabled ? "yes" : "no"));
> - pr_debug("Dump Active : %s\n",
> - (fw_dump.dump_active ? "yes" : "no"));
> + pr_debug("Fadump enabled : %s\n", str_yes_no(fw_dump.fadump_enabled));
> + pr_debug("Dump Active : %s\n", str_yes_no(fw_dump.dump_active));
> pr_debug("Dump section sizes:\n");
> pr_debug(" CPU state data size: %lx\n", fw_dump.cpu_state_data_size);
> pr_debug(" HPTE region size : %lx\n", fw_dump.hpte_region_size);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show_config()
2025-02-09 9:16 ` Christophe Leroy
@ 2025-02-09 10:01 ` Thorsten Blum
0 siblings, 0 replies; 3+ messages in thread
From: Thorsten Blum @ 2025-02-09 10:01 UTC (permalink / raw)
To: Christophe Leroy
Cc: Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Naveen N Rao, Hari Bathini, Sourabh Jain, Ritesh Harjani (IBM),
Aneesh Kumar K.V (IBM), Bjorn Helgaas, Baoquan He, linuxppc-dev,
linux-kernel
On 9. Feb 2025, at 10:16, Christophe Leroy wrote:
> Le 09/02/2025 à 09:17, Thorsten Blum a écrit :
>> Remove hard-coded strings by using the str_yes_no() helper function.
>> Reviewed-by: Sourabh Jain <sourabhjain@linux.ibm.com>
>> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>
> Any reason for resending ? Your patch is not lost, see https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=89400
Ah sorry, I missed this. It's sometimes hard to know the status of a
patch when it's not in next yet.
Thanks,
Thorsten
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-09 10:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-09 8:17 [RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show_config() Thorsten Blum
2025-02-09 9:16 ` Christophe Leroy
2025-02-09 10:01 ` Thorsten Blum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).