* [PATCH v2] powerpc/crash: Fix non-smp kexec preparation
@ 2025-02-11 16:20 Eddie James
2025-02-17 6:33 ` Hari Bathini
2025-05-04 3:21 ` Madhavan Srinivasan
0 siblings, 2 replies; 3+ messages in thread
From: Eddie James @ 2025-02-11 16:20 UTC (permalink / raw)
To: linuxppc-dev
Cc: maddy, mpe, npiggin, christophe.leroy, naveen, hbathini, eajames
In non-smp configurations, crash_kexec_prepare is never called in
the crash shutdown path. One result of this is that the crashing_cpu
variable is never set, preventing crash_save_cpu from storing the
NT_PRSTATUS elf note in the core dump.
Fixes: c7255058b543 ("powerpc/crash: save cpu register data in crash_smp_send_stop()")
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
Changes since v1:
- Use if (IS_ENABLED(CONFIG_SMP)) instead of #ifdef CONFIG_SMP
arch/powerpc/kexec/crash.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kexec/crash.c b/arch/powerpc/kexec/crash.c
index 9ac3266e49652..a325c1c02f96d 100644
--- a/arch/powerpc/kexec/crash.c
+++ b/arch/powerpc/kexec/crash.c
@@ -359,7 +359,10 @@ void default_machine_crash_shutdown(struct pt_regs *regs)
if (TRAP(regs) == INTERRUPT_SYSTEM_RESET)
is_via_system_reset = 1;
- crash_smp_send_stop();
+ if (IS_ENABLED(CONFIG_SMP))
+ crash_smp_send_stop();
+ else
+ crash_kexec_prepare();
crash_save_cpu(regs, crashing_cpu);
--
2.43.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] powerpc/crash: Fix non-smp kexec preparation
2025-02-11 16:20 [PATCH v2] powerpc/crash: Fix non-smp kexec preparation Eddie James
@ 2025-02-17 6:33 ` Hari Bathini
2025-05-04 3:21 ` Madhavan Srinivasan
1 sibling, 0 replies; 3+ messages in thread
From: Hari Bathini @ 2025-02-17 6:33 UTC (permalink / raw)
To: Eddie James, linuxppc-dev; +Cc: maddy, mpe, npiggin, christophe.leroy, naveen
Hi Eddie,
On 11/02/25 9:50 pm, Eddie James wrote:
> In non-smp configurations, crash_kexec_prepare is never called in
> the crash shutdown path. One result of this is that the crashing_cpu
> variable is never set, preventing crash_save_cpu from storing the
> NT_PRSTATUS elf note in the core dump.
>
Thanks for fixing this.
Looks good to me.
Reviewed-by: Hari Bathini <hbathini@linux.ibm.com>
> Fixes: c7255058b543 ("powerpc/crash: save cpu register data in crash_smp_send_stop()")
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> Changes since v1:
> - Use if (IS_ENABLED(CONFIG_SMP)) instead of #ifdef CONFIG_SMP
>
> arch/powerpc/kexec/crash.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kexec/crash.c b/arch/powerpc/kexec/crash.c
> index 9ac3266e49652..a325c1c02f96d 100644
> --- a/arch/powerpc/kexec/crash.c
> +++ b/arch/powerpc/kexec/crash.c
> @@ -359,7 +359,10 @@ void default_machine_crash_shutdown(struct pt_regs *regs)
> if (TRAP(regs) == INTERRUPT_SYSTEM_RESET)
> is_via_system_reset = 1;
>
> - crash_smp_send_stop();
> + if (IS_ENABLED(CONFIG_SMP))
> + crash_smp_send_stop();
> + else
> + crash_kexec_prepare();
>
> crash_save_cpu(regs, crashing_cpu);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] powerpc/crash: Fix non-smp kexec preparation
2025-02-11 16:20 [PATCH v2] powerpc/crash: Fix non-smp kexec preparation Eddie James
2025-02-17 6:33 ` Hari Bathini
@ 2025-05-04 3:21 ` Madhavan Srinivasan
1 sibling, 0 replies; 3+ messages in thread
From: Madhavan Srinivasan @ 2025-05-04 3:21 UTC (permalink / raw)
To: linuxppc-dev, Eddie James
Cc: mpe, npiggin, christophe.leroy, naveen, hbathini
On Tue, 11 Feb 2025 10:20:54 -0600, Eddie James wrote:
> In non-smp configurations, crash_kexec_prepare is never called in
> the crash shutdown path. One result of this is that the crashing_cpu
> variable is never set, preventing crash_save_cpu from storing the
> NT_PRSTATUS elf note in the core dump.
>
>
Applied to powerpc/next.
[1/1] powerpc/crash: Fix non-smp kexec preparation
https://git.kernel.org/powerpc/c/882b25af265de8e05c66f72b9a29f6047102958f
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-04 3:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-11 16:20 [PATCH v2] powerpc/crash: Fix non-smp kexec preparation Eddie James
2025-02-17 6:33 ` Hari Bathini
2025-05-04 3:21 ` Madhavan Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).