From: Sathvika Vasireddy <sv@linux.ibm.com>
To: jpoimboe@kernel.org, peterz@infradead.org,
christophe.leroy@csgroup.eu, npiggin@gmail.com,
maddy@linux.ibm.com
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
llvm@lists.linux.dev, sv@linux.ibm.com
Subject: [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern
Date: Wed, 19 Feb 2025 21:50:14 +0530 [thread overview]
Message-ID: <20250219162014.10334-1-sv@linux.ibm.com> (raw)
Architectures like PowerPC use a pattern where the compiler generates a
branch-and-link (bl) instruction that targets the very next instruction,
followed by loading the link register (mflr) later. This pattern appears
in the code like:
bl .+4
li r5,0
mflr r30
Objtool currently warns about this as an "unannotated intra-function
call" because find_call_destination() fails to find any symbol at the
target offset. Add a check to skip the warning when a branch targets
the immediate next instruction in the same function.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502180818.XnFdv8I8-lkp@intel.com/
Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
---
tools/objtool/check.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 753dbc4f8198..3f7cf2c917b5 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1613,6 +1613,7 @@ static struct symbol *find_call_destination(struct section *sec, unsigned long o
*/
static int add_call_destinations(struct objtool_file *file)
{
+ struct instruction *next_insn;
struct instruction *insn;
unsigned long dest_off;
struct symbol *dest;
@@ -1625,6 +1626,11 @@ static int add_call_destinations(struct objtool_file *file)
reloc = insn_reloc(file, insn);
if (!reloc) {
dest_off = arch_jump_destination(insn);
+
+ next_insn = next_insn_same_func(file, insn);
+ if (next_insn && dest_off == next_insn->offset)
+ continue;
+
dest = find_call_destination(insn->sec, dest_off);
add_call_dest(file, insn, dest, false);
--
2.39.3
next reply other threads:[~2025-02-19 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 16:20 Sathvika Vasireddy [this message]
2025-02-20 19:59 ` [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern Josh Poimboeuf
2025-02-21 8:50 ` Sathvika Vasireddy
2025-02-24 10:36 ` Christophe Leroy
2025-02-24 12:35 ` Peter Zijlstra
2025-02-24 16:25 ` Peter Zijlstra
2025-02-24 17:54 ` Christophe Leroy
2025-02-24 7:15 ` Christophe Leroy
2025-02-24 10:33 ` Christophe Leroy
2025-02-24 13:19 ` Christophe Leroy
2025-02-24 17:09 ` Nathan Chancellor
2025-02-25 7:35 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219162014.10334-1-sv@linux.ibm.com \
--to=sv@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).