From: Peter Zijlstra <peterz@infradead.org>
To: Sathvika Vasireddy <sv@linux.ibm.com>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
christophe.leroy@csgroup.eu, npiggin@gmail.com,
maddy@linux.ibm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev
Subject: Re: [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern
Date: Mon, 24 Feb 2025 17:25:42 +0100 [thread overview]
Message-ID: <20250224162542.GE11590@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <4bea75bc-d3f6-4972-b644-f9b5a4e8bb77@linux.ibm.com>
On Fri, Feb 21, 2025 at 02:20:41PM +0530, Sathvika Vasireddy wrote:
> > > @@ -1625,6 +1626,11 @@ static int add_call_destinations(struct objtool_file *file)
> > > reloc = insn_reloc(file, insn);
> > > if (!reloc) {
> > > dest_off = arch_jump_destination(insn);
> > > +
> > > + next_insn = next_insn_same_func(file, insn);
> > > + if (next_insn && dest_off == next_insn->offset)
> > > + continue;
> > > +
> > This won't work on x86, where an intra-function call is converted to a
> > stack-modifying JUMP. So this should probably be checked in an
> > arch-specific function.
>
> Thanks for letting me know, I'll introduce arch_skip_call_warning() to
> handle architecture specific cases in the next patch I send.
Can't you detect this pattern in decode and simpy not emit the call
instruction?
next prev parent reply other threads:[~2025-02-24 16:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 16:20 [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern Sathvika Vasireddy
2025-02-20 19:59 ` Josh Poimboeuf
2025-02-21 8:50 ` Sathvika Vasireddy
2025-02-24 10:36 ` Christophe Leroy
2025-02-24 12:35 ` Peter Zijlstra
2025-02-24 16:25 ` Peter Zijlstra [this message]
2025-02-24 17:54 ` Christophe Leroy
2025-02-24 7:15 ` Christophe Leroy
2025-02-24 10:33 ` Christophe Leroy
2025-02-24 13:19 ` Christophe Leroy
2025-02-24 17:09 ` Nathan Chancellor
2025-02-25 7:35 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224162542.GE11590@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=christophe.leroy@csgroup.eu \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=sv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).