From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 355BFC19F32 for ; Wed, 5 Mar 2025 09:03:08 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Z765k3Bvmz30WR; Wed, 5 Mar 2025 20:03:06 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1741165386; cv=none; b=jTmknspIxNSMwyoYaQhfjySeq+wf/XHa7GcS/+EwxTMSa9uJph57PdIgqGTGgshT+VzNyk9oOMHxKFzWUCRwU6reyg5vSrWieUznpPhhWQwRj1/5vKaHSMtLk84PgR35psDb2wQv/uCYPD+AVfpW6DorZcBKy6EgUF8ediUCZPuLCXbQxBXI0dhlZ6LEMyDfHv5KpwwWF9yuJfRZEsQXmHc4Hu9J/Toh0VSqMkuG7Pw0ojxfUxwudSliqBRmRXwZ2MACccbmma+xWN1w9kJE2MEJUAqishPIjsDH1gd1cV04tzBfPrptbUHQBFhIZGjrwXvut0ZnFfxsySCx1GW2SA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1741165386; c=relaxed/relaxed; bh=n1z2e9mVbdazKv/D+7yQN/ZVbR7ipkcxFW+oD3l7Rjw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GY8jczaAMFH4kycphIs1yzgJMAlgX6sAJ9O4NSNo7fMVUm7SbnD8hYxN7vMhsO+29P+N5iRwGf3Q19WLuWcW6CWvHlPlwrwkJP3yONriY3YXzUt3WaCjY0MBWViAb8bMP0aJV3yn7k+lhUX1MEe/D4+HyIP6m7ig+keSVYVBEJrkeJmCz0p1Z8J9IkFIg3l+LxKPspdgGfII9fbAaoxDIlqMFJ2lMs9Rtggie7cPIxrH4BfJtieEuFhW7Fb+S7rx8ndA1cwFF9m+sPy7Syv6LGtNPLmhCiw6Gg912COODrgNSJTM3U78GZyvMGiDvEeth8euhfGtBeWqVgtzbLKTyQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=idXzb7jg; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=gautam@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=idXzb7jg; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=gautam@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Z765j2xNQz30CF for ; Wed, 5 Mar 2025 20:03:05 +1100 (AEDT) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5258fDFP008325; Wed, 5 Mar 2025 09:02:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=n1z2e9mVbdazKv/D+7yQN/ZVbR7ipkcxFW+oD3l7R jw=; b=idXzb7jgXBXuYsVeJaUSaDwesp7bkOuVKlFflWDLVQE0v3VlGp4pMrW/K A8ba3gCk4MOS4Avf9JhpocEc7A5EZsvAdcf+UN2izFKnplbH5s8W8RKbZ8+DWlc5 5WiWygaRdYk75hWB9z9Gilv7+GZe3QJgZZs2VaF/HYZKp0KKWCYMYsoBaO7JpL1X tj9i3UZ54p+awFkROvBWeOfi4UrfTkJvn6Uewo6Bg+Aj1si0xo3ZJEHVG3Ar35Ve ohD+ufGw8rwbiBTobeiwnXYrHA7zJzjokErbPyUMpMIfC98QESyIokSCBNx/SKJf zdZos9SL0L5HGny92XYHJcH0OdUlw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4568ppahp9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Mar 2025 09:02:46 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 5258vqXG029793; Wed, 5 Mar 2025 09:02:46 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4568ppahp6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Mar 2025 09:02:45 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5257gU36013776; Wed, 5 Mar 2025 09:02:45 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 454e2ksvth-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Mar 2025 09:02:45 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 52592fPf24773228 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Mar 2025 09:02:41 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5396820040; Wed, 5 Mar 2025 09:02:41 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8AD1A20043; Wed, 5 Mar 2025 09:02:39 +0000 (GMT) Received: from li-c6426e4c-27cf-11b2-a85c-95d65bc0de0e.in.ibm.com (unknown [9.204.206.66]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 5 Mar 2025 09:02:39 +0000 (GMT) From: Gautam Menghani To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, naveen@kernel.org Cc: Gautam Menghani , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, vaibhav@linux.ibm.com Subject: [PATCH] powerpc/pseries/msi: Avoid reading PCI device registers in reduced power states Date: Wed, 5 Mar 2025 14:32:36 +0530 Message-ID: <20250305090237.294633-1-gautam@linux.ibm.com> X-Mailer: git-send-email 2.47.0 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: XMEYmXGLWR-uqDp97woI17Cud8XvfrSk X-Proofpoint-ORIG-GUID: qBkNYmHN-zrEB8W6tWAMSOdOUG5YmdZY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-05_03,2025-03-05_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 malwarescore=0 mlxscore=0 impostorscore=0 adultscore=0 priorityscore=1501 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503050071 When a system is being suspended to RAM, the PCI devices are also suspended and the PPC code ends up calling pseries_msi_compose_msg() and this triggers the BUG_ON() in __pci_read_msi_msg() because the device at this point is in reduced power state. In reduced power state, the memory mapped registers of the PCI device are not accessible. To replicate the bug: 1. Make sure deep sleep is selected # cat /sys/power/mem_sleep s2idle [deep] 2. Make sure console is not suspended (so that dmesg logs are visible) echo N > /sys/module/printk/parameters/console_suspend 3. Suspend the system echo mem > /sys/power/state To fix this behaviour, read the cached msi message of the device when the device is not in PCI_D0 power state instead of touching the hardware. Fixes: a5f3d2c17b07 ("powerpc/pseries/pci: Add MSI domains") Cc: stable@vger.kernel.org # v5.15+ Signed-off-by: Gautam Menghani --- arch/powerpc/platforms/pseries/msi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/pseries/msi.c b/arch/powerpc/platforms/pseries/msi.c index fdc2f7f38dc9..458d95c8c755 100644 --- a/arch/powerpc/platforms/pseries/msi.c +++ b/arch/powerpc/platforms/pseries/msi.c @@ -525,7 +525,12 @@ static struct msi_domain_info pseries_msi_domain_info = { static void pseries_msi_compose_msg(struct irq_data *data, struct msi_msg *msg) { - __pci_read_msi_msg(irq_data_get_msi_desc(data), msg); + struct pci_dev *dev = msi_desc_to_pci_dev(irq_data_get_msi_desc(data)); + + if (dev->current_state == PCI_D0) + __pci_read_msi_msg(irq_data_get_msi_desc(data), msg); + else + get_cached_msi_msg(data->irq, msg); } static struct irq_chip pseries_msi_irq_chip = { -- 2.47.0