From: Christian Brauner <brauner@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/4] spufs: fix a leak on spufs_new_file() failure
Date: Thu, 13 Mar 2025 09:26:35 +0100 [thread overview]
Message-ID: <20250313-tilgen-fundamental-1b86d4cbc3e1@brauner> (raw)
In-Reply-To: <20250313042815.GA2123707@ZenIV>
On Thu, Mar 13, 2025 at 04:28:15AM +0000, Al Viro wrote:
> It's called from spufs_fill_dir(), and caller of that will do
> spufs_rmdir() in case of failure. That does remove everything
> we'd managed to create, but... the problem dentry is still
> negative. IOW, it needs to be explicitly dropped.
>
> Fixes: 3f51dd91c807 "[PATCH] spufs: fix spufs_fill_dir error path"
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
Reviewed-by: Christian Brauner <brauner@kernel.org>
next prev parent reply other threads:[~2025-03-13 8:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 4:27 [PATCHES] several fixes from tree-in-dcache stuff Al Viro
2025-03-13 4:28 ` [PATCH 1/4] spufs: fix a leak on spufs_new_file() failure Al Viro
2025-03-13 8:26 ` Christian Brauner [this message]
2025-03-13 4:29 ` [PATCH 2/4] spufs: fix gang directory lifetimes Al Viro
2025-03-13 8:28 ` Christian Brauner
2025-03-13 4:29 ` [PATCH 3/4] spufs: fix a leak in spufs_create_context() Al Viro
2025-03-13 8:28 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313-tilgen-fundamental-1b86d4cbc3e1@brauner \
--to=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).