From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC5DBC369D3 for ; Sun, 20 Apr 2025 21:42:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Zghmq0Ph0z3c47; Mon, 21 Apr 2025 07:42:35 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745185354; cv=none; b=g6EqJfBC/FBl6JV2NoNNsMmuRlMoLlQ8IJ1FP8PfZgK3qbavxClUtWiypj4QTT4AX9Z3uBaspMYBek9QB2e1RTdcoSBzOTlt9lwzTI2p3TYiP/otKOAocLdUA7M5ilLfF5uKiCOnspRFIq82Ving3SLlsWAXSqoDNg3ywO9qROHOnMieeGnkokl8lCJIeNbRB9xF5p8n1O3jChmXO/OUejz1VG/PahSn8uQs4SGl2T8cKxAmeHvhaARf8NSyIM1nLn4UJmFzwZ4UtZ47g2ymeIdmPnuaNrvy2vRFvPqlkN07jqeLQFEiHTloN6abo3tY0YCnXw4jgE3RVkoHigVNqA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1745185354; c=relaxed/relaxed; bh=S9zrrDOxME57GBJZTg9k9R5znLyd2GM1hIcVvK4ssio=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nXO+vutofLDfJLzq9aadVdaHrcNiVEYC6Gf5ZdG/bdEoVzXHJrAixAlGpkj6b5NRZY0rJXBLmcYcJezxhUzvzdyYFHwuJ1iAHGd2pkOojy25O7dm/PblnRWGM0eUNKHaO8g+roqirlJVMj1Ptn7GfjK50JuaHb5PGd1fQKNm6IBuYI/MtZk4QZo+bNU8cPVuOXTF2UMFRibWwk9q92awYfAe5jJScSnCyAQdGYxkWEVqiBQVzhx6Pz6lFufhR/r81h1PhizSmArnDzEJUqb55nez5HFH516wH1iwU7K2785ShWJUjCqw+Z8IQ2btwfWhsmiFG1ebQa7IyqAgiSV2IQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=V14kX5gV; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=V14kX5gV; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Zghmp04rCz3bn9 for ; Mon, 21 Apr 2025 07:42:33 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id E51BA61127; Sun, 20 Apr 2025 21:42:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E842BC4CEE2; Sun, 20 Apr 2025 21:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745185348; bh=o3lK09+otg6DgvlTkRd0uEq2A+YS26/sGwIIKbHBcag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V14kX5gVKJQ4TKr1kjqcj4uB/vdwkcoBtAzqAd6oYHr/0UFPi5Xb4XNt2bgobpadx fHLW4TYVRN58fg+nvS5iX8RxLw4WD2uHHLtRHXM8Fdzq0zf/m9Jea3Dw9SN4//RZic ATxeSy8c398InEkzqu0EoYWWLNR9+5n7gOY+jzhg+foAWNabfgvGsLuAiv1wAU1p5q gEJO9Hc83boZUsPd9mdUX74gegIaxXpsyScNdEd5NPpa5d0+pAveQwe+GXHrNRv35O JZfCuQ5QtXX/qaeCAd7eOiMQFvnuGssZ557aDkUuMoDftndQ6sqUI8SdS8WUi74F4v 27V1otuThl43w== Date: Sun, 20 Apr 2025 14:42:26 -0700 From: Eric Biggers To: linux-crypto@vger.kernel.org Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, x86@kernel.org, "Jason A . Donenfeld" , Ard Biesheuvel Subject: Re: [PATCH v2 05/13] crypto: arm - move library functions to arch/arm/lib/crypto/ Message-ID: <20250420214226.GA14633@sol.localdomain> References: <20250420192609.295075-1-ebiggers@kernel.org> <20250420192609.295075-6-ebiggers@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250420192609.295075-6-ebiggers@kernel.org> On Sun, Apr 20, 2025 at 12:26:01PM -0700, Eric Biggers wrote: > diff --git a/arch/arm/lib/crypto/Makefile b/arch/arm/lib/crypto/Makefile > new file mode 100644 > index 0000000000000..dbdf376e25336 > --- /dev/null > +++ b/arch/arm/lib/crypto/Makefile > @@ -0,0 +1,24 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +obj-$(CONFIG_CRYPTO_BLAKE2S_ARM) += libblake2s-arm.o > +libblake2s-arm-y:= blake2s-core.o blake2s-glue.o > + > +obj-$(CONFIG_CRYPTO_CHACHA20_NEON) += chacha-neon.o > +chacha-neon-y := chacha-scalar-core.o chacha-glue.o > +chacha-neon-$(CONFIG_KERNEL_MODE_NEON) += chacha-neon-core.o > + > +obj-$(CONFIG_CRYPTO_POLY1305_ARM) += poly1305-arm.o > +poly1305-arm-y := poly1305-core.o poly1305-glue.o > + > +quiet_cmd_perl = PERL $@ > + cmd_perl = $(PERL) $(<) > $(@) > + > +$(obj)/%-core.S: $(src)/%-armv4.pl > + $(call cmd,perl) > + > +clean-files += poly1305-core.S > + > +# massage the perlasm code a bit so we only get the NEON routine if we need it > +poly1305-aflags-$(CONFIG_CPU_V7) := -U__LINUX_ARM_ARCH__ -D__LINUX_ARM_ARCH__=5 > +poly1305-aflags-$(CONFIG_KERNEL_MODE_NEON) := -U__LINUX_ARM_ARCH__ -D__LINUX_ARM_ARCH__=7 > +AFLAGS_poly1305-core.o += $(poly1305-aflags-y) $(aflags-thumb2-y) As noticed by kernel test robot (https://lore.kernel.org/oe-kbuild-all/202504210545.llc4JaKQ-lkp@intel.com), I forgot to include the following line here: aflags-thumb2-$(CONFIG_THUMB2_KERNEL) := -U__thumb2__ -D__thumb2__=1