* [PATCH] powerpc: Replace strcpy() with strscpy() in proc_ppc64_init()
@ 2025-04-21 18:31 Thorsten Blum
2025-05-18 3:45 ` Madhavan Srinivasan
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-04-21 18:31 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Naveen N Rao, Thomas Gleixner,
Thomas Weißschuh
Cc: Thorsten Blum, linux-hardening, linuxppc-dev, linux-kernel
strcpy() is deprecated; use strscpy() instead.
Don't cast the destination buffer from 'u8[]' to 'char *' to satisfy the
__must_be_array() requirement of strscpy().
No functional changes intended.
Link: https://github.com/KSPP/linux/issues/88
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/powerpc/kernel/proc_powerpc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/proc_powerpc.c b/arch/powerpc/kernel/proc_powerpc.c
index 3816a2bf2b84..d083b4517065 100644
--- a/arch/powerpc/kernel/proc_powerpc.c
+++ b/arch/powerpc/kernel/proc_powerpc.c
@@ -9,6 +9,7 @@
#include <linux/proc_fs.h>
#include <linux/kernel.h>
#include <linux/of.h>
+#include <linux/string.h>
#include <asm/machdep.h>
#include <asm/vdso_datapage.h>
@@ -56,7 +57,7 @@ static int __init proc_ppc64_init(void)
{
struct proc_dir_entry *pde;
- strcpy((char *)systemcfg->eye_catcher, "SYSTEMCFG:PPC64");
+ strscpy(systemcfg->eye_catcher, "SYSTEMCFG:PPC64");
systemcfg->version.major = SYSTEMCFG_MAJOR;
systemcfg->version.minor = SYSTEMCFG_MINOR;
systemcfg->processor = mfspr(SPRN_PVR);
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] powerpc: Replace strcpy() with strscpy() in proc_ppc64_init()
2025-04-21 18:31 [PATCH] powerpc: Replace strcpy() with strscpy() in proc_ppc64_init() Thorsten Blum
@ 2025-05-18 3:45 ` Madhavan Srinivasan
0 siblings, 0 replies; 2+ messages in thread
From: Madhavan Srinivasan @ 2025-05-18 3:45 UTC (permalink / raw)
To: Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N Rao,
Thomas Gleixner, Thomas Weißschuh, Thorsten Blum
Cc: linux-hardening, linuxppc-dev, linux-kernel
On Mon, 21 Apr 2025 20:31:08 +0200, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
>
> Don't cast the destination buffer from 'u8[]' to 'char *' to satisfy the
> __must_be_array() requirement of strscpy().
>
> No functional changes intended.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc: Replace strcpy() with strscpy() in proc_ppc64_init()
https://git.kernel.org/powerpc/c/7e99a4a60d8fc9b24a3f9632011bf7e197f1aff9
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-18 4:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-21 18:31 [PATCH] powerpc: Replace strcpy() with strscpy() in proc_ppc64_init() Thorsten Blum
2025-05-18 3:45 ` Madhavan Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).