linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.ibm.com>
To: mpe@ellerman.id.au, christophe.leroy@csgroup.eu
Cc: npiggin@gmail.com, naveen@kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	Madhavan Srinivasan <maddy@linux.ibm.com>
Subject: [PATCH 4/6] powerpc: fix sparse warnings
Date: Tue, 22 Apr 2025 18:40:38 +0530	[thread overview]
Message-ID: <20250422131040.374427-5-maddy@linux.ibm.com> (raw)
In-Reply-To: <20250422131040.374427-1-maddy@linux.ibm.com>

structs are local to the source and does not need to
be in global scope, so make it static.

Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
---
 arch/powerpc/kernel/btext.c              | 2 +-
 arch/powerpc/kernel/setup-common.c       | 2 +-
 arch/powerpc/platforms/powernv/opal.c    | 2 +-
 arch/powerpc/platforms/pseries/lparcfg.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c
index 7f63f1cdc6c3..fc7f5a5b6d76 100644
--- a/arch/powerpc/kernel/btext.c
+++ b/arch/powerpc/kernel/btext.c
@@ -40,7 +40,7 @@ static int dispDeviceRect[4] __force_data;
 static unsigned char *dispDeviceBase __force_data;
 static unsigned char *logicalDisplayBase __force_data;
 
-unsigned long disp_BAT[2] __initdata = {0, 0};
+static unsigned long disp_BAT[2] __initdata = {0, 0};
 
 static int boot_text_mapped __force_data;
 
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 68d47c53876c..649e0cc31df7 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -350,7 +350,7 @@ static void c_stop(struct seq_file *m, void *v)
 {
 }
 
-const struct seq_operations cpuinfo_op = {
+static const struct seq_operations cpuinfo_op = {
 	.start	= c_start,
 	.next	= c_next,
 	.stop	= c_stop,
diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index 9ec265fcaff4..02af50a724bf 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -48,7 +48,7 @@ static LIST_HEAD(msg_list);
 /* /sys/firmware/opal */
 struct kobject *opal_kobj;
 
-struct opal {
+static struct opal {
 	u64 base;
 	u64 entry;
 	u64 size;
diff --git a/arch/powerpc/platforms/pseries/lparcfg.c b/arch/powerpc/platforms/pseries/lparcfg.c
index cc22924f159f..830af843ef40 100644
--- a/arch/powerpc/platforms/pseries/lparcfg.c
+++ b/arch/powerpc/platforms/pseries/lparcfg.c
@@ -185,7 +185,7 @@ static long h_pic(unsigned long *pool_idle_time,
 	return rc;
 }
 
-unsigned long boot_pool_idle_time;
+static unsigned long boot_pool_idle_time;
 
 /*
  * parse_ppp_data
-- 
2.49.0



  parent reply	other threads:[~2025-04-22 13:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22 13:10 [PATCH 0/6] Fixes for shellcheck/sparse warnings Madhavan Srinivasan
2025-04-22 13:10 ` [PATCH 1/6] powerpc/kvm: Fix sparse warning Madhavan Srinivasan
2025-04-22 13:10 ` [PATCH 2/6] powerpc/xmon: fix sparse warning "Using plain integer as NULL pointer" Madhavan Srinivasan
2025-05-02 10:08   ` Christophe Leroy
2025-05-18  3:51     ` Madhavan Srinivasan
2025-04-22 13:10 ` [PATCH 3/6] powerpc/perf:make isa207_pmu_format_group struct static Madhavan Srinivasan
2025-05-07 11:52   ` kernel test robot
2025-04-22 13:10 ` Madhavan Srinivasan [this message]
2025-05-02 10:16   ` [PATCH 4/6] powerpc: fix sparse warnings Christophe Leroy
2025-05-18  3:54     ` Madhavan Srinivasan
2025-05-07 11:11   ` kernel test robot
2025-04-22 13:10 ` [PATCH 5/6] powerpc/prom_init: Fix shellcheck warnings Madhavan Srinivasan
2025-04-22 13:42   ` Stephen Rothwell
2025-04-22 13:10 ` [PATCH 6/6] powerpc/boot/install.sh: " Madhavan Srinivasan
2025-04-22 13:46   ` Stephen Rothwell
2025-04-23  8:44 ` [PATCH 0/6] Fixes for shellcheck/sparse warnings Venkat Rao Bagalkote

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250422131040.374427-5-maddy@linux.ibm.com \
    --to=maddy@linux.ibm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=naveen@kernel.org \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).