From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: mpe@ellerman.id.au, christophe.leroy@csgroup.eu,
npiggin@gmail.com, naveen@kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 6/6] powerpc/boot/install.sh: Fix shellcheck warnings
Date: Tue, 22 Apr 2025 23:46:49 +1000 [thread overview]
Message-ID: <20250422234649.1313cb3b@canb.auug.org.au> (raw)
In-Reply-To: <20250422131040.374427-7-maddy@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
Hi Madhavan,
On Tue, 22 Apr 2025 18:40:40 +0530 Madhavan Srinivasan <maddy@linux.ibm.com> wrote:
>
> -if [ -f $4/$image_name-$1 ]; then
> - mv $4/$image_name-$1 $4/$image_name-$1.old
> +if [ -f "$4"/"$image_name"-"$1" ]; then
> + mv "$4"/"$image_name"-"$1" "$4"/"$image_name"-"$1".old
"$4/$image_name-$1" is just as correct (and similar elsewhere).
> fi
>
> -if [ -f $4/System.map-$1 ]; then
> - mv $4/System.map-$1 $4/System-$1.old
> +if [ -f "$4"/System.map-"$1" ]; then
> + mv "$4"/System.map-"$1" "$4"/System-"$1".old
> fi
>
> -cat $2 > $4/$image_name-$1
> -cp $3 $4/System.map-$1
> +cat "$2" > "$4"/"$image_name"-"$1"
> +cp "$3" "$4"/System.map-"$1"
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-04-22 13:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 13:10 [PATCH 0/6] Fixes for shellcheck/sparse warnings Madhavan Srinivasan
2025-04-22 13:10 ` [PATCH 1/6] powerpc/kvm: Fix sparse warning Madhavan Srinivasan
2025-04-22 13:10 ` [PATCH 2/6] powerpc/xmon: fix sparse warning "Using plain integer as NULL pointer" Madhavan Srinivasan
2025-05-02 10:08 ` Christophe Leroy
2025-05-18 3:51 ` Madhavan Srinivasan
2025-04-22 13:10 ` [PATCH 3/6] powerpc/perf:make isa207_pmu_format_group struct static Madhavan Srinivasan
2025-05-07 11:52 ` kernel test robot
2025-04-22 13:10 ` [PATCH 4/6] powerpc: fix sparse warnings Madhavan Srinivasan
2025-05-02 10:16 ` Christophe Leroy
2025-05-18 3:54 ` Madhavan Srinivasan
2025-05-07 11:11 ` kernel test robot
2025-04-22 13:10 ` [PATCH 5/6] powerpc/prom_init: Fix shellcheck warnings Madhavan Srinivasan
2025-04-22 13:42 ` Stephen Rothwell
2025-04-22 13:10 ` [PATCH 6/6] powerpc/boot/install.sh: " Madhavan Srinivasan
2025-04-22 13:46 ` Stephen Rothwell [this message]
2025-04-23 8:44 ` [PATCH 0/6] Fixes for shellcheck/sparse warnings Venkat Rao Bagalkote
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422234649.1313cb3b@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).