From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: npiggin@gmail.com, vaibhav@linux.ibm.com, maddy@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org, christophe.leroy@csgroup.eu,
gautam@linux.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc: kvm: use generic transfer to guest mode work
Date: Fri, 25 Apr 2025 18:23:31 +0200 [thread overview]
Message-ID: <20250425162331.qwpzuc-8@linutronix.de> (raw)
In-Reply-To: <5cc88718-13ff-4220-a8f6-c988a919aa65@linux.ibm.com>
On 2025-04-25 19:54:56 [+0530], Shrikanth Hegde wrote:
> > > But looking at the semantics of usage of xfer_to_guest_mode_work
> > > I think using schedule is probably right over here.
> > > Correct me if i got it all wrong.
> >
> > No, if you do xfer_to_guest_mode_work() then it will invoke schedule()
> > when appropriate. It just the thing in kvmhv_run_single_vcpu() looks odd
> > and might have been duct tape or an accident and could probably be
> > removed.
> >
>
> I was wondering xfer_to_guest_mode_work could also call cond_resched
> instead of schedule since for preempt=full/lazy is preemptible
> as early as possible right?
No, I think it is okay. For preempt=full you shouldn't observe the
flag in xfer_to_guest_mode_work() so it does not matter.
Sebastian
next prev parent reply other threads:[~2025-04-25 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 10:28 [PATCH 0/2] powerpc: kvm: generic framework and run posix timers in task context Shrikanth Hegde
2025-04-21 10:28 ` [PATCH 1/2] powerpc: kvm: use generic transfer to guest mode work Shrikanth Hegde
2025-04-24 14:42 ` Sebastian Andrzej Siewior
2025-04-24 15:57 ` Shrikanth Hegde
2025-04-24 18:38 ` Sebastian Andrzej Siewior
2025-04-25 11:19 ` Shrikanth Hegde
2025-04-25 13:31 ` Sebastian Andrzej Siewior
2025-04-25 14:24 ` Shrikanth Hegde
2025-04-25 16:23 ` Sebastian Andrzej Siewior [this message]
2025-04-29 6:19 ` Shrikanth Hegde
2025-04-21 10:28 ` [PATCH 2/2] powerpc: enable to run posix cpu timers in task context Shrikanth Hegde
2025-04-21 12:34 ` [PATCH 0/2] powerpc: kvm: generic framework and run posix " Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425162331.qwpzuc-8@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=christophe.leroy@csgroup.eu \
--cc=gautam@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=sshegde@linux.ibm.com \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).