From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Wei Fang <wei.fang@nxp.com>
Cc: claudiu.manoil@nxp.com, xiaoning.wang@nxp.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, christophe.leroy@csgroup.eu,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 net-next 00/14] Add more features for ENETC v4 - round 2
Date: Mon, 28 Apr 2025 19:16:44 +0300 [thread overview]
Message-ID: <20250428161644.ygf3bg6pyyfftccn@skbuf> (raw)
In-Reply-To: <20250428105657.3283130-1-wei.fang@nxp.com>
Hi Wei,
On Mon, Apr 28, 2025 at 06:56:43PM +0800, Wei Fang wrote:
> This patch set adds the following features.
> 1. Compared with ENETC v1, the formats of tables and command BD of ENETC
> v4 have changed significantly, and the two are not compatible. Therefore,
> in order to support the NETC Table Management Protocol (NTMP) v2.0, we
> introduced the netc-lib driver and added support for MAC address filter
> table and RSS table.
> 2. Add MAC filter and VLAN filter support for i.MX95 ENETC PF.
> 3. Add RSS support for i.MX95 ENETC PF.
> 4. Add loopback support for i.MX95 ENETC PF.
I don't see any functional issues with this set. I am also not sure
whether MAC address filtering is implemented in the simplest way, but I
suppose it can also be simplified over time.
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
prev parent reply other threads:[~2025-04-28 16:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 10:56 [PATCH v6 net-next 00/14] Add more features for ENETC v4 - round 2 Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 01/14] net: enetc: add initial netc-lib driver to support NTMP Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 02/14] net: enetc: add command BD ring support for i.MX95 ENETC Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 03/14] net: enetc: move generic MAC filtering interfaces to enetc-core Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 04/14] net: enetc: add MAC filtering for i.MX95 ENETC PF Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 05/14] net: enetc: add debugfs interface to dump MAC filter Wei Fang
2025-04-29 16:53 ` Timur Tabi
2025-04-30 1:36 ` Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 06/14] net: enetc: add set/get_rss_table() hooks to enetc_si_ops Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 07/14] net: enetc: make enetc_set_rss_key() reusable Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 08/14] net: enetc: add RSS support for i.MX95 ENETC PF Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 09/14] net: enetc: change enetc_set_rss() to void type Wei Fang
2025-04-28 16:14 ` Vladimir Oltean
2025-04-28 10:56 ` [PATCH v6 net-next 10/14] net: enetc: enable RSS feature by default Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 11/14] net: enetc: extract enetc_refresh_vlan_ht_filter() Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 12/14] net: enetc: move generic VLAN hash filter functions to enetc_pf_common.c Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 13/14] net: enetc: add VLAN filtering support for i.MX95 ENETC PF Wei Fang
2025-04-28 10:56 ` [PATCH v6 net-next 14/14] net: enetc: add loopback " Wei Fang
2025-04-28 16:16 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428161644.ygf3bg6pyyfftccn@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).