From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62A88C3ABBF for ; Wed, 7 May 2025 16:45:25 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Zt1N40S1Mz30MZ; Thu, 8 May 2025 02:45:24 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=95.215.58.174 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1746636324; cv=none; b=HICBO/Z0ODQivzsx1bWd+hPmBA2iwLtPwZ41Psjvtqj/Gc3rawCWmyMugzTAPkr8j0CwqOkrXNI8237doYBQ4j32iOn2l92CCok7yDvYBShBUWh9BHPxQbZHcwZ35CM96JbektUu50TU48HawOQyq7U9vzRYeM6Q0tH6Bn0HXScBLVMaAlNVRSAZficL//+MUmbp6TRs7izUHEDtCnY8kFeoKAqTPwVqeosORJ0O42XJUHhNNfQO9GDDU59yIKVs0Jg5PdHAzTXCstMQftJIbaGkJSMafIQ17wsedNAm6JIJ0nbHDQKEm8oLPcJnLqx+vw+Y20HJaB61R1RzCkgwnw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1746636324; c=relaxed/relaxed; bh=l9xZ23DhdLI0tbSuD9vBHZtbbRiWB81u/rHKaK7rVJo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JCVce0xFFtOQp9MYLtmS/PMNjSQXacYqVsRkJ/DYl9MShcd95pKORBYWPTUaiIV7ZY0jb5HKZLQA/ZCltM0zoXMmI31wlXGacFT0vNvIQfWAX0rXhM2GbTJsX2zp7WjPmsLEyUkJZiCBr9Bdr2xhPvG56VwhyZReTVMKXYEnvThWT6JtJW2sztArWcNKEhQHJLsK6Din4yp+Hf4Iv6AdIN+9GMpxyrkjg4G4GHkQWWV6FcHkHASSpAx4/t8SDft/SR+ylfKkb4OH3GWdAiHp+kCTdq3qMl94juR+WpzCG3NpE8fg4P4RaKdtoXv4Qd+1WoMUq6HWqLVTwU41rcZtAg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.dev; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=ppfvQ4wR; dkim-atps=neutral; spf=pass (client-ip=95.215.58.174; helo=out-174.mta1.migadu.com; envelope-from=andrew.jones@linux.dev; receiver=lists.ozlabs.org) smtp.mailfrom=linux.dev Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=ppfvQ4wR; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.dev (client-ip=95.215.58.174; helo=out-174.mta1.migadu.com; envelope-from=andrew.jones@linux.dev; receiver=lists.ozlabs.org) Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Zt1N304lnz30DP for ; Thu, 8 May 2025 02:45:22 +1000 (AEST) Date: Wed, 7 May 2025 18:45:00 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1746636304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l9xZ23DhdLI0tbSuD9vBHZtbbRiWB81u/rHKaK7rVJo=; b=ppfvQ4wRMLDsUxyr+O0llP8JyXWNDUSciVcC0yPy+dqT/scr0F4U50Zn7zq8E/n9V0XxXq Ztb8arjgyvckv2/XO/3fF703zzQV3e8Kbpi480DoyCpGhLDg7laYTqjvJaN5X2bvEWOc2C 7cr2CDvyLf5ltGMDtZJLQCjWCthSg54= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Alexandru Elisei Cc: eric.auger@redhat.com, lvivier@redhat.com, thuth@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, nrb@linux.ibm.com, david@redhat.com, pbonzini@redhat.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org, will@kernel.org, julien.thierry.kdev@gmail.com, maz@kernel.org, oliver.upton@linux.dev, suzuki.poulose@arm.com, yuzenghui@huawei.com, joey.gouly@arm.com, andre.przywara@arm.com Subject: Re: [kvm-unit-tests PATCH v3 11/16] scripts: Add KVMTOOL environment variable for kvmtool binary path Message-ID: <20250507-1ad6b4b9396d8da573c960f2@orel> References: <20250507151256.167769-1-alexandru.elisei@arm.com> <20250507151256.167769-12-alexandru.elisei@arm.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250507151256.167769-12-alexandru.elisei@arm.com> X-Migadu-Flow: FLOW_OUT On Wed, May 07, 2025 at 04:12:51PM +0100, Alexandru Elisei wrote: > kvmtool is often used for prototyping new features, and a developer might > not want to install it system-wide. Add a KVMTOOL environment variable to > make it easier for tests to use a binary not in $PATH. > > Signed-off-by: Alexandru Elisei > --- > run_tests.sh | 1 + > scripts/arch-run.bash | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/run_tests.sh b/run_tests.sh > index dd9d27377905..150a06a91064 100755 > --- a/run_tests.sh > +++ b/run_tests.sh > @@ -36,6 +36,7 @@ The following environment variables are used: > TIMEOUT Timeout duration for the timeout(1) command > CHECK Overwrites the 'check' unit test parameter (see > docs/unittests.txt) > + KVMTOOL Path to kvmtool binary for ARCH-run > EOF > } > > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index 8cf67e4f3b51..d4fc7116abbe 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -372,7 +372,7 @@ search_kvmtool_binary () > { > local kvmtoolcmd kvmtool > > - for kvmtoolcmd in lkvm vm lkvm-static; do > + for kvmtoolcmd in ${KVMTOOL:-lkvm vm lkvm-static}; do > if "$kvmtoolcmd" --help 2>/dev/null| grep -q 'The most commonly used'; then > kvmtool="$kvmtoolcmd" > break > @@ -381,6 +381,7 @@ search_kvmtool_binary () > > if [ -z "$kvmtool" ]; then > echo "A kvmtool binary was not found." >&2 > + echo "You can set a custom location by using the KVMTOOL= environment variable." >&2 > return 2 > fi > > -- > 2.49.0 > Reviewed-by: Andrew Jones