From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4611C3ABDD for ; Tue, 20 May 2025 14:27:12 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4b1xhb3cV4z3bfR; Wed, 21 May 2025 00:27:11 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1747751231; cv=none; b=eF7+WnSYHhEMDcnDaXPvk9c+FN2+h7TFsik/iTsFGE495BvaL/pCciIGO1cfblfFZAg/hEU1/j28dU7A9/TTph2PQIAG6/HsPGWwy4uf98iaeu9Ec4Yx4z3Ccl4suG83Xq1fbDFl0o1NxXbo/mC+pMD/vagnSe8vP4HO6KkPcWeDTUXFLUsRJlkI1CwF5OWeg9LeXh8pE5fN38SstzKTdjmsUarTGey580NzAspJxc5ih50OPIJzDqus1rLEcBDnsdn149WMjTypAwKhShn1xsMsZ6xx9KpOXyhgLoKEAzNzPB0+15kQX2HluGRbLzu3EvUQo0usSpy7mBPSG7y2vQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1747751231; c=relaxed/relaxed; bh=0mj9Wkj0uufvJrsbQ9t+aAPCbH7zPacQwdZCk57M6dE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=LKiIEUZwb+vqwsepg64zY304FZj0TtVbR+Y3w7pdH1WsdTnF/jPZbzviX1WlExWdMRmwV103PP489HED9wS9P28gMNkT+SLDNxsDKzSw5o3B51lFe1BPAKmC8v9QdX0cYND6cJef+l8sOlJdnv0wJYeiqi+LHvRL0BK0/uoiBiM4+/QFWJSd87aqfwBSvdmrb6B9r541ULq8B2JOs5QY3nlR3RR4q5hKqKIX5DoiAoNFRqGAKvmiRPvKCfZjtfuJCPzT8UDD/t6Y+eibc22vyJu8WYPIzH07aVDSTWYCAnBydy8iz7weYQF++DCyI7bVes7y2fJzE0+/193PZJx1jA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=KRrcIo3O; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=KRrcIo3O; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4b1xhZ6Cwkz3055 for ; Wed, 21 May 2025 00:27:10 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 1BC484A66A; Tue, 20 May 2025 14:27:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7789C4CEE9; Tue, 20 May 2025 14:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747751229; bh=oCLBYeP1sLVu5Ws29+9UfDbRGJI3ciUnpG/nTA1olYM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=KRrcIo3ONGaX7Pi2FUjzUMa9ejaXw+b9Vm9fA9E3drThkSwBDBErRwftIqGCKAhYl bgvtywYaGpxfZmkvw1WGrNyTx5+9cqmvDol7+KmjgP6gYZ5Y0jtXzaDt+lj0PjVRLq EhGYy0wxjqBs2GooRe6qM+uu2Y0X+5SJGczXyS0LIOv6RpJ1MOJE0XmDdR0XDCrx6T gmlU+1+zpu6h4u32w077LBi3dm342l6zDXzZQC9Zkr0gnH5zeDii9wXcwdbBZ/cB/p JGV7/hDyqx5nG9Yg+Os07MjY52JZ6Hk85v7bL3fQXtVc5++fHv7e9lly/iSdoAgJK4 YkIlmYSK7kkHg== Date: Tue, 20 May 2025 09:27:07 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Jon Pan-Doh , Karolina Stolarek , Martin Petersen , Ben Fuller , Drew Walton , Anil Agrawal , Tony Luck , Sathyanarayanan Kuppuswamy , Lukas Wunner , Jonathan Cameron , Sargun Dhillon , "Paul E . McKenney" , Mahesh J Salgaonkar , Oliver O'Halloran , Kai-Heng Feng , Keith Busch , Robert Richter , Terry Bowman , Shiju Jose , Dave Jiang , LKML , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas Subject: Re: [PATCH v6 07/16] PCI/AER: Initialize aer_err_info before using it Message-ID: <20250520142707.GA1297901@bhelgaas> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0d429918-b42c-5714-ef40-ce2a9e129a6b@linux.intel.com> On Tue, May 20, 2025 at 01:39:06PM +0300, Ilpo Järvinen wrote: > On Mon, 19 May 2025, Bjorn Helgaas wrote: > > > From: Bjorn Helgaas > > > > Previously the struct aer_err_info "e_info" was allocated on the stack > > without being initialized, so it contained junk except for the fields we > > explicitly set later. > > > > Initialize "e_info" at declaration with a designated initializer list, > > which initializes the other members to zero. > > > > Signed-off-by: Bjorn Helgaas > > --- > > drivers/pci/pcie/aer.c | 37 ++++++++++++++++--------------------- > > 1 file changed, 16 insertions(+), 21 deletions(-) > > > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > > index 95a4cab1d517..40f003eca1c5 100644 > > --- a/drivers/pci/pcie/aer.c > > +++ b/drivers/pci/pcie/aer.c > > @@ -1281,7 +1281,7 @@ static void aer_isr_one_error(struct aer_rpc *rpc, > > struct aer_err_source *e_src) > > Unrelated to this change, these would fit on a single line. Thanks, fixed!