From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BF57C54E65 for ; Wed, 21 May 2025 09:22:00 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4b2Qsy5lWTz3byk; Wed, 21 May 2025 19:21:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=185.176.79.56 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1747819318; cv=none; b=TuOyh7SbO5B528HT0/Ra4iO4t4h1QoPWo4vAo2oSylsrf8bRVNZ2zEyjeTmLwRnoqiggvQYG2xyF0K48ZGgcldoMY0lWeOXr0LvZ/ujHnKHZWWESGH7KRo6mBcF2yUdcrRuBcxLCFO+bUFbL2zDfBPy7SAYrYmVTOszHPrKP0tYRyauFQc70Fksz7lrgjPIhp4EPrLEIvConRNvCIh+HJY6vIxvNLIt2odSMTcJp0W77RSX9AEn6LtNq3aDmJfV4JO3ToZrjIGOOwZC7FSgjPrA8HrxY8TiMrh/f+Ane2DMY05hSZERmK2uoX/5XOAOQshoKqYc9xXqvhfmA6PH3UQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1747819318; c=relaxed/relaxed; bh=73Kq21yMVV0v+6hb63YWd7m81AMz/a1D08jv72jHGcM=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Rn9x8WX7Nud59Bgl9cYZJdzPT289B088zGzF1a2mvSvNocyhKOhCEvkUpoV7f+73em02CZUV+7tIPWAWSQ9iumGijNgShe499H2atoCxl/TuyniPnY+nZJ14RsJadXad7qmpTmvdBhWm2uVZN5wIuI8316BBsFBsFaxdY8Spe/Rq44KKFBbj3VDj2sDoCmDwWn/ZTR5sbwrm+abrfAMjm/TYDEzqKudRmxLOJ74o91l9mcHhIXyrfamNCsGThYMZEFbB0UCGV8gtQKJLkMf3ovT5vYFVOUKYOI9vwHTmZZJgyUkpmS/pJez3Raic/1PTPBaeBdzGq/C2TjxNSeSAZw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass (client-ip=185.176.79.56; helo=frasgout.his.huawei.com; envelope-from=jonathan.cameron@huawei.com; receiver=lists.ozlabs.org) smtp.mailfrom=huawei.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=185.176.79.56; helo=frasgout.his.huawei.com; envelope-from=jonathan.cameron@huawei.com; receiver=lists.ozlabs.org) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4b2Qsy0z0yz3bwR for ; Wed, 21 May 2025 19:21:58 +1000 (AEST) Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4b2QpD1LGkz6L4rt; Wed, 21 May 2025 17:18:44 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 17A841402C3; Wed, 21 May 2025 17:21:55 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 21 May 2025 11:21:54 +0200 Date: Wed, 21 May 2025 10:21:52 +0100 From: Jonathan Cameron To: Bjorn Helgaas CC: , Jon Pan-Doh , "Karolina Stolarek" , Weinan Liu , Martin Petersen , Ben Fuller , Drew Walton , "Anil Agrawal" , Tony Luck , Ilpo =?UTF-8?Q?J=C3=A4rvinen?= , "Sathyanarayanan Kuppuswamy" , Lukas Wunner , Sargun Dhillon , "Paul E . McKenney" , Mahesh J Salgaonkar , "Oliver O'Halloran" , Kai-Heng Feng , "Keith Busch" , Robert Richter , Terry Bowman , Shiju Jose , Dave Jiang , , , Bjorn Helgaas , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= Subject: Re: [PATCH v7 05/17] PCI/AER: Extract bus/dev/fn in aer_print_port_info() with PCI_BUS_NUM(), etc Message-ID: <20250521102152.0000569c@huawei.com> In-Reply-To: <20250520215047.1350603-6-helgaas@kernel.org> References: <20250520215047.1350603-1-helgaas@kernel.org> <20250520215047.1350603-6-helgaas@kernel.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To frapeml500008.china.huawei.com (7.182.85.71) On Tue, 20 May 2025 16:50:22 -0500 Bjorn Helgaas wrote: > From: Bjorn Helgaas >=20 > Use PCI_BUS_NUM(), PCI_SLOT(), PCI_FUNC() to extract the bus number, > device, and function number directly from the Error Source ID. There's no > need to shift and mask it explicitly. >=20 > Signed-off-by: Bjorn Helgaas > Tested-by: Krzysztof Wilczy=C5=84ski > Reviewed-by: Kuppuswamy Sathyanarayanan > Reviewed-by: Ilpo J=C3=A4rvinen Reviewed-by: Jonathan Cameron