From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C63F9C54ED1 for ; Thu, 22 May 2025 23:25:03 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4b3PW66lSQz3cCt; Fri, 23 May 2025 09:24:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c0a:e001:78e:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1747956242; cv=none; b=lctFjUl35SCpbptgKXV7f7tpvRpi9z0c+/Kg0AbAwVQik3IGm3/2yBonKHFrKXhzebFJDQK+1ex47zRxWZl1hnaKcDK/DzZDNB5zKvGUdmoVBR6elD7xWAa+ES2rlOH7HDLAdeb1bJMyEvP4iOPJmLloGhVM6qvIZVyJzgvKrCuzHm0h4EaaDWmtdtZPGlpXkOtaFh0ji/U/5SkPXah0HJDl4Gj+PD+0VGjTTBJ6ChWp36gYEoeIGAjBexlA1injqiu7AQPWHvCHdSlBY+T3kYCjJ+IUf6YHcwLqr5MP8cEHe22QLkgDsFLrh4MoX2XjbHFZXekqrNVUPb6TodIgpw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1747956242; c=relaxed/relaxed; bh=gW/xwch4N3IRS6Z0GMKV3nQezdBb0my764/4XUg7zMg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NtMdTDQtNP2koCWXEdxyQXAwf24PMg5FWqOfcSa/M5vshTwcZi3/spiY+Rn8BlR+NCc2y5l9B3Psxln63y2vTBY8QLtwMgWSc1ybCpVdq9nBx/C+dSY6gubR8R9aXXliUURTXH9HP4mMeCAqxLUOW6o4GOfzA3sDVb+EcqNbEVrPr+9DV5b0VrBnjY9XZw5yuTlN2TRlor/ajZlb53RTdveigXYb1MYWb4xTJImHP/Qo6Kmfu4jeuVMqjmROfnh9k4cs/o9nb3pcXCbrRLjUK2egWvd17oVs+nveXb/BiIaFN63V7FhXtpqJBfulabuy0xHY42kUr980IObnPo1/vA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=KFx8zZ9g; dkim-atps=neutral; spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=KFx8zZ9g; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4b3PW62SpHz3cFN for ; Fri, 23 May 2025 09:24:02 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C604145060; Thu, 22 May 2025 23:24:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7012AC4CEE4; Thu, 22 May 2025 23:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747956240; bh=vMqIejXWrlK9YxYbwyOyBG/YD596/rgWjQHdO+zCV/U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KFx8zZ9gtzz+M+TQIukhFM31oXy1KvmvxRKSfpeVN+zdenOX4OlIJ4FGPbr0pOebp qkSbyvWrkkq9j/w6e+Qh/BR08bJnyTX1XtdLSB5HXXffRqqMvSIxUDzFy4XFKx1Xi2 OCvRmNktga4eU8xbxTlChXAB9T/8J5OLOY/SR1BvkJN5Cz1FYzTg0vaRAfATp+RKnI wsh2ubsFLsue9r4++yf80kyMlXgkRKJ80CGbwoMACHcssxDh8nP5eDeFxCYExlX6Va m0v5RUX0j8fHN8bSkOq9Y5jKLCAoTGFL7Ed1gRn6jHs4qDHemLEWg2jUEmbHH7Id+R SaPaWumEZxKBw== From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Jon Pan-Doh , Karolina Stolarek , Weinan Liu , Martin Petersen , Ben Fuller , Drew Walton , Anil Agrawal , Tony Luck , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sathyanarayanan Kuppuswamy , Lukas Wunner , Jonathan Cameron , Sargun Dhillon , "Paul E . McKenney" , Mahesh J Salgaonkar , Oliver O'Halloran , Kai-Heng Feng , Keith Busch , Robert Richter , Terry Bowman , Shiju Jose , Dave Jiang , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= Subject: [PATCH v8 10/20] PCI/AER: Update statistics before ratelimiting Date: Thu, 22 May 2025 18:21:16 -0500 Message-ID: <20250522232339.1525671-11-helgaas@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250522232339.1525671-1-helgaas@kernel.org> References: <20250522232339.1525671-1-helgaas@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Bjorn Helgaas There are two AER logging entry points: - aer_print_error() is used by DPC (dpc_process_error()) and native AER handling (aer_process_err_devices()). - pci_print_aer() is used by GHES (aer_recover_work_func()) and CXL (cxl_handle_rdport_errors()) Both use __aer_print_error() to print the AER error bits. Previously __aer_print_error() also incremented the AER statistics via pci_dev_aer_stats_incr(). Call pci_dev_aer_stats_incr() early in the entry points instead of in __aer_print_error() so we update the statistics even if the actual printing of error bits is rate limited by a future change. Signed-off-by: Bjorn Helgaas Tested-by: Krzysztof Wilczyński Reviewed-by: Ilpo Järvinen Reviewed-by: Kuppuswamy Sathyanarayanan Reviewed-by: Jonathan Cameron Link: https://patch.msgid.link/20250520215047.1350603-11-helgaas@kernel.org --- drivers/pci/pcie/aer.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index dc5f4bebd613..53f460bb7e6c 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -693,7 +693,6 @@ static void __aer_print_error(struct pci_dev *dev, aer_printk(level, dev, " [%2d] %-22s%s\n", i, errmsg, info->first_error == i ? " (First)" : ""); } - pci_dev_aer_stats_incr(dev, info); } static void aer_print_source(struct pci_dev *dev, struct aer_err_info *info, @@ -715,6 +714,8 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) int id = pci_dev_id(dev); const char *level; + pci_dev_aer_stats_incr(dev, info); + if (!info->status) { pci_err(dev, "PCIe Bus Error: severity=%s, type=Inaccessible, (Unregistered Agent ID)\n", aer_error_severity_string[info->severity]); @@ -783,6 +784,8 @@ void pci_print_aer(struct pci_dev *dev, int aer_severity, info.status = status; info.mask = mask; + pci_dev_aer_stats_incr(dev, &info); + layer = AER_GET_LAYER_ERROR(aer_severity, status); agent = AER_GET_AGENT(aer_severity, status); -- 2.43.0