From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B220C54E65 for ; Thu, 22 May 2025 23:25:10 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4b3PW92B8Rz3cG8; Fri, 23 May 2025 09:24:05 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2604:1380:45d1:ec00::3" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1747956245; cv=none; b=Y9xQTdG/zx75gASOkI8ngZCCr9goAUwBE9NPsJggtpoHGbhwJ7qmhlM1ILQ/Qveb7xeVNWfLkj/l/zRDzOQsh06nRg/5sThfUVp7prHrLmj0IcrcLB5/gCyWWqKJZhujFK1XB0v/KCEBixs4t+w8cas6skWqEY3ih39TiKqStiW0iyOtUiuf1LB/qej+MMWZGmBMF9LC12FxIyrqdafwxUiM6S3cCVdaT0ZHNxb51TX+qCTIQJvnOW6LXH2R9mNVjGEQNYLOCqppudz7Mnjh0V8gKmpmA/vH1Kc3vdkV6kH8eZusuZnEo7RMkzfRbvhaEGKH8vZzhPMKG46xLdLGHg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1747956245; c=relaxed/relaxed; bh=e19Tus6HcJyij8g/0G/uljbdDqy6nEdFGLDuEmY0SA4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oLuJe5fkVUqUeA7JNvKROA5F0HtcCTefv8JojYeNhT2LGSa3jDep7uvi/qD2QbrpzQHjfI09U8mq8KukqtvA3rSVRF5wQOvLnCGltAxl4ut3Di8KG2fu5YtAeXkZsRewysqi62U/uzb4MMQ5mT09MkLfqe+wU6h17mc/PC2GazzMycohgVF3ehxnYpyd+ueGorJrF75JZ92PxgDZ+U0nzP0Io108gEEE0Ei566DPsKY5XD9epECq87RSJKHrWtImM8Actcmjpmg7rYnqsIoFsbCkVSl9IP+qbXQc8Z/P2tpzgb89IOhbXtED/ZzaOJ526fAazxSCK/+HnElB+8E4UA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=qMMQV3nY; dkim-atps=neutral; spf=pass (client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=qMMQV3nY; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4b3PW83Pmjz3cFN for ; Fri, 23 May 2025 09:24:04 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 81A8CA4F6E2; Thu, 22 May 2025 23:24:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB9CBC4CEE4; Thu, 22 May 2025 23:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747956242; bh=UNgXV/OmBS6XzWhwhC+kkuFi7ERITkNf7w0qVbubW7g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qMMQV3nY413SZHUGA7ZTLZm9sJPK+q0/t8R2Px72ZIoVNrFdQvWPwFFePax/+cRDX 3OQ82iuVCHEa2kN4D7N+C49x+FHq7ZIu50Bvz8B34ywcczBrKa1Vw1BkHls8JaiQ5+ LaMwxBn2R+nLBHsOqvxRjefRybuob14n2c/Sx1+4/GSsH/wYDc2Qm4IPFcPwVx7GZj wqUA6WwJ2sNVX2YYeYnegmid3kV36QdCqfd8FbIlnfkx5++IjzMh69c6PggeNyXbgr hLFouW59TEoBpGdufaLlgQAnT2dTAAhfDjx+ye3EImrYOUkwVYpC6++IARxc5ynyFy gqA83HpvDIWRg== From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Jon Pan-Doh , Karolina Stolarek , Weinan Liu , Martin Petersen , Ben Fuller , Drew Walton , Anil Agrawal , Tony Luck , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sathyanarayanan Kuppuswamy , Lukas Wunner , Jonathan Cameron , Sargun Dhillon , "Paul E . McKenney" , Mahesh J Salgaonkar , Oliver O'Halloran , Kai-Heng Feng , Keith Busch , Robert Richter , Terry Bowman , Shiju Jose , Dave Jiang , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= Subject: [PATCH v8 11/20] PCI/AER: Trace error event before ratelimiting Date: Thu, 22 May 2025 18:21:17 -0500 Message-ID: <20250522232339.1525671-12-helgaas@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250522232339.1525671-1-helgaas@kernel.org> References: <20250522232339.1525671-1-helgaas@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Bjorn Helgaas As with the AER statistics, we always want to emit trace events, even if the actual dmesg logging is rate limited. Call trace_aer_event() immediately after pci_dev_aer_stats_incr() so both happen before ratelimiting. Signed-off-by: Bjorn Helgaas Tested-by: Krzysztof Wilczyński Reviewed-by: Ilpo Järvinen Reviewed-by: Kuppuswamy Sathyanarayanan Link: https://patch.msgid.link/20250520215047.1350603-12-helgaas@kernel.org --- drivers/pci/pcie/aer.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index 53f460bb7e6c..636bcd92afa1 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -715,6 +715,8 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) const char *level; pci_dev_aer_stats_incr(dev, info); + trace_aer_event(pci_name(dev), (info->status & ~info->mask), + info->severity, info->tlp_header_valid, &info->tlp); if (!info->status) { pci_err(dev, "PCIe Bus Error: severity=%s, type=Inaccessible, (Unregistered Agent ID)\n", @@ -742,9 +744,6 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) out: if (info->id && info->error_dev_num > 1 && info->id == id) pci_err(dev, " Error of this Agent is reported first\n"); - - trace_aer_event(dev_name(&dev->dev), (info->status & ~info->mask), - info->severity, info->tlp_header_valid, &info->tlp); } #ifdef CONFIG_ACPI_APEI_PCIEAER @@ -785,6 +784,8 @@ void pci_print_aer(struct pci_dev *dev, int aer_severity, info.mask = mask; pci_dev_aer_stats_incr(dev, &info); + trace_aer_event(pci_name(dev), (status & ~mask), + aer_severity, tlp_header_valid, &aer->header_log); layer = AER_GET_LAYER_ERROR(aer_severity, status); agent = AER_GET_AGENT(aer_severity, status); @@ -800,9 +801,6 @@ void pci_print_aer(struct pci_dev *dev, int aer_severity, if (tlp_header_valid) pcie_print_tlp_log(dev, &aer->header_log, dev_fmt(" ")); - - trace_aer_event(pci_name(dev), (status & ~mask), - aer_severity, tlp_header_valid, &aer->header_log); } EXPORT_SYMBOL_NS_GPL(pci_print_aer, "CXL"); -- 2.43.0