From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
"Oliver O'Halloran" <oohall@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Zhou Wang" <wangzhou1@hisilicon.com>,
"Will Deacon" <will@kernel.org>,
"Robert Richter" <rric@kernel.org>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Marc Zyngier" <maz@kernel.org>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
dingwei@marvell.com, cassel@kernel.org,
"Lukas Wunner" <lukas@wunner.de>,
"Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>,
linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 4/5] PCI: host-common: Add link down handling for host bridges
Date: Wed, 28 May 2025 17:35:00 -0500 [thread overview]
Message-ID: <20250528223500.GA58129@bhelgaas> (raw)
In-Reply-To: <20250508-pcie-reset-slot-v4-4-7050093e2b50@linaro.org>
On Thu, May 08, 2025 at 12:40:33PM +0530, Manivannan Sadhasivam wrote:
> The PCI link, when down, needs to be recovered to bring it back. But that
> cannot be done in a generic way as link recovery procedure is specific to
> host bridges. So add a new API pci_host_handle_link_down() that could be
> called by the host bridge drivers when the link goes down.
>
> The API will iterate through all the slots and calls the pcie_do_recovery()
> function with 'pci_channel_io_frozen' as the state. This will result in the
> execution of the AER Fatal error handling code. Since the link down
> recovery is pretty much the same as AER Fatal error handling,
> pcie_do_recovery() helper is reused here. First the AER error_detected
> callback will be triggered for the bridge and the downstream devices. Then,
> pci_host_reset_slot() will be called for the slot, which will reset the
> slot using 'reset_slot' callback to recover the link. Once that's done,
> resume message will be broadcasted to the bridge and the downstream devices
> indicating successful link recovery.
Link down is an event for a single Root Port. Why would we iterate
through all the Root Ports if the link went down for one of them?
next prev parent reply other threads:[~2025-05-28 22:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 7:10 [PATCH v4 0/5] PCI: Add support for resetting the slots in a platform specific way Manivannan Sadhasivam
2025-05-08 7:10 ` [PATCH v4 1/5] PCI/ERR: Remove misleading TODO regarding kernel panic Manivannan Sadhasivam
2025-05-09 3:04 ` Wilfred Mallawa
2025-05-09 6:11 ` Ethan Zhao
2025-05-09 6:51 ` Manivannan Sadhasivam
2025-05-14 16:39 ` Sathyanarayanan Kuppuswamy
2025-05-08 7:10 ` [PATCH v4 2/5] PCI/ERR: Add support for resetting the slots in a platform specific way Manivannan Sadhasivam
2025-05-08 7:18 ` Lukas Wunner
2025-05-09 2:59 ` Wilfred Mallawa
2025-05-14 6:33 ` Krishna Chaitanya Chundru
2025-05-14 16:42 ` Sathyanarayanan Kuppuswamy
2025-05-08 7:10 ` [PATCH v4 3/5] PCI: host-common: Make the driver as a common library for host controller drivers Manivannan Sadhasivam
2025-05-08 7:10 ` [PATCH v4 4/5] PCI: host-common: Add link down handling for host bridges Manivannan Sadhasivam
2025-05-14 6:30 ` Krishna Chaitanya Chundru
2025-05-14 16:33 ` Manivannan Sadhasivam
2025-05-28 22:35 ` Bjorn Helgaas [this message]
2025-05-30 3:46 ` Manivannan Sadhasivam
2025-05-30 11:34 ` Bjorn Helgaas
2025-05-30 16:09 ` Manivannan Sadhasivam
2025-06-02 21:13 ` Bjorn Helgaas
2025-07-07 11:05 ` Niklas Cassel
2025-07-07 11:29 ` Niklas Cassel
2025-07-09 12:32 ` Manivannan Sadhasivam
2025-06-02 21:19 ` Bjorn Helgaas
2025-05-08 7:10 ` [PATCH v4 5/5] PCI: qcom: Add support for resetting the slot due to link down event Manivannan Sadhasivam
2025-05-14 6:22 ` Krishna Chaitanya Chundru
2025-05-14 16:35 ` Manivannan Sadhasivam
2025-05-14 16:32 ` [PATCH v4 0/5] PCI: Add support for resetting the slots in a platform specific way Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528223500.GA58129@bhelgaas \
--to=helgaas@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=dingwei@marvell.com \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lpieralisi@kernel.org \
--cc=lukas@wunner.de \
--cc=mahesh@linux.ibm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maz@kernel.org \
--cc=oohall@gmail.com \
--cc=robh@kernel.org \
--cc=rric@kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).