From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1202CA0FE7 for ; Mon, 25 Aug 2025 21:37:28 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4c9kfH1YBHz3cmk; Tue, 26 Aug 2025 07:37:27 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c0a:e001:78e:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1756157847; cv=none; b=KOQH9JdVK3VMU72wEgNlHnQbss0s5LRQW8USMuqgxI+ynqduWJSdPzzacYq0IKHCz9BLKxxrfTX5nW2uZw1z4uzP3HcldJHMV01A9iYf+VqNdB89LL3uf693vDypRoU5/c0V1nt372ZCLdvn/UFxuiFjBBrI5qdUTMt994NFipG64LFHbPd0eOVvCWkyMdxEoG5/E2VPBOTQEOaATj6238QbEOww30lq9yrPCsEcyH/g6zj4y7T4HcXL3k6f/zbDvT1BMYgNeNHfPMR1V1uCadzU1YJmusc+23H/0WmD7pZpU7yOsMYd9d2fh1nJyoilZJIU67e5O8Bfkdn3QMbnXA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1756157847; c=relaxed/relaxed; bh=SodRd8/l8bZXSul9LRhyWd7CWue1H3vk6/6DPpbt56E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SyVNd0WCrkWsHWzXX60J0VeWBlb14t17QG+cGOT6S69FZ5EqH8z3j+KIk6Jsf00zRp3pv3FSWKkUCCMPHjFmgy6+n2nNotMHDM9M4Gh71flf6kWG5T65GVKI61/JoCkwuDM3MvYyNaTWouO+UgcbQVunHSRhwpwRoRE3gEI3z3Crbx86eNk578E0cVUAWKuHUIYcIRX7ZM1PVvNOhjsqiMDZPeVITbPdR6FI4tMtYcN1mbMQ4E4cunWijeS/iVjGoqjtukm98Zs7Db+8p9Smw7fcHSrfs2+5aISnHs543sFAzqsQXB3e/ZghpP4WlFQ40XNw44U1HA13Dyh3xEvRKA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=cHK0J2XK; dkim-atps=neutral; spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=kees@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=cHK0J2XK; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=kees@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4c9kfG3PdJz3clx for ; Tue, 26 Aug 2025 07:37:26 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D6D49406ED; Mon, 25 Aug 2025 21:37:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 567C9C113D0; Mon, 25 Aug 2025 21:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756157832; bh=R44bcAauESCYgLUnJio9oy6n01PzJ9gIprVhrTrJHrw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cHK0J2XKD7O53HrO4WZ8mbIIVXn1J5qjjnP+8NSiRBKE3qlSqot7fO4LiyDmh3qgE 994EaQi3GxaYUTiVcTdNq2CGuy4qPwf/BZ6vvOP7yQ30A6KQwyOxLpJ4d9L/7pKqbH 63qLEryMSPxlPH2YhbRhXt0pRoKURT7ELLjHiKpyDkSL4+J1AcoW5Sk8qXCImM2+ak p+lYv9xx85LoSuSqFv4ayEsXAVqjvuHqIqMi44uUedVEGuxxRKPPODQHHSRnAgIdh6 6clMMLqdhTofD9UT8HCFqf2Jy7NMLg5RmykPuzN+FoKKgILHRb4q6/nyDxdavQQRRP 2Gu14gyBVu0BQ== Date: Mon, 25 Aug 2025 14:37:11 -0700 From: Kees Cook To: Uladzislau Rezki Cc: Mike Rapoport , Lorenzo Stoakes , Harry Yoo , Andrew Morton , Russell King , Catalin Marinas , Will Deacon , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "David S . Miller" , Andreas Larsson , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Alexander Viro , Christian Brauner , Jan Kara , Peter Xu , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Hugh Dickins , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Dan Williams , Matthew Wilcox , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jason Gunthorpe , John Hubbard , Muchun Song , Oscar Salvador , Jann Horn , Pedro Falcato , Johannes Weiner , Qi Zheng , Shakeel Butt , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, sparclinux@vger.kernel.org, linux-sgx@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm: update core kernel code to use vm_flags_t consistently Message-ID: <202508251436.762035B@keescook> References: <73764aaa-2186-4c8e-8523-55705018d842@lucifer.local> <69860c97-8a76-4ce5-b1d6-9d7c8370d9cd@lucifer.local> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Aug 05, 2025 at 06:13:56PM +0200, Uladzislau Rezki wrote: > I agree. Also it can be even moved under vmalloc.c. There is only one > user which needs it globally, it is usercopy.c. It uses find_vmap_area() > which is wrong. See: > > > if (is_vmalloc_addr(ptr) && !pagefault_disabled()) { > struct vmap_area *area = find_vmap_area(addr); > > if (!area) > usercopy_abort("vmalloc", "no area", to_user, 0, n); > > if (n > area->va_end - addr) { > offset = addr - area->va_start; > usercopy_abort("vmalloc", NULL, to_user, offset, n); > } > return; > } > > > we can add a function which just assign va_start, va_end as input > parameters and use them in the usercopy.c. Yes please! I'd must rather use some exported validation routine than having it hand-coded in usercopy.c. :) -- Kees Cook