* [PATCH] powerpc/pasemi: Fix PCI device reference leak on error path
@ 2025-08-29 6:34 Miaoqian Lin
2025-09-02 14:34 ` Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2025-08-29 6:34 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Miaoqian Lin, Jeff Garzik, Olof Johansson,
linuxppc-dev, linux-kernel
Fix iob_pdev reference leak in pasemi_dma_init() when dma_pdev
allocation fails. Ensure pci_dev_put(iob_pdev) is called on
both success and error paths.
Fixes: 8ee9d8577935 ("pasemi: DMA engine management library")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/powerpc/platforms/pasemi/dma_lib.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pasemi/dma_lib.c b/arch/powerpc/platforms/pasemi/dma_lib.c
index 1be1f18f6f09..0ba05c39c276 100644
--- a/arch/powerpc/platforms/pasemi/dma_lib.c
+++ b/arch/powerpc/platforms/pasemi/dma_lib.c
@@ -530,7 +530,7 @@ int pasemi_dma_init(void)
BUG();
pr_warn("Can't find DMA controller\n");
err = -ENODEV;
- goto out;
+ goto out_put_iob;
}
dma_regs = map_onedev(dma_pdev, 0);
base_hw_irq = virq_to_hw(dma_pdev->irq);
@@ -617,5 +617,9 @@ int pasemi_dma_init(void)
out:
spin_unlock(&init_lock);
return err;
+
+out_put_iob:
+ pci_dev_put(iob_pdev);
+ goto out;
}
EXPORT_SYMBOL(pasemi_dma_init);
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] powerpc/pasemi: Fix PCI device reference leak on error path
2025-08-29 6:34 [PATCH] powerpc/pasemi: Fix PCI device reference leak on error path Miaoqian Lin
@ 2025-09-02 14:34 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2025-09-02 14:34 UTC (permalink / raw)
To: Miaoqian Lin, linuxppc-dev
Cc: LKML, Christophe Leroy, Madhavan Srinivasan, Michael Ellerman,
Nicholas Piggin, Olof Johansson
> Fix iob_pdev reference leak in pasemi_dma_init() when dma_pdev
> allocation fails. Ensure pci_dev_put(iob_pdev) is called on
> both success and error paths.
How do you think about to increase the application of scope-based resource management?
…
> +++ b/arch/powerpc/platforms/pasemi/dma_lib.c
> @@ -530,7 +530,7 @@ int pasemi_dma_init(void)
> BUG();
> pr_warn("Can't find DMA controller\n");
> err = -ENODEV;
> - goto out;
Is it sufficient to add the function call “pci_dev_put(iob_pdev)”
in this if branch?
> + goto out_put_iob;
> }
> dma_regs = map_onedev(dma_pdev, 0);
…
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-02 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-29 6:34 [PATCH] powerpc/pasemi: Fix PCI device reference leak on error path Miaoqian Lin
2025-09-02 14:34 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).