From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Zhiqi Song <songzhiqi1@huawei.com>,
Longfang Liu <liulongfang@huawei.com>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 5/6] lib/crypto: curve25519: Consolidate into single module
Date: Tue, 2 Sep 2025 19:12:11 -0700 [thread overview]
Message-ID: <20250903021211.GA6491@sol> (raw)
In-Reply-To: <20250901201815.594177-6-ebiggers@kernel.org>
On Mon, Sep 01, 2025 at 01:18:14PM -0700, Eric Biggers wrote:
> diff --git a/lib/crypto/tests/Kconfig b/lib/crypto/tests/Kconfig
> index 7e4e66f30a7a6..c0f3b64489dd6 100644
> --- a/lib/crypto/tests/Kconfig
> +++ b/lib/crypto/tests/Kconfig
> @@ -11,13 +11,14 @@ config CRYPTO_LIB_BLAKE2S_KUNIT_TEST
> KUnit tests for the BLAKE2s cryptographic hash function.
>
> config CRYPTO_LIB_CURVE25519_KUNIT_TEST
> tristate "KUnit tests for Curve25519" if !KUNIT_ALL_TESTS
> depends on KUNIT
> - default KUNIT_ALL_TESTS
> + default KUNIT_ALL_TESTS || CRYPTO_SELFTESTS
> select CRYPTO_LIB_BENCHMARK_VISIBLE
> select CRYPTO_LIB_CURVE25519
> + select CRYPTO_LIB_CURVE25519_GENERIC
> help
> KUnit tests for Curve25519.
Small correction above: adding 'select CRYPTO_LIB_CURVE25519_GENERIC'
is unnecessary here.
- Eric
next prev parent reply other threads:[~2025-09-03 2:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 20:18 [PATCH 0/6] Curve25519 cleanup Eric Biggers
2025-09-01 20:18 ` [PATCH 1/6] crypto: curve25519 - Remove kpp support Eric Biggers
2025-09-04 8:10 ` Geert Uytterhoeven
2025-09-01 20:18 ` [PATCH 2/6] lib/crypto: tests: Migrate Curve25519 self-test to KUnit Eric Biggers
2025-09-01 20:18 ` [PATCH 3/6] lib/crypto: tests: Add Curve25519 benchmark Eric Biggers
2025-09-01 20:18 ` [PATCH 4/6] lib/crypto: curve25519: Move a couple functions out-of-line Eric Biggers
2025-09-01 20:18 ` [PATCH 5/6] lib/crypto: curve25519: Consolidate into single module Eric Biggers
2025-09-03 2:12 ` Eric Biggers [this message]
2025-09-01 20:18 ` [PATCH 6/6] wireguard: kconfig: Simplify crypto kconfig selections Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903021211.GA6491@sol \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liulongfang@huawei.com \
--cc=songzhiqi1@huawei.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).