From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CC84CCD192 for ; Wed, 15 Oct 2025 13:08:24 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4cmrxL5Tgtz3dGn; Thu, 16 Oct 2025 00:08:22 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=185.246.85.4 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1760533702; cv=none; b=gbNvwCebIbJuHUmQhyExvTKVnWHqby7J1PUbWAiJ7NrvmTQYXwBtEdGeP7Li/jL5c9Y6w9ITdAY0fgi2n6lcMd7v/y3rPBvCHIJkCQro8OxA4DRkAjVF0s7STET7gwzwMTnYX8zkc6Oor9RsSsAAce7QK6iV4InlV7ux6Fde05nhNUNhvjmDoHqlJACM4xZqVu54v+gcK2ZuONgu9RqKEoiTVcaBoolNz9Bxi6FUzLSx+camf4kYmbI/ZhTOKn9R63uzxgKbfYjgqnm4mGXGA4AEJqTy6nC1qNJLnhXjXX04VbleihbVqq7a14TOR38e/TYudbxd6PcthbKeO3KtRQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1760533702; c=relaxed/relaxed; bh=m0D5lTBcRRjQJDnMrKYFTSajSsfESny/hir+6+IztSM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZhBB4aepEQnc+wY1X+Vzslac8yLzQOvjRVS8qrK3P3ye7HV1rlfxJ6a8a2rXa4gd045uodTeZsvKTW7qLpztAphBPpIXvIeeDgQq+4Dd/P24FY6kXrrKSCKWAGB5dS+hQ3ltDYds/Xm3Qba8+sZpXWXZmsrIJ+Zi/LMZ6kQNuS8LlvVALloH1G8k34Ee6C1VO7j0QX4MyzzbbJi2wGunKw9bWBW1+QjjVGXw4LgYrQGSGUnUyRMVYvconoI3hl5hFFXgcVpQlzrTUBnt8aKKBq47yiPi50h6ZmuvFbHtrH5DI2mev1aaNXTSisxCqjUsAfqT31HeumpDyPnlvp2hXA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=vXKGWoKL; dkim-atps=neutral; spf=pass (client-ip=185.246.85.4; helo=smtpout-03.galae.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) smtp.mailfrom=bootlin.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=vXKGWoKL; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=185.246.85.4; helo=smtpout-03.galae.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) X-Greylist: delayed 528 seconds by postgrey-1.37 at boromir; Thu, 16 Oct 2025 00:08:21 AEDT Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4cmrxK335Jz3dBy for ; Thu, 16 Oct 2025 00:08:20 +1100 (AEDT) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 644D24E410D7; Wed, 15 Oct 2025 12:59:27 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 31720606F9; Wed, 15 Oct 2025 12:59:27 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 11EBB102F22C9; Wed, 15 Oct 2025 14:59:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1760533166; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=m0D5lTBcRRjQJDnMrKYFTSajSsfESny/hir+6+IztSM=; b=vXKGWoKLCXCUAGdXC3OwlCdAQymxkkrvdpzzd4URDlQaQTu1vQLPHJC017heFxnT1EW04e IXG4AOCWtOqNWXGc8yQT8PddYEjb+3S444gkqLlF0OHI7T+FsP0R6bHh/+OLGchTkfw2Pg +FpXk/t1MDhV6qtD/lMl/Kmi3sJWSQ5XGKAOpbCnxde/OsTK/JJAj5d6Fi2h1AebNU5xFw 2yHMqpM7O/y+L4TsCbezCoqI0TTnF2wcz5MScuEKSmHZ8blFB/BjH3mRler0fMd/vJ8UWJ HGbxXETRHihUIul00MlMDpp17FxdMozgH6Q0h4CEhOf7fCPipPYNnT5JkL+dzA== Date: Wed, 15 Oct 2025 14:59:01 +0200 From: Herve Codina To: Christian Zigotzky Cc: Manivannan Sadhasivam , Bjorn Helgaas , Lukas Wunner , Manivannan Sadhasivam , Ilpo =?UTF-8?B?SsOkcnZpbmVu?= , linux-pci@vger.kernel.org, mad skateman , "R.T.Dickinson" , Christian Zigotzky , linuxppc-dev , hypexed@yahoo.com.au, Darren Stevens , debian-powerpc@lists.debian.org, Thomas Petazzoni Subject: Re: [PPC] Boot problems after the pci-v6.18-changes Message-ID: <20251015145901.3ca9d8a0@bootlin.com> In-Reply-To: References: <20251015135811.58b22331@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 On Wed, 15 Oct 2025 14:27:00 +0200 Christian Zigotzky wrote: > > On 15 October 2025 at 01:58 pm, Herve Codina wrote: > > > > Hi Christian, > > > >> On Wed, 15 Oct 2025 13:30:44 +0200 > >> Christian Zigotzky wrote: > >> > >> Hello Herve, > >> > >>>> On 15 October 2025 at 10:39 am, Herve Codina wrote: > >>> > >>> Hi All, > >>> > >>> I also observed issues with the commit f3ac2ff14834 ("PCI/ASPM: Enable all > >>> ClockPM and ASPM states for devicetree platforms") > >> > >> Thanks for reporting. > >> > >>> > >>> Also tried the quirk proposed in this discussion (quirk_disable_aspm_all) > >>> an the quirk also fixes the timing issue. > >> > >> Where have you added quirk_disable_aspm_all? > > > > --- 8< --- > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > > index 214ed060ca1b..a3808ab6e92e 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -2525,6 +2525,17 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev *dev) > > */ > > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_l0s_l1); > > > > +static void quirk_disable_aspm_all(struct pci_dev *dev) > > +{ > > + pci_info(dev, "Disabling ASPM\n"); > > + pci_disable_link_state(dev, PCIE_LINK_STATE_ALL); > > +} > > + > > +/* LAN966x PCI board */ > > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_EFAR, 0x9660, quirk_disable_aspm_all); > > + > > /* > > * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain > > * Link bit cleared after starting the link retrain process to allow this > > --- 8< --- > > > > Best regards, > > Hervé > > It is the same patch, I use for my AMD Radeon cards. > > In my point of view we have to add a lot of other devices. Yes, probably! > > But if the computer does not boot, will the average user know that there is a problem with the power management and their graphics card? > I am unsure whether I can deliver the kernel to average users later on. Also when it boots, it is not easy to know about the problem root cause. In my case, it was not obvious to make the relationship on my side between my ping timings behavior and ASPM. Of course 'git bisect' helped a lot but can we rely on that for the average user? Best regards, Hervé