From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
linux-doc@vger.kernel.org, virtualization@lists.linux.dev,
"David Hildenbrand" <david@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Oscar Salvador" <osalvador@suse.de>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Mike Rapoport" <rppt@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Michal Hocko" <mhocko@suse.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jerrin Shaji George" <jerrin.shaji-george@broadcom.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>, "Zi Yan" <ziy@nvidia.com>
Subject: [PATCH v1 01/23] vmw_balloon: adjust BALLOON_DEFLATE when deflating while migrating
Date: Tue, 21 Oct 2025 14:59:06 +0200 [thread overview]
Message-ID: <20251021125929.377194-2-david@redhat.com> (raw)
In-Reply-To: <20251021125929.377194-1-david@redhat.com>
When we're effectively deflating the balloon while migrating a page
because inflating the new page failed, we're not adjusting
BALLOON_DEFLATE.
Let's do that. This is a preparation for factoring out this handling to
the core code, making it work in a similar way first.
As this (deflating while migrating because of inflation error) is a
corner case that I don't really expect to happen in practice
and the stats are not that crucial, this likely doesn't classify as a fix.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
drivers/misc/vmw_balloon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
index cc1d18b3df5ca..2cc34c4968fac 100644
--- a/drivers/misc/vmw_balloon.c
+++ b/drivers/misc/vmw_balloon.c
@@ -1818,6 +1818,8 @@ static int vmballoon_migratepage(struct balloon_dev_info *b_dev_info,
if (status == VMW_BALLOON_SUCCESS) {
balloon_page_insert(&b->b_dev_info, newpage);
__count_vm_event(BALLOON_MIGRATE);
+ } else {
+ __count_vm_event(BALLOON_DEFLATE);
}
/*
--
2.51.0
next prev parent reply other threads:[~2025-10-21 12:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 12:59 [PATCH v1 00/23] mm: balloon infrastructure cleanups David Hildenbrand
2025-10-21 12:59 ` David Hildenbrand [this message]
2025-10-22 1:03 ` [PATCH v1 01/23] vmw_balloon: adjust BALLOON_DEFLATE when deflating while migrating SeongJae Park
2025-10-21 12:59 ` [PATCH v1 02/23] vmw_balloon: remove vmballoon_compaction_init() David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 03/23] powerpc/pseries/cmm: remove cmm_balloon_compaction_init() David Hildenbrand
2025-10-21 20:43 ` Michael S. Tsirkin
2025-10-22 8:37 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 04/23] mm/balloon_compaction: centralize basic page migration handling David Hildenbrand
2025-10-21 20:50 ` Michael S. Tsirkin
2025-10-22 8:37 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 05/23] mm/balloon_compaction: centralize adjust_managed_page_count() handling David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 06/23] vmw_balloon: stop using the balloon_dev_info lock David Hildenbrand
2025-10-21 20:57 ` Michael S. Tsirkin
2025-10-22 8:40 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 07/23] mm/balloon_compaction: use a device-independent balloon (list) lock David Hildenbrand
2025-10-21 20:52 ` Michael S. Tsirkin
2025-10-22 8:42 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 08/23] mm/balloon_compaction: remove dependency on page lock David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 09/23] mm/balloon_compaction: make balloon_mops static David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 10/23] mm/balloon_compaction: drop fs.h include from balloon_compaction.h David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 11/23] drivers/virtio/virtio_balloon: stop using balloon_page_push/pop() David Hildenbrand
2025-10-21 20:59 ` Michael S. Tsirkin
2025-10-22 8:43 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 12/23] mm/balloon_compaction: remove balloon_page_push/pop() David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 13/23] mm/balloon_compaction: fold balloon_mapping_gfp_mask() into balloon_page_alloc() David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 14/23] mm/balloon_compaction: move internal helpers to memory_compaction.c David Hildenbrand
2025-10-21 15:36 ` Zi Yan
2025-10-21 15:37 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 15/23] mm/balloon_compaction: assert that the balloon_pages_lock is held David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 16/23] mm/balloon_compaction: mark remaining functions for having proper kerneldoc David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 17/23] mm/balloon_compaction: remove "extern" from functions David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 18/23] mm/vmscan: drop inclusion of balloon_compaction.h David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 19/23] mm: rename balloon_compaction.(c|h) to balloon.(c|h) David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 20/23] mm/kconfig: make BALLOON_COMPACTION depend on MIGRATION David Hildenbrand
2025-10-21 17:13 ` Randy Dunlap
2025-10-21 18:43 ` David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 21/23] mm: rename CONFIG_BALLOON_COMPACTION to CONFIG_BALLOON_MIGRATION David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 22/23] mm: rename CONFIG_MEMORY_BALLOON -> CONFIG_BALLOON David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 23/23] MAINTAINERS: move memory balloon infrastructure to "MEMORY MANAGEMENT - BALLOON" David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021125929.377194-2-david@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=eperezma@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=jerrin.shaji-george@broadcom.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maddy@linux.ibm.com \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).