From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B7ACCCF9E3 for ; Tue, 11 Nov 2025 10:56:40 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4d5Nkt6vS3z30C0; Tue, 11 Nov 2025 21:56:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c04:e001:324:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1762858598; cv=none; b=fO1GG7iRyTF9bOZwpq3wjnGuHbUZ6b2jF5DafYQDKPuAY3GWjRSKzZeYY2P4n/xUtVzvK0KmOS7R9NdKvBGqe+xSZfliQivj5WeUkM002kTfOyqZAY1GzquqEEezKq1UvKk96K4BpJB2+E+Ibn3+qXRtXX/Jeufa4lWf2+Me9+nQih94shw2fdD/5TZHYJKcOA1hjQTS5vn4lDdHW+aMdbDbseFHMMmBfIM5w1XVh5GSomjOz+WL4tf5GzoME8d/CMYc1RjuorcpwYbqVfv87EiSBZjNqmmv1WqXaaqwxVKjfYAIm0752z0r4OQv5MbK5VNiq7O7iJhbSreljuzf+w== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1762858598; c=relaxed/relaxed; bh=rjRq0YRtxMoRBmf76gnK3sXsLqWZGz3LL8//ivtwijk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZzIb02Q8K77IjQroo2b0x0AU2aaLSm0l8lLksOzNmRpSOTTyNKhnsAzmwmlaUmYdp3i8DFoIm2m6XQDb17tcxEuL1iHp0llARIRifZyJJD6M9+/HI++/XCXu8Y52OKIiAvSQBTeaYeBoAT1wOb4j+B4aXNUvWrkJP+WGi1vS9h5TzShAgFKwwU1Y1fI4kT7EYBHbFsgn/8GAbwAhH4avsepIYqHhv8XniskRfU3Tm5/LkTVR+FX8k8PL1gYydOkXgH72K0VsJQ8CKsXtlzI2jug1iOWTt6uRQxQZ4VTEtwRF7t4Le+Z149V51Y2ukKbEss6TtZAKyJy9tLK04SIxIA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YKJFap5K; dkim-atps=neutral; spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=brauner@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YKJFap5K; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=brauner@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4d5Nks6tZ2z2xFR for ; Tue, 11 Nov 2025 21:56:37 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id BF0FD61909; Tue, 11 Nov 2025 10:56:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 313A8C4CEF7; Tue, 11 Nov 2025 10:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762858594; bh=LLE8UQmsCCogkZVKSd1TLbVt9gs72Jh93jqozm60ebU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YKJFap5K6aImcv2glJeiNMSpxrwhX6LrxJE9jB2o/nF/WyKkn1WH6018FXJoi/UCP kwILmx0XpLJxYnaUhsyl42/On0deramtMNIHMDakZ3XBWX3DBuNSISALizcXkP5J1g As9tysDbaFlf4n4MhlGm4iCSknWQmP/uRA7y3UcgxHHrHNeSX1vdVQgCeGvYZzT/xd 4kN6IgSEXZHZeuWLm2Bdu2rfQ3za3HSpRsHwoEVGtapRsGF7Y0ZMbazAjnKP+Hw6s1 1ehJojThYLaGzj/AfbW9ZcFiZLxCIHI4qKUiP0ztlFxRlVs0DdQDmb3wCyvyfh4liI CUKpd3rfxq+1w== Date: Tue, 11 Nov 2025 11:56:27 +0100 From: Christian Brauner To: Al Viro Cc: James Bottomley , Ard Biesheuvel , linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org, jack@suse.cz, raven@themaw.net, miklos@szeredi.hu, neil@brown.name, a.hindborg@kernel.org, linux-mm@kvack.org, linux-efi@vger.kernel.org, ocfs2-devel@lists.linux.dev, kees@kernel.org, rostedt@goodmis.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, paul@paul-moore.com, casey@schaufler-ca.com, linuxppc-dev@lists.ozlabs.org, john.johansen@canonical.com, selinux@vger.kernel.org, borntraeger@linux.ibm.com, bpf@vger.kernel.org Subject: Re: [PATCH v2 22/50] convert efivarfs Message-ID: <20251111-tolerant-profan-0aff1cc76691@brauner> References: <20251028210805.GP2441659@ZenIV> <9f079d0c8cffb150c0decb673a12bfe1b835efc9.camel@HansenPartnership.com> <20251029193755.GU2441659@ZenIV> <20251105-aufheben-ausmusterung-4588dab8c585@brauner> <423f5cc5352c54fc21e0570daeeddc4a58e74974.camel@HansenPartnership.com> <20251105-sohlen-fenster-e7c5af1204c4@brauner> <20251105-vorbild-zutreffen-fe00d1dd98db@brauner> <20251109204018.GH2441659@ZenIV> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251109204018.GH2441659@ZenIV> On Sun, Nov 09, 2025 at 08:40:18PM +0000, Al Viro wrote: > On Wed, Nov 05, 2025 at 02:43:34PM +0100, Christian Brauner wrote: > > > -static void filesystems_freeze_callback(struct super_block *sb, void *unused) > > +static void filesystems_freeze_callback(struct super_block *sb, void *bool_freeze_all) > > { > > + bool freeze_all = *(bool *)bool_freeze_all; > > + > > if (!sb->s_op->freeze_fs && !sb->s_op->freeze_super) > > return; > > > > + if (!freeze_all) { > > Minor nitpick: do we even need a dereference here? Just check > whether the argument is NULL and adjust the caller... Yup, sounds good.