From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70E2BCCF9E3 for ; Tue, 11 Nov 2025 12:20:08 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4d5QbB5vjZz2yvT; Tue, 11 Nov 2025 23:20:06 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1762863606; cv=none; b=VrxPv1quPY61EcBRtjbrcK50SiGA6aCRrEvYDSCgHrk9YazbUQrfmH3w78uutHwxYfxS10rOQ9CRaTLBolLKJf+ELtz31aK2liOgfwig8qg0VdEo09aPeRhIN5HTD55SaJf+ai063BYZwtCYoM+o2/QHYFhekgg+GBw5ObtTZZwzCEwiErm1s67u09XDM+9Hf4Dran++SMpo0yBnSqnK90ZhApW4mVuEumv6eULMYVGOkEFrTDBi0I3B7S9zjSLTI3Vl7neYjOrS7VQ+7UtVOh49ZuIxXUyBgXUEeQeh5gz+33Srln4SjlTNLpiOgaQdR72OdBMBlHFwZe/s/VZZcQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1762863606; c=relaxed/relaxed; bh=g6jHUq/xQKtGcgiL9PFjvZSkTY/oV+0De4Fhqq3zjSI=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=LDFpYrysqOfDWD2AvaieV0TD+SDIm+iqaamFXmFNEiXEH1oFwEHVJH3R5tuJyDAnV1jGCTFvzV0AS18kwwtmfNcL3yTu9zovC4ZwcOD5W7bHKIIhkd+JjtEoMmZ6XoH4pAY6Kuq3viZNPqD1PJxELLFWJkmnT9EXOFpi92FEDAjtghcoJOGhq8v1YChmxft8gtD+YHk8Wd58DSVGS15ZkWwQ9FTXym62749GPZ4IqTCEcZMNV1hG/S47kM6/dwE5GBsFG35oobmsMFZ1Ta1BSeiMxrl/q5Znva3oDRWKQFKY/QwSVRRPQLMdASKR1zCirMGASwnfQWPlkDfJh7u1IA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=DOUxslbs; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=DOUxslbs; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4d5QbB1Jzlz2xFR for ; Tue, 11 Nov 2025 23:20:06 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 8F09A61903; Tue, 11 Nov 2025 12:20:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F31C4C2BCB1; Tue, 11 Nov 2025 12:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762863603; bh=fw4bBM14g4kHXLxHnq+oCuA8+A4FD4yo4UWJLbL05fE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=DOUxslbsCSH498vEuLR+iHlaDZ8WU5xeGprTHuH6M0tZYMLRUKY2wmjvziY09guPY h/PIEjXW6VAKPzJ88uiyJvC1/3jeefbQcFw6HAtPMyXuCvh8b2onP7SyMa64PRjmyP L6SbFpbmYsZpavVGEllVQLB8+vwxUNLmp/6bt2O7is7Iqw4GqwfMelA9NsWehCgA/H kyLHceRkVzEBRJGMHBZoM9ntLviKIgTiRmHNTVJ4L266pP3kxMp4meUZ2crhGBgPwp TJ+5B77w8hRofDlgzjbqSA6QKSmHVmxPdxEgjSf9BXH74HbcgExTqLGjQcDLIrzGUw k0QHh/PwrZkag== Date: Tue, 11 Nov 2025 06:20:01 -0600 From: Bjorn Helgaas To: Christian Zigotzky Cc: Manivannan Sadhasivam , Bjorn Helgaas , linux-pci@vger.kernel.org, mad skateman , "R.T.Dickinson" , Christian Zigotzky , linuxppc-dev , hypexed@yahoo.com.au, Darren Stevens , debian-powerpc@lists.debian.org, John Paul Adrian Glaubitz , Lukas Wunner , regressions@lists.linux.dev, luigi burdo , Al Subject: Re: [PPC] Boot problems after the pci-v6.18-changes Message-ID: <20251111122001.GA2168158@bhelgaas> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Nov 11, 2025 at 06:15:20AM +0100, Christian Zigotzky wrote: > On 11/07/2025 06:06 AM, Christian Zigotzky wrote: > > On 11/05/2025 11:09 PM, Bjorn Helgaas wrote: > > >> I tested your patch with the RC4 of kernel 6.18 today. Unfortunately > > it > > >> doesn't solve the boot issue. > > > > > > Thanks for testing that.  I see now why that approach doesn't work: > > > quirk_disable_aspm_l0s_l1() calls pci_disable_link_state(), which > > > updates the permissible ASPM link states, but pci_disable_link_state() > > > only works for devices at the downstream end of a link.  It doesn't > > > work at all for Root Ports, which are at the upstream end of a link. > > > > > > Christian, you originally reported that both X5000 and X1000 were > > > broken.  I suspect X1000 may have been fixed in v6.18-rc3 by > > > df5192d9bb0e ("PCI/ASPM: Enable only L0s and L1 for devicetree > > > platforms"), but I would love to have confirmation of that. > > > > Hello Bjorn, > > > > I will enable CONFIG_PCIEASPM and CONFIG_PCIEASPM_DEFAULT for the RC5 of > > kernel 6.18 and test it with the X1000. > > I tested the RC5 of kernel 6.18 with CONFIG_PCIEASPM and > CONFIG_PCIEASPM_DEFAULT enabled on my X1000 today. Unfortunately the boot > problems are still present. Thanks. Can you post a dmesg somewhere so I can see what the relevant device IDs are? Can be with any kernel, doesn't have to be v6.18. We need the Vendor and Device IDs to add a quirk.