From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C63CCD0EE18 for ; Tue, 25 Nov 2025 23:18:45 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4dGJXg5T8sz2yrT; Wed, 26 Nov 2025 10:18:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1764112723; cv=none; b=K8u2W9XvV7hC1dnm+ExLY4TGpZarzBtU8ya15xUqckR16VZMA8BbHryPV6qejJpOuz69YDqIN9wC7AeKlpmyv8PCcor3GKH3gUKHOWQ/Ji2YFDkNvWTQNQNrXf4uxXG5srD2CFStoF9pSvxeiFletaAboWf1sSnbQVLWNXq8nbS+hHJwY33xBdIKcYJMOf/KEeHC7rXTrO5Ta/IIcbGzCwnWiyJdlFV9WT5LUMvVbozgcoFnYcM13upkQfNOK7e7uDWkjzlsAYv6CbvFIuCHKU1IR+KeWBF9bwcNVhLJ5z70pi7b3Kc/nSKMD8AfoTE4xuMpDGft82RHNHV/D+Waqw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1764112723; c=relaxed/relaxed; bh=OVE0olI+Sw+Afu2W+ZpviOHAzFVBOEyjagHVeK+a/Mg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BD230tcsBGk2vgc2FkonrE/gdrh+Z+IbgyylpSic9/QOhJOrQvUKnbfHTadYEfGvMO6c0LcGfSsmMC5hKbQfY3I8pmdjHMFUAuwM3tXxHqIBbWL6GsWCRLN3hRK9ZQJxfptWn+VCklZxfC2WwT79xxikxqeMCy0PGYLPFiLYsk1uiewk9nYYAALY3XHKZ87s5dtu0BsDevZfB7U/+RLHuS1zlqgpPrUkARv3fDxIIefbv2MEpvkjtTfhEfsjimcB4mH0gA5pBlttsw9stZtc6Dp/niWdkDIgnTM+GWnPs4vxRVYFIta57agaOFlSY93KsjCNz8blH1edOMlbgzeEHg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dR5WcjLv; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=nathan@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dR5WcjLv; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=nathan@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4dGJXf2Dvwz2xQs for ; Wed, 26 Nov 2025 10:18:42 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id DEA69403A4; Tue, 25 Nov 2025 23:18:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0C03C4CEF1; Tue, 25 Nov 2025 23:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764112719; bh=EP+I/OB+/gkIIlYRBPDpfe/MYnzPkdpoIh9BAFVe1Sc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dR5WcjLvKrM+sMfACkD4/tAfNcprzACyFoL4nUDMA2TQeiSKSTXQabeQGQxlEJaRw jscevgQvd2WZ5VMimJGElz8sElnhRXq4IDUlkm+f73+6dZMlpe6YTqRnh4/V5hT8bQ nkCrZejRGlt6w6g19BsDeayi5764tYLPpxELBjQyC6LUUcrrBizgLbsBBgFvBHkltg jIvmxO/9VbRyXb/ZY0oGzKt1nTohuD/WitwBFbvqTdfTCPIVQCvxZBXBaLWveyODRu mkArj0xds+pCM7qvBMXnH1orufJscq69U4D4kKY0EZ1MVnygApgRcg39pXwsTbWWYC K/B+uWaB9QuKA== Date: Tue, 25 Nov 2025 16:18:34 -0700 From: Nathan Chancellor To: "Christophe Leroy (CS GROUP)" Cc: Thomas Gleixner , kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org, Ingo Molnar , "Peter Zijlstra (Intel)" , Mathieu Desnoyers , linuxppc-dev@lists.ozlabs.org Subject: Re: [tip:core/rseq 25/39] include/linux/rseq_entry.h:132:3: error: invalid operand for instruction Message-ID: <20251125231834.GA4012217@ax162> References: <202511250134.i0Jm8d7I-lkp@intel.com> <874iqji6n1.ffs@tglx> <897c6ba7-e27d-4170-be56-4d0f544bfa42@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <897c6ba7-e27d-4170-be56-4d0f544bfa42@kernel.org> On Tue, Nov 25, 2025 at 08:38:40AM +0100, Christophe Leroy (CS GROUP) wrote: > > > Le 24/11/2025 à 20:15, Thomas Gleixner a écrit : > > On Tue, Nov 25 2025 at 01:37, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core/rseq > > > head: 21782b3a5cd40892cb2995aa1ec3e74dd1112f1d > > > commit: abc850e7616c91ebaa3f5ba3617ab0a104d45039 [25/39] rseq: Provide and use rseq_update_user_cs() > > > config: powerpc-randconfig-002-20251124 (https://download.01.org/0day-ci/archive/20251125/202511250134.i0Jm8d7I-lkp@intel.com/config) > > > compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6) > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251125/202511250134.i0Jm8d7I-lkp@intel.com/reproduce) > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202511250134.i0Jm8d7I-lkp@intel.com/ > > > > > > All errors (new ones prefixed by >>): > > > > > > In file included from kernel/rseq.c:75: > > > > > include/linux/rseq_entry.h:132:3: error: invalid operand for instruction > > > unsafe_get_user(start_ip, &ucs->start_ip, efault); > > > ^ > > > include/linux/uaccess.h:606:2: note: expanded from macro 'unsafe_get_user' > > > arch_unsafe_get_user(x, ptr, local_label); \ > > > ^ > > > arch/powerpc/include/asm/uaccess.h:458:2: note: expanded from macro 'arch_unsafe_get_user' > > > __get_user_size_goto(__gu_val, __gu_addr, sizeof(*(p)), e); \ > > > ^ > > > arch/powerpc/include/asm/uaccess.h:282:2: note: expanded from macro '__get_user_size_goto' > > > __get_user_size_allowed(x, ptr, size, __gus_retval); \ > > > ^ > > > arch/powerpc/include/asm/uaccess.h:273:10: note: expanded from macro '__get_user_size_allowed' > > > case 8: __get_user_asm2(x, (u64 __user *)ptr, retval); break; \ > > > ^ > > > arch/powerpc/include/asm/uaccess.h:256:4: note: expanded from macro '__get_user_asm2' > > > " li %1+1,0\n" \ > > > ^ > > > :7:5: note: instantiated into assembly here > > > li 31+1,0 > > > > Definitely not a problem of tip core/rseq. It just ends up in > > __get_user_asm2() and then the compiler gets unhappy about the PowerPC > > inline assembly for whatever reason. > > I see it is a CLANG build. > > CLANG might be less flexible, can you test with following change ? That avoids the error for me. I notice that this does not reproduce beyond clang-16 for me so I am going to bisect LLVM to see what fixes this error. > diff --git a/arch/powerpc/include/asm/uaccess.h > b/arch/powerpc/include/asm/uaccess.h > index 4f5a46a77fa2..33d5f7ade254 100644 > --- a/arch/powerpc/include/asm/uaccess.h > +++ b/arch/powerpc/include/asm/uaccess.h > @@ -253,7 +253,7 @@ __gus_failed: \ > ".section .fixup,\"ax\"\n" \ > "4: li %0,%3\n" \ > " li %1,0\n" \ > - " li %1+1,0\n" \ > + " li %L1,0\n" \ > " b 3b\n" \ > ".previous\n" \ > EX_TABLE(1b, 4b) \ > > > Thanks > Christophe