Re: [PATCH v6 4/5] PCI: dwc: ep: Support BAR subrange inbound mapping via Address Match Mode iATU

Niklas Cassel
2026-01-13T10:27:57Z

On Tue, Jan 13, 2026 at 11:15:42AM +0100, Niklas Cassel wrote:
> On Tue, Jan 13, 2026 at 11:37:14AM +0900, Koichiro Den wrote:
> > @@ -626,11 +831,22 @@ static const struct pci_epc_features*
> > dw_pcie_ep_get_features(struct pci_epc *epc, u8 func_no, u8 vfunc_no)
> > {
> > struct dw_pcie_ep *ep = epc_get_drvdata(epc);
> > + struct pci_epc_features *features;
> >
> > if (!ep->ops->get_features)
> > return NULL;
> >
> > - return ep->ops->get_features(ep);
> > + features = ep->ops->get_features(ep);
> > + if (!features)
> > + return NULL;
> > +
> > + /* All DWC-based glue drivers support dynamic inbound mapping */
> > + features->dynamic_inbound_mapping = true;
>
> I think you should create a separate patch, before this patch, that simply
> sets:
> features->dynamic_inbound_mapping = true;
>
> Since that is technically a different feature, independent of this
> feature, so it deserves its own patch.

The commit message for that separate patch should mention that the reason
why there are no code changes when exposing/enabling support for the
dynamic_inbound_mapping feature, is because the actual code changes to the
the DWC driver already in commit 4284c88fff0e ("PCI: designware-ep: Allow
pci_epc_set_bar() update inbound map address").

Kind regards,
Niklas