* [PATCH] powerpc/52xx/media5200: Consolidate chained IRQ handler install/remove
@ 2026-01-19 6:04 Chen Ni
2026-04-08 4:28 ` Madhavan Srinivasan
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2026-01-19 6:04 UTC (permalink / raw)
To: agust, maddy, mpe, npiggin, chleroy, jirislaby, tglx
Cc: linuxppc-dev, linux-kernel, Chen Ni
The driver currently sets the handler data and the chained handler in
two separate steps. This creates a theoretical race window where an
interrupt could fire after the handler is set but before the data is
assigned, leading to a NULL pointer dereference.
Replace the two calls with irq_set_chained_handler_and_data() to set
both the handler and its data atomically under the irq_desc->lock.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
arch/powerpc/platforms/52xx/media5200.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/52xx/media5200.c b/arch/powerpc/platforms/52xx/media5200.c
index bc7f83cfec1d..c20ac8010f6d 100644
--- a/arch/powerpc/platforms/52xx/media5200.c
+++ b/arch/powerpc/platforms/52xx/media5200.c
@@ -176,8 +176,8 @@ static void __init media5200_init_irq(void)
of_node_put(fpga_np);
- irq_set_handler_data(cascade_virq, &media5200_irq);
- irq_set_chained_handler(cascade_virq, media5200_irq_cascade);
+ irq_set_chained_handler_and_data(cascade_virq, media5200_irq_cascade,
+ &media5200_irq);
return;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/52xx/media5200: Consolidate chained IRQ handler install/remove
2026-01-19 6:04 [PATCH] powerpc/52xx/media5200: Consolidate chained IRQ handler install/remove Chen Ni
@ 2026-04-08 4:28 ` Madhavan Srinivasan
0 siblings, 0 replies; 2+ messages in thread
From: Madhavan Srinivasan @ 2026-04-08 4:28 UTC (permalink / raw)
To: agust, mpe, npiggin, chleroy, jirislaby, tglx, Chen Ni
Cc: linuxppc-dev, linux-kernel
On Mon, 19 Jan 2026 14:04:50 +0800, Chen Ni wrote:
> The driver currently sets the handler data and the chained handler in
> two separate steps. This creates a theoretical race window where an
> interrupt could fire after the handler is set but before the data is
> assigned, leading to a NULL pointer dereference.
>
> Replace the two calls with irq_set_chained_handler_and_data() to set
> both the handler and its data atomically under the irq_desc->lock.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/52xx/media5200: Consolidate chained IRQ handler install/remove
https://git.kernel.org/powerpc/c/1ef8cf10cdbe79823fd6de0f0b93ca996045d1cc
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-08 4:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-19 6:04 [PATCH] powerpc/52xx/media5200: Consolidate chained IRQ handler install/remove Chen Ni
2026-04-08 4:28 ` Madhavan Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox