Re: [PATCH 07/25] xor: split xor.h

Christoph Hellwig
2026-03-03T16:03:17Z

On Fri, Feb 27, 2026 at 08:43:55PM -0800, Eric Biggers wrote:
> On Thu, Feb 26, 2026 at 07:10:19AM -0800, Christoph Hellwig wrote:
> > Keep xor.h for the public API, and split the struct xor_block_template
> > definition that is only needed by the xor.ko core and
> > architecture-specific optimizations into a separate xor_impl.h header.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > arch/arm/lib/xor-neon.c | 1 +
> > arch/s390/lib/xor.c | 2 +-
> > include/linux/raid/xor.h | 22 +---------------------
> > include/linux/raid/xor_impl.h | 25 +++++++++++++++++++++++++
> > lib/raid/xor/xor-core.c | 1 +
> > 5 files changed, 29 insertions(+), 22 deletions(-)
> > create mode 100644 include/linux/raid/xor_impl.h
>
> arch/arm64/lib/xor-neon.c needs to be updated to include xor_impl.h.

As of this patch it is not using anything from that header (but
neither from the public xor.h).