From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86B2BFD9E1A for ; Thu, 26 Feb 2026 22:10:48 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fMQdL6hKCz3bZm; Fri, 27 Feb 2026 09:10:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=213.95.11.211 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772143846; cv=none; b=EMuno1uR13UKVbl+ogYp5ParVSbDyh01FA3yctabgjAWrcGqemXZL27NMDV8f3/a9iApBRngGaVgcInHk9K7szAXio9p5gJPX762gba7BVxczY/skoJ8u1cPD/CjWTr1NTuOI3PKySNSRPZhbntiU02UXEBZBI8g207Cg4D4j/vzak1XfZ6D23sJ+mX634lU/6PvgZ5iob3ODINRr4YF0NV6AsmsnlceJ/lHvxs3T/KCwFtN9XFBk3fp95JgjDSIxoB1AhVIPb/4JuNm8KqM8lL4zEW9ZowLT3GOWVOsAMI4yf/Nrhnjs8zJyCbx2pXNcZwZ80uKHhzlHVp6usckuQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772143846; c=relaxed/relaxed; bh=3ilvamkoK822H0OMpkLt0O2v/cHCUl9aKFe1v6Kcca4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OSJrJHMdfNg2UwLvL0+KP1/5iab7iN+0i+TrsOwEJvelqqvS6dNmfbQIgOMWHCP6FyQN+/Go5Kayt5BC0G/KcSXf+/J+61KaEzwWapv6sjFEflI3N5keisn8VU1pC6zmJzZ1umHCN68IyOdFLwcFaNVjHjPCIqJjwJUzbS6d7xYhInjDebx/PRXp3QsCYzDkhaBK1CmHTg3p3GFmM40TbmS3XiIUgWBHsuCLj/3svdH6B20xyVq7MeJifG2f9UiQyGtpIE+DiIA45pG2uJR5rikigB1d5pYF1aKfNNVp4c+BR3Zj6xBjFXnJ8LXhFQLlqtv8b6AWi+RFiVyxDJXwfw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=lists.ozlabs.org) smtp.mailfrom=lst.de Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=lists.ozlabs.org) X-Greylist: delayed 593 seconds by postgrey-1.37 at boromir; Fri, 27 Feb 2026 09:10:45 AEDT Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fMQdK73mZz2yr6 for ; Fri, 27 Feb 2026 09:10:45 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id 3731168C4E; Thu, 26 Feb 2026 23:00:39 +0100 (CET) Date: Thu, 26 Feb 2026 23:00:38 +0100 From: hch To: Richard Weinberger Cc: hch , Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , will , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , davem , Andreas Larsson , anton ivanov , Johannes Berg , Thomas Gleixner , mingo , bp , dave hansen , x86 , hpa , Herbert Xu , dan j williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha , linux-kernel , linux-arm-kernel , loongarch , linuxppc-dev , linux-riscv , linux-s390 , sparclinux , linux-um , Linux Crypto Mailing List , linux-btrfs , linux-arch , linux-raid Subject: Re: [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE Message-ID: <20260226220038.GA15172@lst.de> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-4-hch@lst.de> <445921547.2198.1772142326749.JavaMail.zimbra@nod.at> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <445921547.2198.1772142326749.JavaMail.zimbra@nod.at> User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Feb 26, 2026 at 10:45:26PM +0100, Richard Weinberger wrote: > ----- Ursprüngliche Mail ----- > > Von: "hch" > > XOR_SELECT_TEMPLATE is only ever called with a NULL argument, so all the > > ifdef'ery doesn't do anything. With our without this, the time travel > > mode should work fine on CPUs that support AVX2, as the AVX2 > > implementation is forced in this case, and won't work otherwise. > > IIRC Johannes added XOR_SELECT_TEMPLATE() here to skip > the template selection logic because it didn't work with time travel mode. > > Johannes, can you please test whether this change does not break > time travel mode? I'm pretty sure that was the intent, but as I wrote above it worked and still works on AVX-supporting CPUs by chance, and already doesn't on older CPUs, and unless my git blaming went wrong someewhere already didn't when this was originally added.