From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37DB1EB3641 for ; Mon, 2 Mar 2026 23:08:00 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fPvjV3lkXz3blq; Tue, 03 Mar 2026 10:07:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772492878; cv=none; b=LuKlzc/U/YXwl7N5BlkHUScDButh1RsJBCci04N3y/AuCDW8aK61Oqa0bFX4oE+Bsb4pDMm9wU/zAkB/CXfBd5HxCZateFRQxFkG/cyXFwLfx0LWkFb2vEFUB/YG1Po/g1FsHxEH/rMLeSf8JKA94mS9yHA+WdBJCOOi8XaPGuV88irUqIEMTf1uIvDBYrYJZv3ma3g++oAkzMdfRvk9vLFL3IvEZgr35a6mQFUE4osd5N4lgrt4Yk8zWkj/6kvbbeNFnGNr2UsKUf1gVd14GHRyx478L3OhtXjsMZ3vf/ZWj39NoqGoYFlsLz2P6E6elEngWUraOdO1w3gnD+nP3w== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772492878; c=relaxed/relaxed; bh=Zhd5/OulCnZqvzBJu9TVGp3ZIWgH85DzOCh6vSf611o=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=hzr1LKK0esXJs2yuf0ApsKpZZKOCxdv/UwUFfbc1FqTyrmiZRBm4xp71HLafbHeI05APHrdmdIqrpnjG4W22rhFnUUBdI1OzIqJPoFXdxYwySY25aQUPsX+6OGjEWT05yD2ay+T0Y0+pqk4tmefvaA58JSp7nBjZczkODSeT7at1XIVzKioYH9rKvCbVYfsOdKeo7h/B/LMzDwCTddMA5eCSf0a/HcuCIfPfvvf3H9VXECtbxNGRmRjT+eF1sul9TTn8CQMISXyA2M0xQIs+3L/1xCNth3q0E06gXM4UKgU6ZLz478k/+wqiy5H5k3bVNxufAHuJIm24nqaduIEhmA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ojWXYkOY; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ojWXYkOY; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fPvjT2dGkz30Lw for ; Tue, 03 Mar 2026 10:07:57 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id B9DE760126; Mon, 2 Mar 2026 23:07:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D773C19423; Mon, 2 Mar 2026 23:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772492874; bh=nzWc5hLi+XmBuDD+BGsrmDcYrcD7xRFj1OgmUPYza+Y=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ojWXYkOYIKhn66nudcCk8Y/GU6W3TuYnBtpvFJsKP2MnMtUbhRvAyX1WWGXRHTlkg dj0a58+jJyhag958yoJSG5aBih25/HAQPYB/SWsBk7+1gBf4tNcMwW2IF/f0WKZVrH FmsmboQmUEc+jI5i3NKgdLX84p5QHExSeRJMGYU+7j/vjoATBqnJUAqekrzVElXPL5 TfKX6Kc2DTA72Qs3MkYquLMNDmXvsndf0lmdAuV9mI36OQi8nOGT/zhzwskVfQPCCV xMRliO/w+Ea1EfUpIflOIigUDCXaBQRapBeDWEv7f2hCpVmP5cp9vQzuiBQsi3HHWE N3scqRm5dCqDg== Date: Mon, 2 Mar 2026 17:07:53 -0600 From: Bjorn Helgaas To: Nilay Shroff Cc: linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, sparclinux@vger.kernel.org, wangruikang@iscas.ac.cn, tglx@kernel.org, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, gjoyce@ibm.com, davem@davemloft.net, andreas@gaisler.com, John Paul Adrian Glaubitz , Han Gao , Nathaniel Roach , Venkat , Nam Cao Subject: Re: [PATCHv2 0/2] pci: fix msi_addr_mask on powerpc and sparc systems Message-ID: <20260302230753.GA4034944@bhelgaas> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260220070239.1693303-1-nilay@linux.ibm.com> On Fri, Feb 20, 2026 at 12:32:26PM +0530, Nilay Shroff wrote: > Hi, > > Recent changes [1] which replaced pci_dev::no_64bit_msi with pci_dev:: > msi_addr_mask inadvertently missed to initialize the pci_dev::msi_addr_mask > to the DMA_BIT_MASK(64) on powerpc platform. Due to this, later the > validation the programmed MSI address against the msi_addr_mask fails. > This causes pci device probe method failures on powerpc platform. We also > realized that similar issue could potentially happen on sparc system as > well. So this series initializes pci_dev::msi_addr_mask to DMA_BIT_MASK(64) > when pci_dev is instantiated for both powerpc and sparc platforms. > > The first patch in the series fixes this on powerpc platform. The second > patch fixes this issue on sparc platform. Please note that as I don't have > access to the sparc platform, this patch was only compile tested on the > sparc system. Anyone from the community is welcome to test it who has > access to the sparc machine. > > [1] https://lore.kernel.org/all/20260129-pci-msi-addr-mask-v4-0-70da998f2750@iscas.ac.cn/ > > Changes since v1: > - Initialize the pci_dev:msi_addr_mask on sparc platform (Vivian Wang) > - Some minor cosmetic fixes (Bjorn Helgaas) > > Nilay Shroff (2): > powerpc/pci: Initialize msi_addr_mask for OF-created PCI devices > sparc/pci: Initialize msi_addr_mask for OF-created PCI devices > > arch/powerpc/kernel/pci_of_scan.c | 7 +++++++ > arch/sparc/kernel/pci.c | 7 +++++++ > 2 files changed, 14 insertions(+) I applied both of these to pci/for-linus for v7.0 since they fix regressions. Thanks to Han and Nathaniel for testing on sparc and Venkat and Nam for testing on powerpc. Let me know if you have issues with these or prefer to merge via another tree; I'll be happy to drop. Bjorn