From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25EA0EDA697 for ; Tue, 3 Mar 2026 16:01:12 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fQLBZ4wM0z30Lw; Wed, 04 Mar 2026 03:01:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=213.95.11.211 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772553670; cv=none; b=HZajACsTj5EffxTGGivTQDKpP+LGezNI/OkeLPe+9qE02SlkGk0yZMMaNqBaM3bKybl08U2s54qXa+pJC8IJiZChoVltaTQRTjATKw1U2vVxoyaQR7tV+dWgnrKRJy9PMteSWj+/LD5XeQD8BPlhwdIn5bqWIuyLgGzEmFx6fF/AWB8Gqg8/ol+Bsm5cLbVXmrH/6BAY0MnALZb+JLjX4+YLOxNiIe23H6g/QNuKhmV1g/TSk39BTa3XPJSMFTzVglCLKV2EZuELJ/uwm6NZMKi8nJv5U24m7JlAhXiwjAg7sLS4H+ftnGvTj81D8SuJNm3HLVh5rHNo/6ZP7+71Vw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772553670; c=relaxed/relaxed; bh=Lk4PzyXylTYCrnMWAQQqmCxuYxMfjTTHimhDc4LOZko=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gqotnQ7QRV+UwiwOd8ZxhuOqv32QOHsPikNU/XR8t7GTEJNObMC29J0zq6TKdcCnb3DELzCQAac4AmIjifRkDaBLdGjAbXRmZ/J512Vl3sxXUgYakjqBTAGot5vO1N7EBcR3vbA0lYts97DpKQVOvs+VRKDk4Ri79bhGI/4ozn5JGS+H/zrDsTH7dmsjWI5s1chXPiDQUPfuRAotWr1e8mN9P7WWkTcqvZgkRQFkSZTm4P49CoYjmjrPq7pXsyyD/f4s/3MDaxaj3l9neDOdWwu5XNtvW4n6mrOWGNo/Di+8koJP+LW7w+glOTjA1T6jQFD6Y6jAignKUqPLstv4SA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=lists.ozlabs.org) smtp.mailfrom=lst.de Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=lists.ozlabs.org) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fQLBT0LJ4z2xP9 for ; Wed, 04 Mar 2026 03:01:04 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id 89BBD68BFE; Tue, 3 Mar 2026 17:00:51 +0100 (CET) Date: Tue, 3 Mar 2026 17:00:50 +0100 From: Christoph Hellwig To: Peter Zijlstra Cc: Christoph Hellwig , Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 01/25] xor: assert that xor_blocks is not called from interrupt context Message-ID: <20260303160050.GB7021@lst.de> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-2-hch@lst.de> <20260227142455.GG1282955@noisy.programming.kicks-ass.net> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260227142455.GG1282955@noisy.programming.kicks-ass.net> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Feb 27, 2026 at 03:24:55PM +0100, Peter Zijlstra wrote: > > unsigned long *p1, *p2, *p3, *p4; > > > > + WARN_ON_ONCE(in_interrupt()); > > Your changelog makes it sound like you want: > > WARN_ON_ONCE(!in_task()); > > But perhaps something like so: > > lockdep_assert_preempt_enabled(); > > Would do? That ensures we are in preemptible context, which is much the > same. That also ensures the cost of this assertion is only paid on debug > kernels. No idea honestly. The kernel FPU/vector helpers generally don't work from irq context, and I want to assert that. Happy to do whatever version works best for that.