From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0190F54ADC for ; Tue, 24 Mar 2026 16:42:28 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fgG6W2tFvz2yng; Wed, 25 Mar 2026 03:42:27 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774370547; cv=none; b=TLP6vgagwrmg98vYdXY821acLfOEq8PxkT9ogHDm7f2KD9rL5H8r1IdI1ZTkiAg2+Y3kPHDkpXikNnPtj8LZ88dZ0BuMjAjvYfOJJm06wqqqdIsHD32LX8GO8mLoP9B1kfFw0hFsraouZlRo+zFVbEneR4igzwyHSmBXt2dK50OLP6hw54GzKm8k6ECLMeioxISReq8evzOJReTQ3JWUTt5zAz67vMgb6Mj+1si2DYjCA+ooVazlyMIHptuaWNNap1NIcVCSbm3yoXZXgdiDa76aqeEGUDn6Rp0v10d6LXzCd+8GfWSp2pa1X994YrjBfbswU7Mv6h6hyOXpIX/2mw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774370547; c=relaxed/relaxed; bh=3Xek2iy9qjmWdzaaTDCJksqUsRu7KHXrr0+xwjq5P+g=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=bMXea2rDojCEE882c2lqTrTbtjMK4PLeHX50XGgmzdBrGk6oNJ3CtL0moGMhPckKEzI5aHwhOVI+6nIAj6lfz0GpuR+ktDORP9y80zAmshZx6ZCp6Qub9Gv8AttXjpP6q+P0+Pbrejbzl9WYz/Sd3odbS0Rb9lwiwdwAmVTgY7A6DtuA33PF88BNHAFdkGOWnCXtNdunSggOsi4mQk+w5TbVSNaiUDHsPRPNQM6xc8id35EroTC0oztNqp9cI+6MMev+Z9r31eFXpy4M0Nnwy5y1WIWWOatbOZcJMDlave81cCs1j0p6nD7Sw7nM+/ywg/rQQpStrYKSLwWCZYMvOw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=DQOwZZrw; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=akpm@linux-foundation.org; receiver=lists.ozlabs.org) smtp.mailfrom=linux-foundation.org Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=DQOwZZrw; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux-foundation.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=akpm@linux-foundation.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fgG6V0CSGz2ynP for ; Wed, 25 Mar 2026 03:42:25 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B7A3344260; Tue, 24 Mar 2026 16:42:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E44B6C19424; Tue, 24 Mar 2026 16:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774370542; bh=TDgLcRhij5JQVZa60QmaxqOx203j51xbjV/q4WkoTac=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DQOwZZrwl+GxIARWYI809PrjYZgIC0xfeubUvTNhKKAudWXflkBkHkOQxqHhcKfI5 YEd8AoepFJifaDz0cIKUFkW85RTTMclmIhV4gfAqh3VY34KIx4Pm4UqjUG6y+A3vml FWjY7pXOdRDrlwOVcmMMkatFHeB/Fbf82T5tVjrs= Date: Tue, 24 Mar 2026 09:42:20 -0700 From: Andrew Morton To: Christoph Hellwig Cc: Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , "Theodore Ts'o" , "Jason A. Donenfeld" , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: cleanup the RAID5 XOR library v3 Message-Id: <20260324094220.09e6eb90afc7f55937847f22@linux-foundation.org> In-Reply-To: <20260324062211.3216301-1-hch@lst.de> References: <20260324062211.3216301-1-hch@lst.de> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 24 Mar 2026 07:21:36 +0100 Christoph Hellwig wrote: > the XOR library used for the RAID5 parity is a bit of a mess right now. > The main file sits in crypto/ despite not being cryptography and not > using the crypto API, with the generic implementations sitting in > include/asm-generic and the arch implementations sitting in an asm/ > header in theory. The latter doesn't work for many cases, so > architectures often build the code directly into the core kernel, or > create another module for the architecture code. > > Changes this to a single module in lib/ that also contains the > architecture optimizations, similar to the library work Eric Biggers > has done for the CRC and crypto libraries later. After that it changes > to better calling conventions that allow for smarter architecture > implementations (although none is contained here yet), and uses > static_call to avoid indirection function call overhead. Thanks, I've updated mm.git's mm-nonmm-unstable branch to this version of the patchset.