Re: [PATCH 02/17] raid6: remove __KERNEL__ ifdefs

Christoph Hellwig
2026-03-26T05:25:47Z

On Wed, Mar 25, 2026 at 12:58:21PM -0700, Eric Biggers wrote:
> While I do like developing code in userspace as well, I've been doing it
> less over time as the kernel's tests and benchmarks have been improved.
> Running the KUnit tests is pretty straightforward and fast.

Yes. I would have totally subscribed to hpa's position when he initially
wrote the code, but 20+ years later things look different. In fact these
days I often write code intended for userspace in the kernel first to
benefit from lockdep primarily, but also other checkers that are in theory
available in userspace but as easy to use. Now of course lockdep doesn't
really matter for the algorithms here, but the rest still stands.

I also find the point of developing new code for new platforms
interesting: in this decade we had two new platforms added: loongarch
and riscv and all other changes were to the wiring up and not the
algorithms. And of those riscv only had the compile in userspace
support added 8 month after the algorithm, so it doesn't really look
like development was aided by it. We also plan to add new optimized
code, and getting the library in shape and dropping the hard to
maintain userspace code is actually prep work for making that not
painful.

>
> The issues with providing userspace build support in the tree are that:
>
> - It has to be maintained.
> - It's fundamentally a bit of a hack that is used only by developers
> (who always have the option of doing something locally that is
> tailored to the specific function they're working on)
> - It diverts effort from the kernel's actual test and benchmark.
>
> So while the faster iteration speed that userspace development enables
> is definitely nice, I do think we should be cautious with committing to
> maintain it in the kernel tree. If it's causing problems for the
> ongoing refactoring, dropping it for now seems reasonable to me.
>
> I would suggest adding a benchmark to the KUnit test similar to the
> crypto and CRC ones, though.

The code already has a benchmark used for runtime selection, although
that could be improved on and run for bigger data sets from kunit.