From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 950E310F2861 for ; Fri, 27 Mar 2026 17:50:01 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fj7T41ctFz2xmX; Sat, 28 Mar 2026 04:50:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774633800; cv=none; b=F4hCnXaBZMa92H9XPhcZrLuV/Ya18f+sPr4EqVf+atVQYjjQTkXGAcmRwM+iYtwZEwTdfm3aAYYVWrIggHRfJQM9uuK7mIar/reGKBCUr9e0a/UvrqZ7NbDpVkTNH9Vq8/u9CtSpzVM/GIqFbnMVc5N+V1EK4IXD8c/y4eGLoNGjF0T93XDydT/Yc23tVYNrqckji3k5ePezW0cwGPK0AMEG+hjntBj0vUxJt18tXCiTkkGkqWldcCvzxebCzbdZztXzTngaBAbQFuYzL60dlk9vI39eyxC58JTBd8t/Q46XqCPwLhHM2rcSmKjbh271PZNpQD07X39Fnc6cW2R7aA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774633800; c=relaxed/relaxed; bh=00xs7oJV5RcNzaRyZmUSWqyrA7BLMepeqCZWgGFrmnc=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=ITrKaA603PJw59NaNH1ruKqJGmy7fVQ7se9EJGzriRznLl16jVy9QUoizd8fy9TMzsefgn4qZodNkOse7sxznQX7QBCio+eAFPAp3Dz6NWvqVLhTa8EGgAVobvvIoYXkQkN6nvyeEq+sppbPuYZeNd7Kc8u6brg2bntEJS3ff0BD7tzv7pRZYmXyESMflsHYgTSSKTUR0oXH6R1GuJo6rz0mrFAAX0XmZ8mKgPNOtyRyH9c1bUsMMbqBzsV02XfuOqaB4lbPU9+xAyRvLrVB5auByJ5S29OXBLYk5y4vlSkurcnOqC1Vwj2YGrM2jGqOwHSvbs1M3q455LEeA7wP7g== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=Xukem7pw; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=akpm@linux-foundation.org; receiver=lists.ozlabs.org) smtp.mailfrom=linux-foundation.org Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=Xukem7pw; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux-foundation.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=akpm@linux-foundation.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fj7T30zySz2xQr for ; Sat, 28 Mar 2026 04:49:58 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D192860054; Fri, 27 Mar 2026 17:49:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D99ECC19423; Fri, 27 Mar 2026 17:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774633795; bh=fvV+eUnldLQbPdva1eQggufDFhZTLIQCCYJJa9ryFGE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Xukem7pwvHhzUBxAXhQ9NUugrvHjO83NuPglCq+AOxMC7jcj5knJ1iWiLSA3qMyPR XN8WgX2Ez7pjNH1P4TD8C2yL80THz5zSN5msmXHHVRwpdESPm9OS0FEtlzvOIU70KT MQ9zvWTqdnQj4+10/Ab7Ocs563lJZMmYcKdIZNc0= Date: Fri, 27 Mar 2026 10:49:53 -0700 From: Andrew Morton To: Christoph Hellwig Cc: Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , "Theodore Ts'o" , "Jason A. Donenfeld" , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: cleanup the RAID5 XOR library v4 Message-Id: <20260327104953.b91d7a4a71b1c1cd202e5a1c@linux-foundation.org> In-Reply-To: <20260327061704.3707577-1-hch@lst.de> References: <20260327061704.3707577-1-hch@lst.de> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 27 Mar 2026 07:16:32 +0100 Christoph Hellwig wrote: > the XOR library used for the RAID5 parity is a bit of a mess right now. > The main file sits in crypto/ despite not being cryptography and not > using the crypto API, with the generic implementations sitting in > include/asm-generic and the arch implementations sitting in an asm/ > header in theory. The latter doesn't work for many cases, so > architectures often build the code directly into the core kernel, or > create another module for the architecture code. > > Changes this to a single module in lib/ that also contains the > architecture optimizations, similar to the library work Eric Biggers > has done for the CRC and crypto libraries later. After that it changes > to better calling conventions that allow for smarter architecture > implementations (although none is contained here yet), and uses > static_call to avoid indirection function call overhead. Thanks, I've updated mm.git's mm-nonmm-unstable to this version of the patchset.