Re: [PATCH 12/20] alpha/PCI: Use PCI resource accessor macros

Krzysztof Wilczyński
2026-04-10T11:27:21Z

Hello,

> > - if (pdev->resource[num].flags & IORESOURCE_MEM) {
> > + if (pci_resource_flags(pdev, num) & IORESOURCE_MEM) {
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> I started wonder though if we'd want to add pci_resource_is_mem/io()
> shortcuts for these, as it's largely what
>
> git grep pci_resource_flags
>
> results contain.

I see what you mean... We can introduce such helpers here, and be the first
users within the PCI tree, that is, before someone will do a tree-wide or some
more granular update eventually.

Should I do it? Thoughts?

Thank you!

Krzysztof