Re: [PATCH 19/20] PCI/sysfs: Convert legacy I/O and memory attributes to static definitions

Krzysztof Wilczyński
2026-04-10T12:05:05Z

Hello,

> > +static const struct bin_attribute pci_legacy_mem_sparse_attr = {
> > + .attr = { .name = "legacy_mem_sparse", .mode = 0600 },
> > + .size = 0x100000 << 5,
>
> I suggest naming these legacy literals with defines. At least the mem one
> could also use SZ_1M:
>
> #define PCI_LEGACY_MEM_SIZE SZ_1M

Sounds good. Will do.

Thank you!

Krzysztof