From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24FDCF8D763 for ; Thu, 16 Apr 2026 18:02:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fxQnh3CqWz3bjg; Fri, 17 Apr 2026 04:02:00 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776362520; cv=none; b=dsAp1vs9QQTWOviR6crXvQBc3767OWFe18P1WRWSobLnjdkJt3fQxoEZNIMLDk8XBDiF3roPSNR6x/7YgrHldKEKWiU0Wr97kg1Yx8rlp+sqqPxPMXuxe36Lr8vf7cajVCopMrGvAd1h/NG/3zze2BL0ksC8MARBa+POO1f2lEMJNBl6a97EtMF5ctaOf5N/xe4WUBZt1Wva+iCKEXKQPz0MnEhOwwhT4eQuHZKcDgBsnwusqQPbaENAM69INPoVIJ3M2yu2zozIapH30DtPnk6VHGOicZq6a9g968ZCLVXANW8JttBi+ZmPypNi0vmVeWvDmVGF+BjEUS9O3ThYhA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776362520; c=relaxed/relaxed; bh=O+demXVb/7u4PctkTwvU5TG82BsX3vOBjADpfyuGQC0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QNi5Q/nR1m85q0c/Ux77AL0vQ0qwPP1O09QjZuLqvNg8ZKcZ2fL2taaakDE4sVlBKBu7tY8iliKdBE4liqRzhG3uyL1J4q3VsoAdoA0HmtRIowrc9QrgY6KeLde69wcr30dSMQ9pf/pYxVV1l4LYL+6qzp8b9uarl2tvYQRTydCEeAqpCHlOlhtqFbj9UDdLIqUtxi+5ZTzUgTDgdStWjN+cQZvRyv+BxogTnbw2hRepPmRZk0G9bEozc0mDdcohYWcKeowqp8/+ylPb3HrJ5yGxbyqqKB3jZgavq1f1LCqAJHU3lUgHCDLocDpV4k6IQ0ZPwmJ1iqiRTht7FxbhWA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=hxnW1p0u; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=hxnW1p0u; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fxQng3hPkz2yYK for ; Fri, 17 Apr 2026 04:01:59 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E565840E36; Thu, 16 Apr 2026 18:01:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98A7FC2BCAF; Thu, 16 Apr 2026 18:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776362517; bh=RnJpCjE7Q+Cz5gLfhuPI4aXF0NyoVhuEIoGAkwXA5ZA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hxnW1p0urI+O5qr7Z0zglyRfAGglr5AQy/cTAcaAtUydpguea4iMqz7RjmIQIWNSY 0S+TKPVcajwNcZzLcEDVLzIwtX1teKHFma8LBaEvdx5ADxIRv6o5PdapwoaTw/NKA2 Oc+zk5ZBIYYMZESrMEhUAiQR4rsYwRuivpP3pYFlI0NUZux9FWSoFAX2BApZymhtmp CHYRmcg/0xY+esHsSNvlexQwe9HlYawEw3kzdGXQhRiptZ2WfHnO8wox8fcXcr/Pyw X8R/01q579lXQo7roXSXblbysmXdbqkklexcb9436dDST9M3vS5pJO08Py4BJ3RRMM C7ZZYLuiXD0yQ== From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Cc: Bjorn Helgaas , Manivannan Sadhasivam , Lorenzo Pieralisi , Magnus Lindholm , Matt Turner , Richard Henderson , Christophe Leroy , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Dexuan Cui , =?UTF-8?q?Krzysztof=20Ha=C5=82asa?= , Lukas Wunner , "Oliver O'Halloran" , Saurabh Singh Sengar , Shuan He , Srivatsa Bhat , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH v5 13/23] alpha/PCI: Use PCI resource accessor macros Date: Thu, 16 Apr 2026 18:00:57 +0000 Message-ID: <20260416180107.777065-14-kwilczynski@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260416180107.777065-1-kwilczynski@kernel.org> References: <20260416180107.777065-1-kwilczynski@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace direct pdev->resource[] accesses with pci_resource_n(), and pdev->resource[].flags accesses with pci_resource_flags(). Also, replace open-coded res->flags type checks with new pci_resource_is_mem() and pci_resource_start() helpers. While at it, move the pci_resource_n() call directly into pcibios_resource_to_bus() and drop the local struct resource pointer. No functional changes intended. Tested-by: Magnus Lindholm Reviewed-by: Ilpo Järvinen Acked-by: Magnus Lindholm Signed-off-by: Krzysztof Wilczyński --- arch/alpha/kernel/pci-sysfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c index 2330ab84d59c..5c29f1d2821c 100644 --- a/arch/alpha/kernel/pci-sysfs.c +++ b/arch/alpha/kernel/pci-sysfs.c @@ -70,7 +70,6 @@ static int pci_mmap_resource(struct kobject *kobj, { struct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj)); int barno = (unsigned long)attr->private; - struct resource *res = pci_resource_n(pdev, barno); enum pci_mmap_state mmap_type; struct pci_bus_region bar; int ret; @@ -79,15 +78,16 @@ static int pci_mmap_resource(struct kobject *kobj, if (ret) return ret; - if (res->flags & IORESOURCE_MEM && iomem_is_exclusive(res->start)) + if (pci_resource_is_mem(pdev, barno) && + iomem_is_exclusive(pci_resource_start(pdev, barno))) return -EINVAL; if (!__pci_mmap_fits(pdev, barno, vma, sparse)) return -EINVAL; - pcibios_resource_to_bus(pdev->bus, &bar, res); + pcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, barno)); vma->vm_pgoff += bar.start >> (PAGE_SHIFT - (sparse ? 5 : 0)); - mmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io; + mmap_type = pci_resource_is_mem(pdev, barno) ? pci_mmap_mem : pci_mmap_io; return hose_mmap_page_range(pdev->sysdata, vma, mmap_type, sparse); } @@ -141,7 +141,7 @@ static int sparse_mem_mmap_fits(struct pci_dev *pdev, int num) long dense_offset; unsigned long sparse_size; - pcibios_resource_to_bus(pdev->bus, &bar, &pdev->resource[num]); + pcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, num)); /* All core logic chips have 4G sparse address space, except CIA which has 16G (see xxx_SPARSE_MEM and xxx_DENSE_MEM @@ -181,7 +181,7 @@ static int pci_create_attr(struct pci_dev *pdev, int num) suffix = ""; /* Assume bwx machine, normal resourceN files. */ nlen1 = 10; - if (pdev->resource[num].flags & IORESOURCE_MEM) { + if (pci_resource_is_mem(pdev, num)) { sparse_base = hose->sparse_mem_base; dense_base = hose->dense_mem_base; if (sparse_base && !sparse_mem_mmap_fits(pdev, num)) { -- 2.53.0