Re: [PATCH] powerpc/fadump: Add timeout to RTAS busy-wait loops

litaliano00
2026-04-13T21:37:48Z

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

On Mon, Apr 13, 2026, 15:50 Sourabh Jain <sourabhjain@linux.ibm.com> wrote:

> > What is the rationale behind choosing a 60-second limit?

> The 60-second value was chosen somewhat arbitrarily. Looking at

rtas_busy_delay_time(), the maximum single delay returned is 100000ms

(status 9905). In practice, legitimate busy delays are expected to be

much shorter. I was following the spirit of rtas-rtc.c which uses a

5-second limit for simpler operations; fadump is a heavier firmware

operation, so I went higher. I am open to suggestions on a more

principled value.

> > Would it make sense to introduce a helper function to wrap the

> rtas_call, along with handling the wait time and timeout?

> Absolutely, I will introduce a helper in v2. The three sites are

indeed identical except for the FADUMP_REGISTER/UNREGISTER/INVALIDATE

argument and the struct pointer/size. I will factor out the common

busy-wait loop into a static helper.

> Will send v2 shortly from my new email adri.vero.dev@gmail.com

> Adriano

[-- Attachment #2: Type: text/html, Size: 3699 bytes --]