From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C91EFA1FC7 for ; Wed, 22 Apr 2026 16:16:22 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4g147h3k6Lz2yvK; Thu, 23 Apr 2026 02:15:12 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776874512; cv=none; b=dO4PDkIvt6tDl/BUfOPs64XyoYSA7hsvq0NRsmJrl1oSJs8TfZMSrxjTW4UBnq5/GmQjszYf8xBgCMHW7dhx/f6FDw985zwofw/bGgWRamhqzm/r3hySvcQOHjZEt1dx8OdLzzq6bM4kfGMwDggmvGK2E8SkwCTxFkDq5sei9tTzSRGeEqNn5jtTNeSWbqI7Hf7wcaaTpor58jE1W8hSOO2KWC6jC9UmDKYQaIgEc2bC0x/IBpPWijhZOfNp8HHvfPnmHeWubgW1EQ4K0WIXxPob3kMtHNlqei3ibhcjl2It8mjC1STsJVCnedOuPsmIoNJA9U5zoii2B94OYmUcGQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776874512; c=relaxed/relaxed; bh=L/iGvCQaA9qwDSTkGglYxgrDUqUE3gdjBi73L6ACtVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TIYPUmYamVBwnE3eT8Ct143JDZ1BGKWz8vTUkN1MJ9/6iu28sNH9XvaiDv/VEDqfgWdJARFfLVieJMiIEwuLfAXKOeMf1EA7pEb/dlhahhZnrYDisP7dBgckd4Z77TVIly1t+QQ6DfUAaBWmchG0cWgWmeQICpTCUvOtRCGuf3EZqoYvFkVe0SNDfWxi2xWL55BqhIEs1LOXcC/ykA+x4DqZpNMgQerakUU5uFuecqu13JnAreDNfp4FBNLIJAEyzBibq50mT+GokDKb8yBVmYCcf7yXAhPj1jtTKCXGR7Y9LwtKzeJfl3btnk8YrrPsxavEsr3eVMU0gBay24feWg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Kjky3Qp8; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Kjky3Qp8; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4g147Y5VWJz2yr9 for ; Thu, 23 Apr 2026 02:15:05 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 40BC6439B1; Wed, 22 Apr 2026 16:15:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1AA7C2BCB7; Wed, 22 Apr 2026 16:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776874504; bh=ltS0CwScmU/7W/k23zstFp4KU0BXOTAMQrPkEPzvQfw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kjky3Qp8t/knDHFwKUrhkLsr0qZD1jVYl/+BCV7F+W+jC/KDfwIwNzz29ILZHaA/C HZ5KEAOYmSea9bjuLxdcD6qsHryQtfiMSRnZW4RGtftLFRVvSXoTxjmWCpIqM00eXN prkYb78V/oaGACAGNylcOckDGDBsVR8VBuRQ3yPD2nqO++JbVa9lR0XtwV//dlwZap HwEm989HL8MTZdSEG0sOgYUO4VgUrf3T+emm9Efr8j2hn9lGoPYEm1PP2ykvChmDKo 04nJU4mKd3V6C8Zgg05BljN42NfWYNuvT2p4E0YZiPa8BeMN47WCr696udq7NFuadi gDZw9G9IBljag== From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Cc: Bjorn Helgaas , Manivannan Sadhasivam , Lorenzo Pieralisi , Magnus Lindholm , Matt Turner , Richard Henderson , Christophe Leroy , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Dexuan Cui , =?UTF-8?q?Krzysztof=20Ha=C5=82asa?= , Lukas Wunner , "Oliver O'Halloran" , Saurabh Singh Sengar , Shuan He , Srivatsa Bhat , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH v6 15/24] alpha/PCI: Remove WARN from __pci_mmap_fits() Date: Wed, 22 Apr 2026 16:13:58 +0000 Message-ID: <20260422161407.118748-16-kwilczynski@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260422161407.118748-1-kwilczynski@kernel.org> References: <20260422161407.118748-1-kwilczynski@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the WARN() that fires when userspace attempts to mmap beyond the BAR bounds. The check still returns 0 to reject the mapping, but the warning is excessive for normal operation. A similar warning was removed from the PCI core in the commit 3b519e4ea618 ("PCI: fix size checks for mmap() on /proc/bus/pci files"). Tested-by: Magnus Lindholm Reviewed-by: Ilpo Järvinen Acked-by: Magnus Lindholm Signed-off-by: Krzysztof Wilczyński --- arch/alpha/kernel/pci-sysfs.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c index 8802f955256e..f2ee737c588c 100644 --- a/arch/alpha/kernel/pci-sysfs.c +++ b/arch/alpha/kernel/pci-sysfs.c @@ -48,13 +48,7 @@ static int __pci_mmap_fits(struct pci_dev *pdev, int num, start = vma->vm_pgoff; size = ((len - 1) >> (PAGE_SHIFT - shift)) + 1; - if (start < size && size - start >= nr) - return 1; - WARN(1, "process \"%s\" tried to map%s 0x%08lx-0x%08lx on %s BAR %d " - "(size 0x%08lx)\n", - current->comm, sparse ? " sparse" : "", start, start + nr, - pci_name(pdev), num, size); - return 0; + return start < size && size - start >= nr; } /** -- 2.54.0