Re: [PATCH v6 00/24] PCI: Convert all dynamic sysfs attributes to static

Bjorn Helgaas
2026-04-23T18:24:06Z

On Fri, Apr 24, 2026 at 02:22:00AM +0900, Krzysztof Wilczyński wrote:
> Hello,
>
> > This series converts every dynamically allocated PCI sysfs attribute to
> > a static const definition. After the full series, pci_sysfs_init() and
> > sysfs_initialized are gone, and every sysfs file is created by the
> > driver model at device_add() time.
>
> A note on testing:
>
> 0-day bot (recent test runs; newer builds will arrive later):
> - https://lore.kernel.org/linux-pci/202604231622.DgR0zih3-lkp@intel.com
> - https://lore.kernel.org/linux-pci/202604161928.DzuHQmeM-lkp@intel.com
> - https://lore.kernel.org/linux-pci/202604121312.sF0Ua4gP-lkp@intel.com
> - https://lore.kernel.org/linux-pci/202604111631.lrwAylMM-lkp@intel.com
> - https://lore.kernel.org/linux-pci/202603170336.zSLrDvlj-lkp@intel.com
> - https://lore.kernel.org/linux-pci/202603122052.tMV5rzNq-lkp@intel.com
> - https://lore.kernel.org/linux-pci/202603081334.b91RGVS6-lkp@intel.com
> - https://lore.kernel.org/linux-pci/202603060207.pnGfKgGa-lkp@intel.com
>
> KernelCI (for the "for-kernelci" branch):
> - https://dashboard.kernelci.org/tree/linux-pci/for-kernelci/941dd7c3e16840724dc961f10b84e193d13cdb57
> - https://dashboard.kernelci.org/tree/linux-pci/for-kernelci/683e66b11da157f730101f6919c7468a09cf3e3f
> - https://dashboard.kernelci.org/tree/linux-pci/for-kernelci/209e2cfd205a8aad4bae32e6f82b96b20902aa74
> - https://dashboard.kernelci.org/tree/linux-pci/for-kernelci/70293477e2c0ae8cbc250098818e726e1d658b53
> - https://dashboard.kernelci.org/tree?ts=pci
>
> Sashiko's feedback:
> - https://sashiko.dev/#/patchset/20260422161407.118748-1-kwilczynski%40kernel.org
> - https://sashiko.dev/#/patchset/20260416180107.777065-1-kwilczynski%40kernel.org
> - https://sashiko.dev/#/patchset/20260411080148.471335-1-kwilczynski%40kernel.org
> - https://sashiko.dev/#/patchset/20260410055040.39233-1-kwilczynski%40kernel.org

Thanks for all this work! I think this will be a great step forward.
I assume you've probably looked at the sashiko feedback and concluded
that no changes are needed, e.g., the feedback is out of scope for
this series? Your thoughts there would help me out.

> I sadly do not own any Alpha or PowerPC hardware, so when I was testing
> these architectures while working on the series, it would be only under
> QEMU.
>
> That said, Magnus Lindholm was able to test the series on the Alpha
> hardware he owns, see:
>
> - https://lore.kernel.org/linux-pci/CA+=Fv5Q1tZQwnanw99NbvzT-QenfYz7vUdY02_TuPqHX32ZAiA@mail.gmail.com
>
> Lorenzo Pieralisi did some testing reported outside the mailing list (we
> talked on IRC), on the platform he had issues before, and while the issues
> were more with procfs races, similar to the sysfs ones this series aims to
> fix, he didn't notice regressions when having this series applied.
>
> Thank you!
>
> Krzysztof