public inbox for linuxppc-dev@ozlabs.org
 help / color / mirror / Atom feed
From: Pengpeng Hou <pengpeng@iscas.ac.cn>
To: Sourabh Jain <sourabhjain@linux.ibm.com>,
	Christophe Leroy <chleroy@kernel.org>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Hari Bathini <hbathini@linux.ibm.com>,
	Jiri Bohac <jbohac@suse.cz>,
	Shrikanth Hegde <sshegde@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	pengpeng@iscas.ac.cn
Subject: Re: [PATCH] powerpc/fadump: reject empty bootargs_append writes
Date: Fri, 24 Apr 2026 06:51:23 +0800	[thread overview]
Message-ID: <20260424070108.1-fadump-drop-pengpeng@iscas.ac.cn> (raw)
In-Reply-To: <20260417073907.4985-1-pengpeng@iscas.ac.cn>

Hi Sourabh, Christophe,

Thanks for checking this.

I rechecked the current sysfs write path and I no longer think this
patch is valid. sysfs_kf_write() returns 0 before calling ->store() when
count is 0, so I do not have a path that reaches bootargs_append_store()
with count == 0.

Also, if such a path did exist, returning 0 would be the right behavior
for an empty write, not -EINVAL.

I'll drop this patch.

Thanks,
Pengpeng




      parent reply	other threads:[~2026-04-23 22:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17  7:39 [PATCH] powerpc/fadump: reject empty bootargs_append writes Pengpeng Hou
2026-04-17  7:53 ` Christophe Leroy (CS GROUP)
2026-04-17  9:30 ` Sourabh Jain
2026-04-23 22:51 ` Pengpeng Hou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260424070108.1-fadump-drop-pengpeng@iscas.ac.cn \
    --to=pengpeng@iscas.ac.cn \
    --cc=chleroy@kernel.org \
    --cc=hbathini@linux.ibm.com \
    --cc=jbohac@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=sourabhjain@linux.ibm.com \
    --cc=sshegde@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox