From: Johan Hovold <johan@kernel.org>
To: Geoff Levand <geoff@infradead.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <chleroy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 1/3] powerpc/ps3: switch to dynamic system bus root device
Date: Fri, 24 Apr 2026 12:36:02 +0200 [thread overview]
Message-ID: <20260424103604.2616657-2-johan@kernel.org> (raw)
In-Reply-To: <20260424103604.2616657-1-johan@kernel.org>
Driver core expects devices to be dynamically allocated and will, for
example, complain loudly if a device that lacks a release function
is ever freed.
Use root_device_register() to allocate and register the root device
instead of open coding using a static device.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
arch/powerpc/platforms/ps3/system-bus.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/platforms/ps3/system-bus.c b/arch/powerpc/platforms/ps3/system-bus.c
index 0537a678a32f..4ead6ccea259 100644
--- a/arch/powerpc/platforms/ps3/system-bus.c
+++ b/arch/powerpc/platforms/ps3/system-bus.c
@@ -20,9 +20,7 @@
#include "platform.h"
-static struct device ps3_system_bus = {
- .init_name = "ps3_system",
-};
+static struct device *ps3_system_bus;
/* FIXME: need device usage counters! */
static struct {
@@ -486,8 +484,8 @@ static int __init ps3_system_bus_init(void)
mutex_init(&usage_hack.mutex);
- result = device_register(&ps3_system_bus);
- BUG_ON(result);
+ ps3_system_bus = root_device_register("ps3_system");
+ BUG_ON(IS_ERR(ps3_system_bus));
result = bus_register(&ps3_system_bus_type);
BUG_ON(result);
@@ -744,7 +742,7 @@ int ps3_system_bus_device_register(struct ps3_system_bus_device *dev)
static unsigned int dev_lpm_count;
if (!dev->core.parent)
- dev->core.parent = &ps3_system_bus;
+ dev->core.parent = ps3_system_bus;
dev->core.bus = &ps3_system_bus_type;
dev->core.release = ps3_system_bus_release_device;
--
2.53.0
next prev parent reply other threads:[~2026-04-24 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 10:36 [PATCH 0/3] powerpc: switch to dynamic root devices Johan Hovold
2026-04-24 10:36 ` Johan Hovold [this message]
2026-04-24 10:36 ` [PATCH 2/3] powerpc/pseries: switch to dynamic ibmebus root device Johan Hovold
2026-04-24 10:36 ` [PATCH 3/3] powerpc/pseries: clean up ibmebus printks Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424103604.2616657-2-johan@kernel.org \
--to=johan@kernel.org \
--cc=chleroy@kernel.org \
--cc=geoff@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox