From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A6D1CCFA13 for ; Fri, 1 May 2026 14:54:59 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4g6Ywy4zNmz30Bd; Sat, 02 May 2026 00:54:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777647298; cv=none; b=VkUzWJvWHgbckpPxhXe5oGCBjhTfdDvmhFtXDM+yMIdZdiTfITelm7TqxoWhYXqYrjj4zIKCcJgIO4EoiR/V/UHxVpnRov3tEtYrvmqwSjv3Q3nNV5y9mY6sEm2Ukk1rQLq3k3ROLmRFuPcJyoddTiEIqVuo0dArlK8l/pAkdoerTVgYKhAoKnbezJXVe703ofqQPGoq0grcCPlp2HaGea/yEivQwoZOtYuQv4BPxTjmH/qPkXuDJVBxxtv1/hRdOJXb3f5kySJc4Hmu2gE52bCYZyg/SC37f2g1OIqYUgriULJvdWkTFZhw8e6mKXOi4Q4TjpiLBdKddvTeLnrF1A== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777647298; c=relaxed/relaxed; bh=kuHqVdlej+Yn0HOXIpjPZZdn1xMOEqKbsgmm1UXRwMU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=FZ0L0nBsfehXGjqAfNaERlqGVPJKXw/wq5YOInXopU+eEuVx/R0nBPEJdXeu+XKA8RCEMgZxmAr6ZVRIJtqDTV1B9hek99f1kNGz+uPuAihXVknyiPLWnsfCaVSkeG7CK+Ffx8ikqFOb9lDVtPD0orvHp3WhXT/5WLJaBowCpFIl7CJd/jo1JJIDK2PF74L/idt7tPiYU6u2GD9NLOh5WQyOdCZhpF6tABqjSg5Yeo/3PhzsTdEFMxY79kaeQnPY6owYUHjba0NAGH4HDIApbaF51bnPrB00lw+UeebbeD0AJykIDShHTs8KsxhM5JLmw8B4NwoZ/cxaxw1c8evNnw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=SBYRZ9S3; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=atrajeev@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=SBYRZ9S3; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=atrajeev@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4g6Ywx477Pz309S for ; Sat, 02 May 2026 00:54:56 +1000 (AEST) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6415ZO4o3232750; Fri, 1 May 2026 14:54:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=kuHqVdlej+Yn0HOXIpjPZZdn1xMOEqKbsgmm1UXRw MU=; b=SBYRZ9S3cwCc+ijcXzzUkgUoDzR4d3nHzz9VHawxk6E8hBaY32/8yUWZJ icIR5Zizr8QMY7U8XHw7rScLDVD2zYaXmQXTZ7wAfJlO9Ml+iF07wtoP7Z3Lqas1 1Rf/2LyZQq1wce+bM6YvLmRpU/KmAVDQKxVUxiz4Kc18D8VOy2IRW3MlSJjFBhoo CFG0GgUuqOwlNCMl+fB/uKjXz7LLsd0ZjXdWkdGWguQo5vMH7DhOFssVaSefeP6Z 8ypDi1agFNiHBaZOODfhGWmr02OLsf0secMtfju1xAGFOipEVMBbUim1dsBsN8U0 BnU4Ix9vl3o0sni/Y6HgHSOQQVISQ== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drk1k39ej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 May 2026 14:54:50 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 641ErnDj015289; Fri, 1 May 2026 14:54:49 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4ds7xqr056-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 May 2026 14:54:49 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 641EskPw27918840 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 May 2026 14:54:46 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F1B0420043; Fri, 1 May 2026 14:54:45 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8013520040; Fri, 1 May 2026 14:54:39 +0000 (GMT) Received: from localhost.localdomain (unknown [9.39.19.167]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 1 May 2026 14:54:39 +0000 (GMT) From: Athira Rajeev To: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com, irogers@google.com, namhyung@kernel.org Cc: linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, atrajeev@linux.ibm.com, hbathini@linux.vnet.ibm.com, Tejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com, shivani@linux.ibm.com Subject: [PATCH V2 1/2] powerpc tools perf: Initialize error code in auxtrace_record_init function Date: Fri, 1 May 2026 20:24:35 +0530 Message-Id: <20260501145436.1327-1-atrajeev@linux.ibm.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTAxMDE0NCBTYWx0ZWRfXzw7Kyx3OOjLu GQeUXRnJ6nu6bW0s/Mykpu0fhIqoAC36qPa9GpWQ4ADRf/QJ5KcRCMiWlAEVOk+7fMVFHq55w05 2Kb660OGsup3VT00U7tkqsYtDD1hrCgEG6VE931M3C5zWWQshV6ux4mkHeLTpJjoztrBwh+1Z+w 5v4d9lNJYq7fhZn6GdWYZqotcaMDMSiIpaceepzdsFkzGabaZ+7ZTtmnXeMRny+16G77l45LZ+A UFlC8wZgy8tL4YppsA2mqFWyNWF1VQbzGDMV0qO6CSHbxfQqmI5It3+X20ZBImXrcv+4xyXgwz4 P6sh9pyrBZo7jtj39V6QlI6rH1mFTJn+LNh+F3sD8JPQP48T1rW/IxNe47Gojc+QCBomStMPKaL xl23mu6GVCMEmX6cHgT7OlMIlVur1KQmU4T2U/8IrMJMZY5T5BFlrtsqQto2CbzhR8A54J7AP1M H/Gw2KqoxFv3vKUNJUw== X-Proofpoint-GUID: HIVe6_rP_G6RzeSe3zHGvRG6kq2VIf2S X-Proofpoint-ORIG-GUID: wYbumdJK_kxEKnTysEdaOU5mWy_afGsX X-Authority-Analysis: v=2.4 cv=MohiLWae c=1 sm=1 tr=0 ts=69f4beba cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=UYfmDeaf6v5XVjAx5qsA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-01_04,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 spamscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605010144 perf trace record fails some cases in powerpc # ./perf test "perf trace record and replay" 128: perf trace record and replay : FAILED! # ./perf trace record sleep 1 # echo $? 32 This is happening because of non-zero err value from auxtrace_record__init() function. static int record__auxtrace_init(struct record *rec) { int err; if ((rec->opts.auxtrace_snapshot_opts || rec->opts.auxtrace_sample_opts) && record__threads_enabled(rec)) { pr_err("AUX area tracing options are not available in parallel streaming mode.\n"); return -EINVAL; } if (!rec->itr) { rec->itr = auxtrace_record__init(rec->evlist, &err); if (err) return err; } Here "int err" is not initialised. The code expects "err" to be set from auxtrace_record__init() function. Update auxtrace_record__init() in arch/powerpc/util/auxtrace.c to clear err value in the beginning. - Clear err value in beginning of function. Any fail later will set appropriate return code to err. - Even if we haven't found any event for auxtrace, perf record should continue for other events. NULL return will indicate that there is no auxtrace record initialized. - Not having "err" set here will affect monitoring of other events also because perf record will fail seeing random value in err. Set err to -EINVAL before invoking auxtrace_record__init() in builtin-record.c With the fix, # ./perf trace record sleep 1 [ perf record: Woken up 2 times to write data ] [ perf record: Captured and wrote 0.033 MB perf.data (228 samples) ] Fixes: 1dbfaf94cf66 ("perf powerpc: Add basic CONFIG_AUXTRACE support for VPA pmu on powerpc") Signed-off-by: Athira Rajeev --- Changelog: v1 -> v2 Addressed review comment from Adrian: - Set err to -EINVAL before invoking auxtrace_record__init() in builtin-record.c - Added kernel-doc to auxtrace_record__init() in tools/perf/util/auxtrace.c Addressed review comment from Namhyung: - Added fixes tag tools/perf/arch/powerpc/util/auxtrace.c | 6 ++++++ tools/perf/builtin-record.c | 1 + 2 files changed, 7 insertions(+) diff --git a/tools/perf/arch/powerpc/util/auxtrace.c b/tools/perf/arch/powerpc/util/auxtrace.c index e39deff6c857..4600a1661b4f 100644 --- a/tools/perf/arch/powerpc/util/auxtrace.c +++ b/tools/perf/arch/powerpc/util/auxtrace.c @@ -71,6 +71,12 @@ struct auxtrace_record *auxtrace_record__init(struct evlist *evlist, struct evsel *pos; int found = 0; + /* + * Set err value to zero here. Any fail later + * will set appropriate return code to err. + */ + *err = 0; + evlist__for_each_entry(evlist, pos) { if (strstarts(pos->name, "vpa_dtl")) { found = 1; diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 4a5eba498c02..708825747af5 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -865,6 +865,7 @@ static int record__auxtrace_init(struct record *rec) } if (!rec->itr) { + err = -EINVAL; rec->itr = auxtrace_record__init(rec->evlist, &err); if (err) return err; -- 2.47.3