From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EFD3CD5BAA for ; Thu, 21 May 2026 08:37:16 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gLhbt6L9Fz2xYh; Thu, 21 May 2026 18:37:14 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1779352634; cv=none; b=m4q5Zg8dWALpybWS25LhJoE7ne2ZamX9oVFCbhNRO2pAdBl4NHCF6b3yXc3dpgZVeTF91IVW18FoF/xpxYxwrWnCCYY0Z8hvGaJvcWE4y+9SFwL9ou5f2axOp9BlYbGXmPaaAmGhZOZmU+dvimHr6ni21G9QNXBLLRQrL4rzrOl2A5xjPoXbG5IoEO/6yyP5bw9OQ3Q2Ge7esTfZ7AcuOeXFujA+ipl9j1fccEjafr0cWaLmeoyJ9Z4uE5ytay+/pwLk2zJ976ufDsvl9FJ1OUfdgT2g/wx1muXQfaqfCn+SRflAgRO4FCgs5ZnK6agcF7UA1b3GxW+kvCSaKXRUjw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1779352634; c=relaxed/relaxed; bh=ukktCil6qFV5J1LkkLCVMIGTbGIgPkyHII6gX5uRxIU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=B9xfgV3pLtT2zUkqYnzYdyPU8louUFlIXc8o0IjFLhb2ujZHL8EmN+34R4UCnAggWkr2260Hsx53D8bwjmOSxrcHSlnaEe287zIXkkNpzghB+LpPKejK4v0G31FQ7HzKwAzI9li8o5I0cjFFNOld2L6BDfro9KtuG90zeK6ZVDzPzdR5iy8g12Qll6GQofAFILcf11MJA5wDsZdxZLyXo9Uir8QdNkOjCJopWMPT8xLPgIZJxF7mFWP4GDu1hYYVtvrZDTxx50+xFQdQBDPaXNIZDMlbKY/CVRuiRbGVzr4mgChe/od8VBYDTaEJ4j422NNf10F3oDdUd7GfHOVL/w== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=oHrTiXeE; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=hdG6+GG7; dkim-atps=neutral; spf=pass (client-ip=205.220.168.131; helo=mx0a-0031df01.pphosted.com; envelope-from=bartosz.golaszewski@oss.qualcomm.com; receiver=lists.ozlabs.org) smtp.mailfrom=oss.qualcomm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=oHrTiXeE; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=hdG6+GG7; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=oss.qualcomm.com (client-ip=205.220.168.131; helo=mx0a-0031df01.pphosted.com; envelope-from=bartosz.golaszewski@oss.qualcomm.com; receiver=lists.ozlabs.org) Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gLhbs2MCkz2xSN for ; Thu, 21 May 2026 18:37:13 +1000 (AEST) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L7PXPE119026 for ; Thu, 21 May 2026 08:37:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ukktCil6qFV5J1LkkLCVMIGTbGIgPkyHII6gX5uRxIU=; b=oHrTiXeEYw0WRHRT 0JryuBJBVPGqSxjyOTxM5WpWR6iIX+t5Ehvvw7Ijy/GBhhIDg6CRp4j3QlEKLHrd +T96al+7FsYIjjP2jU6FOexSof2OZMQ8rNPgA0pbm1sVXGeUZU2LmQlLaiX36fx3 MG+nBBELBSvdKBlncwtRnvz10SEQ3fEi44Jsy2GFv/ny2/9kv77+p55hQ3FGnrzQ IKaYfJHP4+j/gv2GVgK5+Euq6Esk471OF7JFruDCfx2cLtA7CQELRBGCRGfJBFlZ KngEWPif/BD7w3A+cd5xrKALQ79BP1Zurh4FsssoVkSxxz+bgCaXm7XUBHfW97zx +2sblA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ee8c169-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 08:37:11 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-514551d5f2aso231314071cf.2 for ; Thu, 21 May 2026 01:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779352630; x=1779957430; darn=lists.ozlabs.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ukktCil6qFV5J1LkkLCVMIGTbGIgPkyHII6gX5uRxIU=; b=hdG6+GG7RHdEOWVKuT2R4vfiwaew/sjBMTSe2Pm4fVoiJz8/021xY88TmWiGMl0JBL ADGXh0bo7cJ1KAy+0iu3QN44i+mpMvRxWMl8Z9mfM6jfsHRaAsTHjt/9nk5Ytt30TN5R WAFNgJB+NpfORVL6hY2o8yDA7niL8dSgJN9AUqHNtj7gnQ4GbbuVdvNYPo8/i44Dpf77 JgKRFNrqnzhSYfLnyYjy9iPeIwgsQURz2mAM9zDD1qkEgKe9kAF1hAYos8RJrb0yFcIm /FAr1jI9fBMsUAR6e+AqwCbHto2Jmg4LIDzcZnFRwaGIxjj6+vBvjd3YZ9hWb6yvF42k wJdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779352630; x=1779957430; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ukktCil6qFV5J1LkkLCVMIGTbGIgPkyHII6gX5uRxIU=; b=qhdM97p887/ASu5Wg4e3ohQNZKMknIFEAgZip/4WnXfFkV0n0AD9v2S0QYrtLdiv5y oSEwVHHvKsOLexkyUuSz5/5ACof1yubhvnBsHhZbeYl4okBqR1n1rAeY1NLEduXhdpKo WiJZ4WWKT2qyNyg9ROSRFlGwmGeHouZYg0A2FX6FELDw6qgwMuuO9AR2Tdh9v9sZhhBJ RRISB9NfOLxB7qCTTA2WsHIYJ5n0u+rFIoNXAEGL5cc2G3izaUJms4lKRtm+Pfci6imP Artf2zVdJ3+gaYQhqBbonTFmKGKgq0QDv1BReky52dF88RY7YuB30NxcjljbRTrwaq3h 3aPA== X-Forwarded-Encrypted: i=1; AFNElJ+G6lUiBc8lqvU0kNdUYYekpG1sFJ8Ap1g7OK9Gx1UHZjeqGqZl3bEt3ibv3EHbA+eRiyEW88pcMjR043o=@lists.ozlabs.org X-Gm-Message-State: AOJu0Yy0ENCEOmaphWJihn8ys5+Fne1Stf+oV2R8wZPLLk743NLIqz8/ rDnEZ465WMy8LCzA5sRxBv9VkcUdzploEPCKT5iQrHw2ZrBBc6DJu0ma7NYqOvAS8mgDMb6hvPO +FCLYI74HDM1hhKqRDcY5bp6wU6liu1IU03xcOzn8h5aZQ+UHhHbeu/jMf15Fdf91eK1p X-Gm-Gg: Acq92OFfnV6RKq5gh3NBKCV5nsJHwMlAcXPjwcXFdDJBce1jSADlKqm4DqX0y7+dMok o7ej7AOLpJqkRLvu42YCxAgSqE0Je57eQ+8yHNuynalvSaag8ApiBVTmFuyBwaAauaej7jj961x UnBdkbkkRT5f8/96rAjvSdQ1BpTdOf17suj/jRXZefazDW4upXXBU5S54OEin/FHUWeaz1KRHwe EjBSev6i8YW6hHFD1MMC443DO/DKV197BXO0lC8doFfZu6Ux/ur4zI1w4JfDPdfi26PgIC+5LlT dYfFNNkxuGNYaFlPhpi5MbzBOYRsV9H0Sqd52yvXxxGz3m0/Yup+wYVBpvnU1ZIAiUo2IcsyIMr b7nPNS03wy/+YDBuTj3a61zoKMQ9D/zPyleGVy8lwdwWIP7RcJVo= X-Received: by 2002:ac8:5f47:0:b0:50f:bcfe:e8e0 with SMTP id d75a77b69052e-516c5477e17mr25148101cf.13.1779352630340; Thu, 21 May 2026 01:37:10 -0700 (PDT) X-Received: by 2002:ac8:5f47:0:b0:50f:bcfe:e8e0 with SMTP id d75a77b69052e-516c5477e17mr25147771cf.13.1779352629775; Thu, 21 May 2026 01:37:09 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:bb10:ae82:b7c3:d15a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4903caede9fsm10502405e9.14.2026.05.21.01.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 01:37:09 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 21 May 2026 10:36:24 +0200 Subject: [PATCH 01/23] mfd: tps6586x: fix OF node refcount X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260521-pdev-fwnode-ref-v1-1-88c324a1b8d2@oss.qualcomm.com> References: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> In-Reply-To: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> To: Lee Jones , Mark Brown , Thierry Reding , Sebastian Hesselbarth , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Saravana Kannan , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Andi Shyti , Andy Shevchenko , Joerg Roedel , Will Deacon , Robin Murphy , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Ulf Hansson , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Matthew Brost , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , Peter Chen , Paul Cercueil , Bin Liu , Philipp Zabel , Maximilian Luz , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Krzysztof Kozlowski , Benjamin Herrenschmidt Cc: brgl@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1267; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=/aRY/vb3/hIBTIMJYLxhoggrOSD5XZpzRvD5IEGaQ84=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqDsQdlJ6Gw9yankDCBt9FSOgN2Xq2huOUHVWq2 3Mrh55a7QuJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCag7EHQAKCRAFnS7L/zaE w8nQD/4loqIyi5npUB0pcQ0If2+y1OYKJ5I3fRWNoD+DI2qAw7RvRg8s8P8r3CAXndoCmybnGcM 5m1IEHBWc6qOHq0mh/OkumNuSy1hZr2x107TEzMLDEBT9H1M+UZPMvVEe/aPC79WmowHUUF9TuQ GP5vrZ4LpMcgS4O084BJEASA5nzY7uelq72L6TarvzcMxyS5TjdWC6urxNMBWCi8R8jZzxGqvRA QLmH/AE/4+uNzpnvf0hKdeOVPd6gbvE0i6b80v+PHjuoXIi/p1jUehPLgdPjIZdjebdM2TlVbq/ P+9OrZKLw4SE+WRjUcN+UTnJ9tUAy0e3et+WqqPo3jUL89kKacqheQ1e2WkNXwGyi4uVuDNHzDN EvguWALMcMSEtupOOdXvE7nDWlVjqiY+3PMQILeq7NqMN/sFl6eCYnlTfomjSu+m/Em7L8Wq1ZD tFuwrfOg2BDxS7mr/FYdjg8+gBUNSZIL7MNlfzoXNWRl0rfwXF4Z8tdBbpD/g0zNTdhf5OZgAls IYx3BCJ1rkEwyphre8P9P953xIKshhJ4v9FpWul23QHiCYgcx00qs38wMQFaQ+tcpndPkewXAjf F/6YGVrg7Nc4nlGb9xf9H82vk+Y3HR5kALW1hO/kymu1NlKKvAubzUwld/OTrCD9MzeUjTa2CC3 KvJGbKuQmkv3QvA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-ORIG-GUID: sUYVuvdMiyh5mzlHQWx-jn0qDE3AF-a6 X-Authority-Analysis: v=2.4 cv=e5k2j6p/ c=1 sm=1 tr=0 ts=6a0ec437 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=4gvjGX-radYMG0rQGxsA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA4MyBTYWx0ZWRfXxlergG3JALAH ZqXaFg9QRtERgUoRDAvrnM+M4P991uArj9+uYLrQWRp2+damajsluUJTdJWRFbBnexVhCoLGd++ YiDuLekseEmqq2cy+n+NmkKGXobBgzHdC7Ek9jg+5N3Hj1ru86ysj8ubRIT2Mt5xpmJNh4uLrL4 3iq8jb9qelwBAi3K3UDK7eHcV4oZhcpqlydVXPg5WK7d5LHwlUS17h/HFehoRrGrKKLxPKOmuVx f0aVOxWnnq7WRKsE02g1KJHl+4iyiFgzi3iumYRnJgX5Z7UkSlzI/y7603jDVFCC3I5lJd3gBcK lbIuAQOF9ny+b0X/21yUl9VODjTV4Xtebhj5ig5oLLv4ozLkEXr0A80vvV7ciPIS1b78oeObwwT z5bvSvXoT3DnFh+6XqGYmk04Oh4Udb6josj2jRB/PTYO/6Ujbe4Z99Gj0fBUqvEtRviIsELjOSS 0mjjWxsxf0/Va6rrR3g== X-Proofpoint-GUID: sUYVuvdMiyh5mzlHQWx-jn0qDE3AF-a6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 priorityscore=1501 clxscore=1011 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210083 Platform devices created with platform_device_alloc() call platform_device_release() when the last reference to the device's kobject is dropped. This function calls of_node_put() unconditionally. This works fine for devices created with platform_device_register_full() but users of the split approach (platform_device_alloc() + platform_device_add()) must bump the reference of the of_node they assign manually. Add the missing call to of_node_get(). Cc: stable@vger.kernel.org Fixes: 62f6b0879304 ("tps6586x: Add device tree support") Signed-off-by: Bartosz Golaszewski --- drivers/mfd/tps6586x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c index 8d5fe2b60bfa550d0aad30acd0820fac354028ac..f5f805446603315ba76ce1fc501c908f1cec0d16 100644 --- a/drivers/mfd/tps6586x.c +++ b/drivers/mfd/tps6586x.c @@ -397,7 +397,7 @@ static int tps6586x_add_subdevs(struct tps6586x *tps6586x, pdev->dev.parent = tps6586x->dev; pdev->dev.platform_data = subdev->platform_data; - pdev->dev.of_node = subdev->of_node; + pdev->dev.of_node = of_node_get(subdev->of_node); ret = platform_device_add(pdev); if (ret) { -- 2.47.3