From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66BAACD5BB1 for ; Thu, 21 May 2026 08:37:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gLhbz5GqJz3bsL; Thu, 21 May 2026 18:37:19 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1779352639; cv=none; b=IjIVnkz5HTI/u0+S1Eou9C42gZtjnkWmNR/lJIgHgry48M9mDYmK3fC9DnW4r9wQ2lk+ti/4sxj5KF0SmINdJG96n2GFu7vn9ZsslZdFQPhIcWq5UHEuDbVs09qYYVUs27u273buh9JKyujmwmaANnLKML03vFxnyfvKq8Zf/KSNDobdt02tkNB73MVXgIY/bxdOduLDA1Dgqd7W3tuy4lQFcmtOoUSajzYn4tAPB+qvj/dcLntudGaoY7m7s7TVxAsU+QTIGVoWWavONgsaCMko948dHPuI8j24VSrydNjRrwXiKjHdWSf8og47lpGiwaxB9GlaDD6TiCRE88V7hw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1779352639; c=relaxed/relaxed; bh=GQi/2Sa2Ao4Qw8qIIsWmCidg4bHYCZ9URvi5VDdy2s0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gSiqOwI59IBM2mqqM071SFP6YTteAIZ2q2MhWwtCNIAGvlVDGbLTM7tRPWNZrfqJE/Plo+tRESsTxMh4A9Y/YIwfjaHY0+pYrrUMazGM4U/4g9gPdDbGUpQOW18VzTXZLkI1ihYkqS8AOoyPLAOGx+6hO81xnWlwE1tCqgGXxl0oO0AseihjWivKujGYB97icXn2sqa0LMOntSzPYvfoP8Jxa/BNZprxBOiJkbFeqio9bZRL17P2HydDYNJnq6MtnhUXpsL1tZkduLT/hjJOZ28n765YKXlLY97wpHy+YGE2+kiKl3z0oUI4DIwSXMuDZiPQlfNn3wM5dbQziIHhzA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=L/eaP3Me; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=iIpwSTfY; dkim-atps=neutral; spf=pass (client-ip=205.220.168.131; helo=mx0a-0031df01.pphosted.com; envelope-from=bartosz.golaszewski@oss.qualcomm.com; receiver=lists.ozlabs.org) smtp.mailfrom=oss.qualcomm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=L/eaP3Me; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=iIpwSTfY; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=oss.qualcomm.com (client-ip=205.220.168.131; helo=mx0a-0031df01.pphosted.com; envelope-from=bartosz.golaszewski@oss.qualcomm.com; receiver=lists.ozlabs.org) Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gLhbz07bWz3brP for ; Thu, 21 May 2026 18:37:18 +1000 (AEST) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L6lsCp3680300 for ; Thu, 21 May 2026 08:37:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GQi/2Sa2Ao4Qw8qIIsWmCidg4bHYCZ9URvi5VDdy2s0=; b=L/eaP3MeOWaUpNy6 L81FH4QqV7eTsVlLcALgYeu3AEzESKyGvBjdCNPdLjd1PyF2SZVs3J5kZTQA76LG QAa47beiYQc9Iaw6z68RT6nfHwSlw1VWGCNvodnNl5e5mx98F/WQXUOooyAvfe41 b3H9PAmUsIdKxVaoqWwTX+LLGAOwmbUEcGTU99iXRSUjA6qlWiUdnfQgGXUXA0/H Vwt3MFFN9p8ZoaDcqYEwJO0s1wJqUyu79HJCUM/WGg2ypLhk/ox6shunIfuY3U7q oQa3n9rDYxnEdqImbmWMSdsWdtVcy9xeO8cS+TWKP0DDwYt/liF/85jDISbCqOhP bmenKw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9e9j40ue-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 08:37:17 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5162ee45a77so153543191cf.1 for ; Thu, 21 May 2026 01:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779352636; x=1779957436; darn=lists.ozlabs.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GQi/2Sa2Ao4Qw8qIIsWmCidg4bHYCZ9URvi5VDdy2s0=; b=iIpwSTfY2dW9Ae/847I+YO8vPDYl1xcG4OBY3oGKpRbq81yj82ggkAE5fNkiMjglIU OrKnYVF/Q3+kVaDDQbQt64jXZm7ucWVGETPI7rHgxtMvY05RyGqfVNqx81TjHTygC2EY D6mVHWpTnSV9imrhlxvNR49AHA5uiarQUCZa7oT3cvr2LnPbh4+w+o0V8Js2nS8jfL5O s1ckdxZ2/OpBh/HODXKh5r084gEUw66mcrw/zpScAExETOo/lMjVCInfOOYHZPyekjLy Lp/ViHDaq9LDtDHqVqTrnMuLG/SmIbfOCIWXYiTFeot2HvSrCBKGKy2O12LSl+lFJoLS 3uVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779352636; x=1779957436; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GQi/2Sa2Ao4Qw8qIIsWmCidg4bHYCZ9URvi5VDdy2s0=; b=JeR/c06Pxc+pQPBuEdoZwNS3XCx9YtZ+O0mx8bEMoSfxdtB3CaxVTL1vTMVrKCHLCf C1m/QOFyoIHzngkJ4b5bzchtNuO6255ajNaYBFGOb5zzHnmfQo73Ol3USHd45PSNeXwx dizMBH9tszlqoPNyLIroD4jsCJxhai7V09EEDmnRNHZxJuqQKpKyvoGnwL0dqA66X6Ix kUmjMMVGbtxf5efsz82Rn9YlRZxg2Yo+kHnsqth/gpi5Gn3hJnSaJrUf/FJOyw/m4wKd joMsasl8LCwpE79atZLPpObmpH5hy+S8DveKnNkdqASv5sU2fczymu1CDgCtoHsCUiAN J+ow== X-Forwarded-Encrypted: i=1; AFNElJ9eemXjLmKYY5DwWMlfZg/X64mfVrd4qpKg8dmWGASbZxLjzcosQrXtqvhTLyDyIXaqjBM9LqHp0mJGFI0=@lists.ozlabs.org X-Gm-Message-State: AOJu0YwFcjQor2Q0xT0XsHmJHIvpyNj3nSD9SjKiAIrxSVdj4x3v2hfR HHYoIZ0zuBgItfjLwNYB+FIjH4huZLIea6DzurSIHnT0HcOYQX3KMsethOJO0WzkIESUHsyC8cG mI8gKIASUTmYhrhAaE4VoDisHgUiLtFdEAyZ0H/3FkVT0p/3ZqunIelzubtzUsbTsq+ng X-Gm-Gg: Acq92OEdNq/bTCh1gbIEOvoXxeVnPJSgn4SfTUyxp8+w12Q74q3QOlAF9uTPJxrTs1u ufVFgQOpnv0PgD5a4JyS0Lx2Ra/bNcy4QkzP6Jp2WyMq3xPvZfWilp0H+wgjJ6Yl78LQwb1c0EG eM4JVcAlKd6g3ptYJ23yoM43GV5Yrl1IWWdCOOIHVNhZXo+UoT9Q7t3cjAq4fbRU5UdPq+lhuT/ 53aw6+6XlumYAXo1Wyv9/n3u73eeHjLATwsqa0lAPGkEDJGK/Ki5uFovoOEKY0AylQY+ss+sUT4 LGcDpzpGbirhDc8zEej/soQEFE2jhTYaOtvB+c4F0foux2NNNU6UAhQnCGxUdNOlaFsbMXsugRK ZH+13e9HZuwgRsOmM07jomMMogHQxamL7rO80tsJZ3nq6e316YTQ= X-Received: by 2002:a05:622a:130c:b0:50f:c109:b78 with SMTP id d75a77b69052e-516c56114c7mr25055481cf.60.1779352636282; Thu, 21 May 2026 01:37:16 -0700 (PDT) X-Received: by 2002:a05:622a:130c:b0:50f:c109:b78 with SMTP id d75a77b69052e-516c56114c7mr25055161cf.60.1779352635782; Thu, 21 May 2026 01:37:15 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:bb10:ae82:b7c3:d15a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4903caede9fsm10502405e9.14.2026.05.21.01.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 01:37:15 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 21 May 2026 10:36:26 +0200 Subject: [PATCH 03/23] slimbus: qcom-ngd-ctrl: fix OF node refcount X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260521-pdev-fwnode-ref-v1-3-88c324a1b8d2@oss.qualcomm.com> References: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> In-Reply-To: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> To: Lee Jones , Mark Brown , Thierry Reding , Sebastian Hesselbarth , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Saravana Kannan , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Andi Shyti , Andy Shevchenko , Joerg Roedel , Will Deacon , Robin Murphy , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Ulf Hansson , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Matthew Brost , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , Peter Chen , Paul Cercueil , Bin Liu , Philipp Zabel , Maximilian Luz , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Krzysztof Kozlowski , Benjamin Herrenschmidt Cc: brgl@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1268; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=kTQKbm6eRN9ag0Un2nZCXzTW7BV3akk7azahbn/UzJ4=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqDsQgIMxfR+Vbirqz0SdcKiFdhrIvHLFQpLiZ1 CS8+oZRD2CJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCag7EIAAKCRAFnS7L/zaE w+/+D/0bfM9BBNs3PkNDjV3H97Mjk+BxEtuO3ngB9aYBqCWAj5QNlt01IhjpA6JnwDFP8fqCIyv vjkgxJM6sX4hv38HQ37w3/3e9w9nT1pEO8Z+vJO4ioacKerKf2Q0pDqYaIvMKRt/6v7PZ5F/8Qk F0oK3T58PSr3/oja0fGdyamleQyFBi3nxqx0i5pFUhtKOPDLB2JFMiF/Bc8z1Ao7b5/iH3mCRqw t4xceOWbqkCGcjrQwrwQuaQSwOFDgpuuNyxmj1LqEJaU/nDLivdr0K2cDU/9sLO5YhX1oEhG2nW XOO37zyMEA5NZH4QY0XDY91U+LIW+AczElBXOp5HW0hZ93FukF2Jykzc3pqr+4YnbKGcomK+0Yf q9nt12I/oL8N6u17VckldD5ZK4oqD6w1sf2nwZHj8W0dw1+L7YHzf9FRkrLonMvjMF8CzU8u+sy Jy0nFN5sFXOEVUkaOM7w5NUOXxfk7efn4VYU+BlGan6tS+++PJdEI8/oFCt6Y92Le98zlLOeLaN 4okZNZe0VbOfsGZ7C8aYV/L5BdKwVRPIyxpJ3u3CgaMyWDH4U+OfUQIYpUzUcMflrUDECYMZMEr P5YYEoi2xgk/wmO4H3kPlxxCpOwXpXqfE9cRHoxk6WbFV0NB/WCqRqm8xGakOeDDaQ4wKiLTEBG Ah+8HIb4q9OvlZQ== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=bfhbluPB c=1 sm=1 tr=0 ts=6a0ec43d cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=lFaTzyIiLygvDfm8gxsA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: 5ZAJ2SKOWpEHMnkcLAf6TLIhAhIRcONS X-Proofpoint-ORIG-GUID: 5ZAJ2SKOWpEHMnkcLAf6TLIhAhIRcONS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA4MyBTYWx0ZWRfXyM2732I8/jng 44aTL6gbfnv6bxbSgR00ohcuzB9873cbYrXBuYVtlhOjGh6hWy8ARHCmmZzj0gGPm308Qz63WhB o970NFYgVWis4ke6t/X3FLFuqPwGavHUaeFQ9JGFj1AFPCjelSOArGyhcfmwYscGjqpbAUolvNz dv/UnXCU4quc3yL+/SjhZ6kC3DCBHF2WYHW1zMQfrl4yUOE2gLBz5ZQhi+LpnLqxygIUkbupYKF Jv+/CdotW65qTRqwhKzl8Q4sAV1ZceaXf2VuIVBow0yHW4kY/iaXujJ/awYqgvfXVxBXlpQNpDJ AzqKPRwGGIXv/9yZLeB36yOoUx9x31ptPLvDIt/OcA8raMaZ/W41zrF2lj8+HBc6cQ6afvY6lcF GNIcOqnAeiSK2efuJtV0BXK4t3Sye/LVEZZ+hMTg63VStXa/mm2U9dd7kf2iuxKbdKbeYKXZHIY wL6rU+H89ddQDPmdldA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 spamscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210083 Platform devices created with platform_device_alloc() call platform_device_release() when the last reference to the device's kobject is dropped. This function calls of_node_put() unconditionally. This works fine for devices created with platform_device_register_full() but users of the split approach (platform_device_alloc() + platform_device_add()) must bump the reference of the of_node they assign manually. Add the missing call to of_node_get(). Cc: stable@vger.kernel.org Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") Signed-off-by: Bartosz Golaszewski --- drivers/slimbus/qcom-ngd-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 1ed6be6e85d2cfc0a2b65a5ae24f666de922c89d..428266949fdd07ac13c5553bded891225c6e1a16 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1542,7 +1542,7 @@ static int of_qcom_slim_ngd_register(struct device *parent, kfree(ngd); return ret; } - ngd->pdev->dev.of_node = node; + ngd->pdev->dev.of_node = of_node_get(node); ctrl->ngd = ngd; ret = platform_device_add(ngd->pdev); -- 2.47.3