From: Jason Gunthorpe <jgg@ziepe.ca>
To: Christoph Hellwig <hch@infradead.org>
Cc: "T.J. Mercier" <tjmercier@google.com>,
maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
chleroy@kernel.org, linuxppc-dev@lists.ozlabs.org,
mripard@kernel.org, sumit.semwal@linaro.org, lkp@intel.com,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
linux-mm@kvack.org, agordeev@linux.ibm.com,
gerald.schaefer@linux.ibm.com, linux-s390@vger.kernel.org,
Dan Williams <djbw@kernel.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
x86@kernel.org
Subject: Re: [PATCH] powerpc: Export set_memory_encrypted and set_memory_decrypted
Date: Wed, 27 May 2026 13:07:16 -0300 [thread overview]
Message-ID: <20260527160716.GN2487554@ziepe.ca> (raw)
In-Reply-To: <ahPqbfH54R3JJyaV@infradead.org>
On Sun, May 24, 2026 at 11:21:33PM -0700, Christoph Hellwig wrote:
> On Fri, May 22, 2026 at 03:58:53PM -0700, T.J. Mercier wrote:
> > After commit fd55edff8a0a ("dma-buf: heaps: system: Turn the heap into a
> > module") the system dma-buf heaps can be built as a module. The
> > system_cc_shared heap uses set_memory_encrypted and set_memory_decrypted
> > but those functions are not exported on powerpc. This can result in a
> > build error like:
>
> I'd much rather revert the above commit. Yes, x86 has exported these
> since 2017, but that's a really bad idea, and we should fix it instead
> of spreading the export.
>
> Setting memory decrypted is a dangerous operations and should only
> be available to core code. We should have various allocators for
> decrypted code, but not export the functionality to random code.
At the very least an EXPORT_SYMBOL_NS.
Looks like there are about 3 modules using it already..
Jason
next prev parent reply other threads:[~2026-05-27 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 22:58 [PATCH] powerpc: Export set_memory_encrypted and set_memory_decrypted T.J. Mercier
2026-05-25 6:21 ` Christoph Hellwig
2026-05-27 16:07 ` Jason Gunthorpe [this message]
2026-05-27 18:15 ` Borislav Petkov
2026-05-28 8:53 ` Christoph Hellwig
2026-06-04 5:34 ` Maxime Ripard
2026-06-04 7:21 ` Sumit Semwal
2026-06-04 7:32 ` Sumit Semwal
2026-06-04 13:57 ` Jason Gunthorpe
2026-06-08 15:17 ` Sumit Semwal
2026-06-08 15:27 ` Jason Gunthorpe
2026-06-08 16:04 ` T.J. Mercier
2026-06-09 11:43 ` Jiri Pirko
2026-06-09 12:31 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527160716.GN2487554@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=agordeev@linux.ibm.com \
--cc=chleroy@kernel.org \
--cc=djbw@kernel.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=mripard@kernel.org \
--cc=npiggin@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=thomas.lendacky@amd.com \
--cc=tjmercier@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox