From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 518A9CD98CE for ; Fri, 12 Jun 2026 14:50:14 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gcMr46rYyz3btt; Sat, 13 Jun 2026 00:50:12 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::132b" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1781270868; cv=none; b=JA5WM3Jd+xuD3hUbwNC4vZ4PmKALOVfdhQNtulQOLgIZpjJpcKihGnOwv8YM9T/77nhMhfJlAQ9VdWd5ar+3aJpxDJRg0eN5afKOosMzLfsehArzxXnWgcHd/2lrAisvSl7tPC+bN211QWfGL2J8u1H2Di6x1wzkWcb8Eeb4QPkmi+kQfLqpGUtcZ34JCUlkNACSxEkb0EXCbqz4UThfNAI1SSsiSi6phbbOZu28z/32BzM3d6/UOr02DBGD7L+qn5wF16r/waMW8sfT3bFOI6ZxsI/cfoEJFhg20n/hhadhg0yPlGdqS5WH+OqQ5SSugwPJArwFGn00lcVETooRxA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1781270868; c=relaxed/relaxed; bh=5EUVrIUd9a5W03H8en3F5BUxu9fsoDVhajTiBFAwOuM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WI2mwn4pr9jtuobXGi2NcCn4MUKJ+G+kMYiZXMyEW42M3isG1WBqFLHGaQNXxmC86yU1E/Sje+6WHyI72qsLJJNsrd2Rq8RubbWZ9M5PxF/tuF42NRnXkcCZ+LT9wM65z0y9yRpCSsHpoyBcEEJmBvwXD7EPXaB9ZCnbbxJm1EQAPpse0YwhkAMU8ybUJG8k80ttkdoYvdol2+GOkprg1FgrRvAeNHO31HM/XbUgrqw8WQASYt/0b6sT+ZFKvZofRwttQli88GNfZ6+m5dZLuaNwzScqx5rlGu6w8oK+avSnCZ6gkmwn19DNX0w+sUIUo+W2wK9Eng4OZIpKkvQgvA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=c/5Au/jP; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::132b; helo=mail-dy1-x132b.google.com; envelope-from=phucduc.bui@gmail.com; receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=c/5Au/jP; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::132b; helo=mail-dy1-x132b.google.com; envelope-from=phucduc.bui@gmail.com; receiver=lists.ozlabs.org) Received: from mail-dy1-x132b.google.com (mail-dy1-x132b.google.com [IPv6:2607:f8b0:4864:20::132b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gcL1035zVz2yhY for ; Fri, 12 Jun 2026 23:27:48 +1000 (AEST) Received: by mail-dy1-x132b.google.com with SMTP id 5a478bee46e88-3042a388168so1140392eec.1 for ; Fri, 12 Jun 2026 06:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781270866; x=1781875666; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5EUVrIUd9a5W03H8en3F5BUxu9fsoDVhajTiBFAwOuM=; b=c/5Au/jPozwfnUSNaeKWhXA/DXR/5wD6sYjVXtmElEivj1rPyiCIowjc5/Arwf1vlm jVBqWuJ7XgL3/pbEjKEb+pHCZolXFPWEsYzQdb/ovBvaVNebqV8JRSw5pMmCDVe8N7qS RwE0yhDDMAy0NK/2t99aOPnZ+mHDAwPPcP24RHLvjtJdNVZ3cuoPOkzpc5bYpo1uaPTX K3Rh/UPbJk1HjxP3faj7JEBJif2QU3VCb1ro1ent+1lugDnvDms96rBJbKmhDp4TUGWC c9+u/tXqgcUZeo67jlOCRspoHkmfM8WgEoDYbj2T2r6dUfqMeG1XNss0lBTMqSNyQYLD PgaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781270866; x=1781875666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5EUVrIUd9a5W03H8en3F5BUxu9fsoDVhajTiBFAwOuM=; b=KbfNAVM1LlF5c9KGoQTpzC33comMX/QR3PpcEo8QQbTlQztQV3FtXiZFVXXJ6npuj8 8qxnzWbVFvI44blx1A8Q5NCSDLg+nnFqgeb8KscTxKzU+caBLQKcGvbSmX1slzqPaksy YaXb324J6feyu0sIXCSisqTUEgJOkWItyJ4MTGj9Vsg8j1K+FKcr/yU4tT/pIMToFIz7 ie/k5mlm/oCZ663uQHDOIaRjBvrq94SsaBh5jr8aEDWWRcTprNaeBAS+ck7MLvZarISp mnpboWj34zO0CdjZVko9Xxjp2QRCIakgMtmEzG6+lQf5uhruj0w62trnbhCKKhdQWyaz 7Z9w== X-Forwarded-Encrypted: i=1; AFNElJ+A9lTf1QL4BXu1v3BoQ8OULc6ZJXz5uOK9TawhNxxNEHFZyupftJ0jpqVAnxmO3zvc1kWopoLWODiAisQ=@lists.ozlabs.org X-Gm-Message-State: AOJu0YzyHYP+bUQk6c6Z9FdY0TB/bPyZjr+H6q1ahBJ3CdSwHokygzDl 90zkvCczqUNO6kOwj8jpTy36qkeTC0ALolgEmqnK5gIQ8vC7Y7vC/w2n X-Gm-Gg: Acq92OE+oU60vvTxrtB8YjcEEytEQtyO8FKx8Ah6Oi7Be1EmoubquqXMfGwSthsQoJ6 GyDhEJroKevGgKWMfKH1nv0E3EkyxfnrKHp0Ik601QmJ9hpgnRMR5gbxktVrVtAUV1utPzK+YGy 9BuiRbDMzSD6RTQmjgpoCT3I3UjYcLCunEfOOSjDfdDfCKAmYdjNo/gF40IzLlUN5cjtdd6aeMa 1sFs1MB7KcaHSyYTuXsVrlKBrTew1usSGljXIv4QVaM4QwsUrFq/yj7fxDVCGIiauQyxTFhWJzN I+rz7tCmenU8xoR4ih7xC6cz14lGVi3JpDBpxNXUWsq6B/bSM884giIXXEJ5YcDKpi0gqP4kdqf 9kdUhBXYez/rgcSL7V4nZ4m4AiF/kenbMXPxBuTLMV2C+x+kmvxKPC+nvYTiX46OpPfBXTUvbcq gCz63NBtktQjrWiRSsTP4VBsnXQDdZnple+anMY+2zf4r3ShWHJEphMPW46w== X-Received: by 2002:a05:7300:1827:b0:2e7:190:41d6 with SMTP id 5a478bee46e88-30820c07f8emr1497455eec.2.1781270866381; Fri, 12 Jun 2026 06:27:46 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e91f8b5sm3302343eec.19.2026.06.12.06.27.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 06:27:45 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Frank Li , Fabio Estevam , Nicolin Chen , Sascha Hauer , Pengutronix Kernel Team , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, bui duc phuc Subject: [PATCH 09/11] ASoC: fsl_rpmsg: Use guard() for mutex & spin locks Date: Fri, 12 Jun 2026 20:26:37 +0700 Message-ID: <20260612132639.78086-10-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260612132639.78086-1-phucduc.bui@gmail.com> References: <20260612132639.78086-1-phucduc.bui@gmail.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex & spin locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/fsl/imx-pcm-rpmsg.c | 69 +++++++++++++++-------------------- 1 file changed, 30 insertions(+), 39 deletions(-) diff --git a/sound/soc/fsl/imx-pcm-rpmsg.c b/sound/soc/fsl/imx-pcm-rpmsg.c index 031e5272215d..7210393dfa5d 100644 --- a/sound/soc/fsl/imx-pcm-rpmsg.c +++ b/sound/soc/fsl/imx-pcm-rpmsg.c @@ -39,10 +39,9 @@ static int imx_rpmsg_pcm_send_message(struct rpmsg_msg *msg, struct rpmsg_device *rpdev = info->rpdev; int ret = 0; - mutex_lock(&info->msg_lock); + guard(mutex)(&info->msg_lock); if (!rpdev) { dev_err(info->dev, "rpmsg channel not ready\n"); - mutex_unlock(&info->msg_lock); return -EINVAL; } @@ -55,15 +54,12 @@ static int imx_rpmsg_pcm_send_message(struct rpmsg_msg *msg, sizeof(struct rpmsg_s_msg)); if (ret) { dev_err(&rpdev->dev, "rpmsg_send failed: %d\n", ret); - mutex_unlock(&info->msg_lock); return ret; } /* No receive msg for TYPE_C command */ - if (msg->s_msg.header.type == MSG_TYPE_C) { - mutex_unlock(&info->msg_lock); + if (msg->s_msg.header.type == MSG_TYPE_C) return 0; - } /* wait response from rpmsg */ ret = wait_for_completion_timeout(&info->cmd_complete, @@ -71,7 +67,6 @@ static int imx_rpmsg_pcm_send_message(struct rpmsg_msg *msg, if (!ret) { dev_err(&rpdev->dev, "rpmsg_send cmd %d timeout!\n", msg->s_msg.header.cmd); - mutex_unlock(&info->msg_lock); return -ETIMEDOUT; } @@ -100,8 +95,6 @@ static int imx_rpmsg_pcm_send_message(struct rpmsg_msg *msg, dev_dbg(&rpdev->dev, "cmd:%d, resp %d\n", msg->s_msg.header.cmd, info->r_msg.param.resp); - mutex_unlock(&info->msg_lock); - return 0; } @@ -109,14 +102,13 @@ static int imx_rpmsg_insert_workqueue(struct snd_pcm_substream *substream, struct rpmsg_msg *msg, struct rpmsg_info *info) { - unsigned long flags; int ret = 0; /* * Queue the work to workqueue. * If the queue is full, drop the message. */ - spin_lock_irqsave(&info->wq_lock, flags); + guard(spinlock_irqsave)(&info->wq_lock); if (info->work_write_index != info->work_read_index) { int index = info->work_write_index; @@ -130,7 +122,6 @@ static int imx_rpmsg_insert_workqueue(struct snd_pcm_substream *substream, info->msg_drop_count[substream->stream]++; ret = -EPIPE; } - spin_unlock_irqrestore(&info->wq_lock, flags); return ret; } @@ -523,7 +514,6 @@ static int imx_rpmsg_pcm_ack(struct snd_soc_component *component, snd_pcm_sframes_t avail; struct timer_list *timer; struct rpmsg_msg *msg; - unsigned long flags; int buffer_tail = 0; int written_num; @@ -553,11 +543,11 @@ static int imx_rpmsg_pcm_ack(struct snd_soc_component *component, msg->s_msg.param.buffer_tail = buffer_tail; /* The notification message is updated to latest */ - spin_lock_irqsave(&info->lock[substream->stream], flags); - memcpy(&info->notify[substream->stream], msg, - sizeof(struct rpmsg_s_msg)); - info->notify_updated[substream->stream] = true; - spin_unlock_irqrestore(&info->lock[substream->stream], flags); + scoped_guard(spinlock_irqsave, &info->lock[substream->stream]) { + memcpy(&info->notify[substream->stream], msg, + sizeof(struct rpmsg_s_msg)); + info->notify_updated[substream->stream] = true; + } if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) avail = snd_pcm_playback_hw_avail(runtime); @@ -640,7 +630,7 @@ static void imx_rpmsg_pcm_work(struct work_struct *work) bool is_notification = false; struct rpmsg_info *info; struct rpmsg_msg msg; - unsigned long flags; + bool updated; work_of_rpmsg = container_of(work, struct work_of_rpmsg, work); info = work_of_rpmsg->info; @@ -651,25 +641,26 @@ static void imx_rpmsg_pcm_work(struct work_struct *work) * enough data in M core side, need to let M core know * data is updated immediately. */ - spin_lock_irqsave(&info->lock[TX], flags); - if (info->notify_updated[TX]) { - memcpy(&msg, &info->notify[TX], sizeof(struct rpmsg_s_msg)); - info->notify_updated[TX] = false; - spin_unlock_irqrestore(&info->lock[TX], flags); - info->send_message(&msg, info); - } else { - spin_unlock_irqrestore(&info->lock[TX], flags); + scoped_guard(spinlock_irqsave, &info->lock[TX]) { + updated = info->notify_updated[TX]; + if (updated) { + memcpy(&msg, &info->notify[TX], sizeof(struct rpmsg_s_msg)); + info->notify_updated[TX] = false; + } } - - spin_lock_irqsave(&info->lock[RX], flags); - if (info->notify_updated[RX]) { - memcpy(&msg, &info->notify[RX], sizeof(struct rpmsg_s_msg)); - info->notify_updated[RX] = false; - spin_unlock_irqrestore(&info->lock[RX], flags); + if (updated) info->send_message(&msg, info); - } else { - spin_unlock_irqrestore(&info->lock[RX], flags); + + scoped_guard(spinlock_irqsave, &info->lock[RX]) { + updated = info->notify_updated[RX]; + if (updated) { + memcpy(&msg, &info->notify[RX], sizeof(struct rpmsg_s_msg)); + info->notify_updated[RX] = false; + } } + if (updated) + info->send_message(&msg, info); + /* Skip the notification message for it has been processed above */ if (work_of_rpmsg->msg.s_msg.header.type == MSG_TYPE_C && @@ -681,10 +672,10 @@ static void imx_rpmsg_pcm_work(struct work_struct *work) info->send_message(&work_of_rpmsg->msg, info); /* update read index */ - spin_lock_irqsave(&info->wq_lock, flags); - info->work_read_index++; - info->work_read_index %= WORK_MAX_NUM; - spin_unlock_irqrestore(&info->wq_lock, flags); + scoped_guard(spinlock_irqsave, &info->wq_lock) { + info->work_read_index++; + info->work_read_index %= WORK_MAX_NUM; + } } static int imx_rpmsg_pcm_probe(struct platform_device *pdev) -- 2.43.0