From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9630FCD98F8 for ; Fri, 19 Jun 2026 08:53:33 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ghWZW08bkz3brN; Fri, 19 Jun 2026 18:52:51 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1781859170; cv=none; b=DcVoie+CH9XCfbH7qJOK2Rp3NkhLk6XmF9fJH8OydGoSYE1TZN9D1/eQrXiKAh8muAkc0z2cTSes13Zqom3woKxbhH7fh25lb3d56J4QIU9E0Qc9d6zYLEBKllNDtFQVhEA0ruhFqxV3vg0/oDk6bOdD7eODKB1xtVOp27oufub9cw/SzzeI/g3aLDB9bhHyPVm26Pr+CK4/aDyTPHChKEiUkebt59saBfLwCCdlz3T6R8XuiUL/7tbrmS8PZJsLawPb+nBnDRMAZ9xz2fK1cJghO3vKYfKjA9kfxjk4d/+X6LWym4Y3RqpmzN3eRlXiwoyK1Zq4qeqse6U+bw2Y7w== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1781859170; c=relaxed/relaxed; bh=1TCq4HRRJaHfxCGez1eXES+uvzFJvswxpkFT9pP4678=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BF3cClRzwcFnAqOqtfZZnEErP3qMYvvkKTh1Qeb65NlK8Y6cJEnq/MuWdVzZPTSnttaQVo089RV4/U2zbTLRMT2nqEJjiAUwDHLJexPHcDJGAD5XnD+0MXn0AqKmMee4LBerbQ7IwIN562DcjcNhRBWcJ1JIcNTG1xfvq9QxaMURL4Tf9K5d9NNsPXqEAgvFPkE8/4DKcW5vTolKYD2J6VQib2eGH58kOgBqKBVT+finWn1HdeVbVcUOLEzvms8jlQdnMut4IyxXxOvkalfoJJ5zUoE6K9KISew3BrcDH85o+8YsnoVQGQ8JVP8ic5d7eQ9QUnWa8405qJFlBlTZcg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=CPSyt+PI; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=CPSyt+PI; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ghWZV1p05z3bpP for ; Fri, 19 Jun 2026 18:52:50 +1000 (AEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B8A0642A40; Fri, 19 Jun 2026 08:52:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EE361F000E9; Fri, 19 Jun 2026 08:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781859168; bh=1TCq4HRRJaHfxCGez1eXES+uvzFJvswxpkFT9pP4678=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CPSyt+PIAHizrhsXtBI8nWxq8YYSFIXhMJpqbmax3b/4wNiO2/9SswwyHa8Qz1/P/ LsOZ+a3qxZwII/w5nAYeTwlA1+BDuwH28N8IppApKpm5rmZcZBpmVmGUu45dDhB1XJ R7w9FSpA5zztLmaVYF2hGdS5iTZ1GQKmhWOHlt7MyUeANyVk6V8IY+iaTBErMjMmX0 QFKRZXaiL+FEjafD1cYI/6W0MYWOge3jqumzBWKz/eix+Pi86Vwf2pNQWxQGvKCS/s eilUtFJncGmT94OwcDepxuWreHTLK/vIMCGintIaxc53EXzJD7Z+Njp03pFKhmu063 hSjn2uuw6Keag== From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Cc: Bjorn Helgaas , Manivannan Sadhasivam , Lorenzo Pieralisi , Alex Williamson , Magnus Lindholm , Matt Turner , Richard Henderson , Christophe Leroy , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Dexuan Cui , =?UTF-8?q?Krzysztof=20Ha=C5=82asa?= , Lukas Wunner , "Oliver O'Halloran" , Saurabh Singh Sengar , Shuan He , Srivatsa Bhat , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH v8 12/25] alpha/PCI: Use BAR index in sysfs attr->private instead of resource pointer Date: Fri, 19 Jun 2026 08:51:47 +0000 Message-ID: <20260619085200.3729431-13-kwilczynski@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260619085200.3729431-1-kwilczynski@kernel.org> References: <20260619085200.3729431-1-kwilczynski@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, Alpha's pci_create_one_attr() stores a resource pointer in attr->private, and pci_mmap_resource() loops through all BARs to find the matching index. Thus, store the BAR index directly in attr->private and retrieve the resource via pci_resource_n(). This eliminates the loop and aligns with the convention used by the generic PCI sysfs code. The PCI core change was first added in the commit dca40b186b75 ("PCI: Use BAR index in sysfs attr->private instead of resource pointer"). Tested-by: Magnus Lindholm Tested-by: Shivaprasad G Bhat Reviewed-by: Ilpo Järvinen Acked-by: Magnus Lindholm Signed-off-by: Krzysztof Wilczyński --- arch/alpha/kernel/pci-sysfs.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c index 2324720c3e83..2330ab84d59c 100644 --- a/arch/alpha/kernel/pci-sysfs.c +++ b/arch/alpha/kernel/pci-sysfs.c @@ -69,25 +69,20 @@ static int pci_mmap_resource(struct kobject *kobj, struct vm_area_struct *vma, int sparse) { struct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj)); - struct resource *res = attr->private; + int barno = (unsigned long)attr->private; + struct resource *res = pci_resource_n(pdev, barno); enum pci_mmap_state mmap_type; struct pci_bus_region bar; - int i, ret; + int ret; ret = security_locked_down(LOCKDOWN_PCI_ACCESS); if (ret) return ret; - for (i = 0; i < PCI_STD_NUM_BARS; i++) - if (res == &pdev->resource[i]) - break; - if (i >= PCI_STD_NUM_BARS) - return -ENODEV; - if (res->flags & IORESOURCE_MEM && iomem_is_exclusive(res->start)) return -EINVAL; - if (!__pci_mmap_fits(pdev, i, vma, sparse)) + if (!__pci_mmap_fits(pdev, barno, vma, sparse)) return -EINVAL; pcibios_resource_to_bus(pdev->bus, &bar, res); @@ -170,7 +165,7 @@ static int pci_create_one_attr(struct pci_dev *pdev, int num, char *name, res_attr->attr.name = name; res_attr->attr.mode = S_IRUSR | S_IWUSR; res_attr->size = sparse ? size << 5 : size; - res_attr->private = &pdev->resource[num]; + res_attr->private = (void *)(unsigned long)num; return sysfs_create_bin_file(&pdev->dev.kobj, res_attr); } -- 2.54.0