From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2112BCD98F8 for ; Fri, 19 Jun 2026 08:53:52 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ghWZj6399z3brZ; Fri, 19 Jun 2026 18:53:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1781859181; cv=none; b=L4FJHaRkDzJjMsN7OTWEU54CBEZdLWTIjUaSz22Hgn7ju33TIU1nL9axe0g6z8OCZA//Kymm5/ca7UjMu+fa9wziKeZybm38NqXm7Zrp47noduc+khxjl81EcFJlBof5bGdsZI3iCbfsXUF/n9umpY2kLyTPdzU7RuYHqLAGKeRwIdIcTACtblg+cpHUAXkVWFnVzkY6rKNy1oQhRm+upHWCzc+lOaH6zFM4JiuMW8XYfLmWtsyaz/buZJ2LGPVWr20CBdhdoML97U1Me0H6Co8QtMqvHbrTBXFnitbtQebfSQ5vAmN/HZs1k02XBBI8g7ZqSiWkZExvMlgVgcHOzg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1781859181; c=relaxed/relaxed; bh=MeaEEnmBG3oFKgCGg6n5aGYQQrjBqtYm3M3kvW7MyfI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J4jYZaIrNhiTNtsx0DrL1dR3QTep/xiWBvZ34PtZzJlBaHrUdQB+i1YU+fJ5ZkhuFz3+lb2FmkVsrDcZA0scy7wbiMS9gatmrLH4s6OIWh8jxGN2QVkL33AWDH9TtAvMtv15+kBeF0vaRzhJh5DxGdDVUjpxHngc3uTmz3kMFVelLlVkkMmCaVe2K8gd88HWAq8692ON54eFT9GYIH6fnJFe4MTKHvR3vRCjayWPlDqoztlwm6haUM8BClYjn2DEg2PDcKzKaBC69izEixkFuAY+RueCO8sOdCEjkV7coOSg7ZiM+pQYHRij+qpd6qL3/uehgR2ASBBXhPkSl8s5fA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Ay+xccoW; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Ay+xccoW; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ghWZj0Xfkz2xF8 for ; Fri, 19 Jun 2026 18:53:01 +1000 (AEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 8D060423CA; Fri, 19 Jun 2026 08:52:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 321D81F00A3D; Fri, 19 Jun 2026 08:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781859179; bh=MeaEEnmBG3oFKgCGg6n5aGYQQrjBqtYm3M3kvW7MyfI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Ay+xccoWO5XnpgZk1oKZFJZZeGhQSJMAzeBZw+eAH5wtWwFtcm04l52kNpAlovzhk h7RrSXfuwshrgk9JMSOa5gswG8TeTnxcou7rigMbDDeB0SW/Fnf+XQ7bMdoRUO7AzC kH2oGAAgqooZoxxPQfdLaAyfJiBS8h0viAjuYG7lQF5/jboYz4oAG4UvIQ2OUt3ANw AkF9pmG+SZqPyW7W7GSm24iHM2bIzzq5VWixm1DWtcPvzBT3U4Lup5r3WJSwvTI52R cssdI3PSpGYUYYQ2UMqMyXxQ7Jye4oYOLxLPF17yTko7m+T8E2II4VjOZff1QPPDFw d6houki/oEC5g== From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Cc: Bjorn Helgaas , Manivannan Sadhasivam , Lorenzo Pieralisi , Alex Williamson , Magnus Lindholm , Matt Turner , Richard Henderson , Christophe Leroy , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Dexuan Cui , =?UTF-8?q?Krzysztof=20Ha=C5=82asa?= , Lukas Wunner , "Oliver O'Halloran" , Saurabh Singh Sengar , Shuan He , Srivatsa Bhat , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH v8 15/25] alpha/PCI: Remove WARN from __pci_mmap_fits() and __legacy_mmap_fits() Date: Fri, 19 Jun 2026 08:51:50 +0000 Message-ID: <20260619085200.3729431-16-kwilczynski@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260619085200.3729431-1-kwilczynski@kernel.org> References: <20260619085200.3729431-1-kwilczynski@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the WARN() that fires when userspace attempts to mmap beyond the BAR bounds. The check still returns 0 to reject the mapping, but the warning is excessive for normal operation. A similar warning was removed from the PCI core in the commit 3b519e4ea618 ("PCI: fix size checks for mmap() on /proc/bus/pci files"). Tested-by: Magnus Lindholm Tested-by: Shivaprasad G Bhat Reviewed-by: Ilpo Järvinen Acked-by: Magnus Lindholm Signed-off-by: Krzysztof Wilczyński --- arch/alpha/kernel/pci-sysfs.c | 23 +++++------------------ 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c index 8802f955256e..6cf688621ea9 100644 --- a/arch/alpha/kernel/pci-sysfs.c +++ b/arch/alpha/kernel/pci-sysfs.c @@ -48,13 +48,7 @@ static int __pci_mmap_fits(struct pci_dev *pdev, int num, start = vma->vm_pgoff; size = ((len - 1) >> (PAGE_SHIFT - shift)) + 1; - if (start < size && size - start >= nr) - return 1; - WARN(1, "process \"%s\" tried to map%s 0x%08lx-0x%08lx on %s BAR %d " - "(size 0x%08lx)\n", - current->comm, sparse ? " sparse" : "", start, start + nr, - pci_name(pdev), num, size); - return 0; + return start < size && size - start >= nr; } /** @@ -257,9 +251,8 @@ int pci_create_resource_files(struct pci_dev *pdev) /* Legacy I/O bus mapping stuff. */ -static int __legacy_mmap_fits(struct pci_controller *hose, - struct vm_area_struct *vma, - unsigned long res_size, int sparse) +static int __legacy_mmap_fits(struct vm_area_struct *vma, + unsigned long res_size) { unsigned long nr, start, size; @@ -267,13 +260,7 @@ static int __legacy_mmap_fits(struct pci_controller *hose, start = vma->vm_pgoff; size = ((res_size - 1) >> PAGE_SHIFT) + 1; - if (start < size && size - start >= nr) - return 1; - WARN(1, "process \"%s\" tried to map%s 0x%08lx-0x%08lx on hose %d " - "(size 0x%08lx)\n", - current->comm, sparse ? " sparse" : "", start, start + nr, - hose->index, size); - return 0; + return start < size && size - start >= nr; } static inline int has_sparse(struct pci_controller *hose, @@ -296,7 +283,7 @@ int pci_mmap_legacy_page_range(struct pci_bus *bus, struct vm_area_struct *vma, res_size = (mmap_type == pci_mmap_mem) ? bus->legacy_mem->size : bus->legacy_io->size; - if (!__legacy_mmap_fits(hose, vma, res_size, sparse)) + if (!__legacy_mmap_fits(vma, res_size)) return -EINVAL; return hose_mmap_page_range(hose, vma, mmap_type, sparse); -- 2.54.0